Project

General

Profile

Feature #19998

Updated by byroot (Jean Boussier) about 1 year ago

The replacement API was introduced in Ruby 1.9.2 (2010) [Feature #3064], and the old untyped data API was marked a deprecated in the documentation as of Ruby 2.3.0 (2015): https://github.com/ruby/ruby/commit/98544c372d948717de22afc86d162e411f1fb5f1 

 However, as of today, no deprecation warning of any sort is emitted when the API is used. 

 Ultimately removing the old untyped API would allow to easily reclaim 8B on every `T_DATA` which could be used by the newly introduced embedded TypedData objects https://github.com/ruby/ruby/pull/7440 

 Was there any discussions about removing the old API at some point? 

 Could we emit a warning when the API is used? Either verbose or non-verbose, to at least surface the issue to gem owners? This would help drive the effort to fix outdated gems, allowing to eventually remove this old API in the future. 

 Looking at our big applications dependencies, there seem to be a small minority of gems still using the old API: 

   - https://rubygems.org/gems/unf_ext (https://github.com/knu/ruby-unf_ext/pull/72) 
   - https://rubygems.org/gems/rotoscope (https://github.com/Shopify/rotoscope/pull/99) 
   - https://rubygems.org/gems/re2 (https://github.com/mudge/re2/pull/116) 
   - ~~https://rubygems.org/gems/mysql2~~ (use either API to support old rubies) https://rubygems.org/gems/mysql2 

 Migrating them over doesn't seem too hard. 



Back