Project

General

Profile

This project is closed and read-only.

Actions
Copy link

Backport #8228

closed

atomic_ops unavailable on Solaris 9 or earlier

Backport #8228: atomic_ops unavailable on Solaris 9 or earlier

Added by ngoto (Naohisa Goto) over 13 years ago. Updated over 13 years ago.

Status:
Closed
Assignee:
usa (Usaku NAKAMURA)
[ruby-dev:47231]

Description

アトミックな演算（man atomic_ops 参照）はSolaris 9以前には存在しないが使おうとするため、Solaris8でSunのコンパイラでは1.9.3以降がコンパイルできない、との指摘があったとtwitterで知らせてもらいました。

kosakiさん作成のパッチ https://gist.github.com/kosaki/5260762 にて、Solaris10では #define HAVE_ATOMIC_H 1 となりSolaris用atomic関数が使われることは確認しました。

Files

Download all files
20130410-ruby193-solaris-atomic.patch (974 Bytes) 20130410-ruby193-solaris-atomic.patch ngoto (Naohisa Goto), 04/10/2013 06:15 PM
20130410-ruby200-solaris-atomic.patch (961 Bytes) 20130410-ruby200-solaris-atomic.patch ngoto (Naohisa Goto), 04/10/2013 06:15 PM

Updated by ngoto (Naohisa Goto) over 13 years ago Actions
Copy link
 #1

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40163.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

Updated by nagachika (Tomoyuki Chikanaga) over 13 years ago Actions
Copy link
 #2

  • Tracker changed from Bug to Backport
  • Project changed from Ruby to 15
  • Status changed from Closed to Assigned
  • Assignee changed from ngoto (Naohisa Goto) to nagachika (Tomoyuki Chikanaga)

ruby_2_0_0 へバックポートしたいと思います。
ruby_1_9_3 にも必要でしょうか? 多分ヘッダファイル名が変更されていて別途パッチを作らないといけない気がします(未確認)。

Updated by ngoto (Naohisa Goto) over 13 years ago Actions
Copy link Download all files
 #3 [ruby-dev:47243]

ruby_1_9_3 にもバックポート希望ですが、ruby_atomic.h は ruby_1_9_3 でもファイル名変更済みで問題ありません。
それより configure.in のほうが変化が激しく、素直にパッチが当たりませんでした。
ruby_1_9_3 用、 ruby_2_0_0 用のパッチをそれぞれ添付します。(ChangeLog以外)

Updated by nagachika (Tomoyuki Chikanaga) over 13 years ago Actions
Copy link
 #4

  • Status changed from Assigned to Closed

This issue was solved with changeset r40285.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

merge revision(s) 40163: [Backport #8228]

* configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

* ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
  earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

Updated by nagachika (Tomoyuki Chikanaga) over 13 years ago Actions
Copy link
 #5

  • Project changed from 15 to 13
  • Status changed from Closed to Assigned
  • Assignee changed from nagachika (Tomoyuki Chikanaga) to usa (Usaku NAKAMURA)

Updated by usa (Usaku NAKAMURA) over 13 years ago Actions
Copy link
 #6

  • Status changed from Assigned to Closed

This issue was solved with changeset r40716.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

merge revision(s) 40163: [Backport #8228]

* configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

* ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
  earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]
Actions
Copy link

Also available in: PDF Atom