Project

General

Profile

Actions

Backport #7558

closed

Small docs bug for Regexp::union

Added by alex_gaynor (Alex Gaynor) almost 12 years ago. Updated almost 12 years ago.

Status:
Third Party's Issue
[ruby-core:50874]

Description

The docs for Regexp::union (http://ruby-doc.org/core-1.9.3/Regexp.html#method-c-union) state:

Regexp.union(/dogs/, /cats/) #=> /(?-mix:dogs)|(?i-mx:cats)/

This is, however, incorrect, /cats/ doesn't have the /i flag, either it should be added or the expected result should be changed.

Updated by steveklabnik (Steve Klabnik) almost 12 years ago

I went to go fix this, and I found that it's fixed in trunk: https://github.com/ruby/ruby/blob/trunk/re.c#L3254

I'm not sure if this justifies a backport into 1.9.x, but I'd be willing to write the patch if someone can remind me of the procedure.

Updated by zzak (zzak _) almost 12 years ago

For what it's worth, here is the original patch: https://github.com/ruby/ruby/commit/cf9bdd0

Not sure what revision that is though. And seeing as how it was originally committed 5 years ago, I'm surprised this bug still exists.

Steve, only documentation I found on backporting: https://bugs.ruby-lang.org/projects/ruby/wiki/HowToBackport

Actions #3

Updated by usa (Usaku NAKAMURA) almost 12 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport193
  • Category deleted (doc)
  • Status changed from Open to Assigned
  • Assignee set to usa (Usaku NAKAMURA)

Updated by usa (Usaku NAKAMURA) almost 12 years ago

  • Status changed from Assigned to Third Party's Issue

seems it's only on ruby-doc.org.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0