Project

General

Profile

Actions

Backport #5890

closed

Please backport r34236

Added by john_firebaugh (John Firebaugh) over 12 years ago. Updated about 12 years ago.

Status:
Closed
Assignee:
-
[ruby-core:42097]

Description

This revision resolves the following issues:

inconsistent treatment of 8 bit characters in US-ASCII (http://bugs.ruby-lang.org/issues/5855)
Integer#chr may return a string with multiple characters (http://bugs.ruby-lang.org/issues/5863)
Integer#chr raises on some invalid codepoints but returns an invalidly-encoded string for others (http://bugs.ruby-lang.org/issues/5864)


Related issues 1 (0 open1 closed)

Related to Backport193 - Backport #5878: compile error in string.c:2096 since r34236Closedusa (Usaku NAKAMURA)01/11/2012Actions
Actions #1

Updated by naruse (Yui NARUSE) about 12 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34501.
John, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 34236: [Backport #5890]

* numeric.c (rb_enc_uint_char): raise RangeError when added codepoint
  is invalid. [Feature #5855] [Bug #5863] [Bug #5864]

* string.c (rb_str_concat): ditto.

* string.c (rb_str_concat): set encoding as ASCII-8BIT when the string
  is US-ASCII and the argument is an integer greater than 127.

* regenc.c (onigenc_mb2_code_to_mbclen): rearrange error code.

* enc/euc_jp.c (code_to_mbclen): ditto.

* enc/shift_jis.c (code_to_mbclen): ditto.
Actions

Also available in: Atom PDF

Like0
Like0