Project

General

Profile

Bug #5674

[mingw] build failure due to win/win32.c `rb_w32_getc`

Added by jonforums (Jon Forums) about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
ruby -v:
-
Backport:
[ruby-core:41313]

Description

While building trunk@33852 using TDM-GCC v4.5.2 I get the following failure:

C:\Users\Jon\Documents\RubyDev\ruby-git\build>sh -c "../configure --disable-shared --disable-install-doc && make"
...
compiling ../missing/ffs.c
compiling ../missing/setproctitle.c
compiling ../win32/win32.c
../win32/win32.c: In function 'rb_w32_getc':
../win32/win32.c:4895:9: error: 'FILE' has no member named 'FILE_COUNT'
../win32/win32.c:4896:28: error: 'FILE' has no member named 'FILE_READPTR'
../win32/win32.c: In function 'rb_w32_putc':
../win32/win32.c:4915:9: error: 'FILE' has no member named 'FILE_COUNT'
../win32/win32.c:4916:29: error: 'FILE' has no member named 'FILE_READPTR'
make: *** [win32.o] Error 1

Associated revisions

Revision ed78271c
Added by kosaki (Motohiro KOSAKI) about 7 years ago

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@33859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 33859
Added by kosaki (Motohiro KOSAKI) about 7 years ago

Revision 33859
Added by kosaki (Motohiro KOSAKI) about 7 years ago

Revision 33859
Added by kosaki (Motohiro KOSAKI) about 7 years ago

Revision 33859
Added by kosaki (Motohiro KOSAKI) about 7 years ago

Revision 33859
Added by kosaki (Motohiro KOSAKI) about 7 years ago

Revision 33859
Added by kosaki (Motohiro KOSAKI) about 7 years ago

Revision 61b3acd5
Added by usa (Usaku NAKAMURA) about 7 years ago

  • win32/{Makeilfe.sub,win32.c} (FILE_COUNT, FILE_READPTR): move the definitions from config.h to win32.c. I dared to have left such macros, for other future compiler support. [ruby-core:41313] [Bug #5674]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@33875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 33875
Added by usa (Usaku NAKAMURA) about 7 years ago

  • win32/{Makeilfe.sub,win32.c} (FILE_COUNT, FILE_READPTR): move the definitions from config.h to win32.c. I dared to have left such macros, for other future compiler support. [ruby-core:41313] [Bug #5674]

Revision 33875
Added by usa (Usaku NAKAMURA) about 7 years ago

  • win32/{Makeilfe.sub,win32.c} (FILE_COUNT, FILE_READPTR): move the definitions from config.h to win32.c. I dared to have left such macros, for other future compiler support. [ruby-core:41313] [Bug #5674]

Revision 33875
Added by usa (Usaku NAKAMURA) about 7 years ago

  • win32/{Makeilfe.sub,win32.c} (FILE_COUNT, FILE_READPTR): move the definitions from config.h to win32.c. I dared to have left such macros, for other future compiler support. [ruby-core:41313] [Bug #5674]

Revision 33875
Added by usa (Usaku NAKAMURA) about 7 years ago

  • win32/{Makeilfe.sub,win32.c} (FILE_COUNT, FILE_READPTR): move the definitions from config.h to win32.c. I dared to have left such macros, for other future compiler support. [ruby-core:41313] [Bug #5674]

Revision 33875
Added by usa (Usaku NAKAMURA) about 7 years ago

  • win32/{Makeilfe.sub,win32.c} (FILE_COUNT, FILE_READPTR): move the definitions from config.h to win32.c. I dared to have left such macros, for other future compiler support. [ruby-core:41313] [Bug #5674]

Revision 33875
Added by usa (Usaku NAKAMURA) about 7 years ago

  • win32/{Makeilfe.sub,win32.c} (FILE_COUNT, FILE_READPTR): move the definitions from config.h to win32.c. I dared to have left such macros, for other future compiler support. [ruby-core:41313] [Bug #5674]

History

#1

Updated by kosaki (Motohiro KOSAKI) about 7 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r33859.
Jon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


Updated by kosaki (Motohiro KOSAKI) about 7 years ago

  • ruby -v changed from ruby 1.9.3p0 (2011-11-08 revision 33661) [i386-mingw32] to -

While building trunk@33852 using TDM-GCC v4.5.2 I get the following failure:

C:\Users\Jon\Documents\RubyDev\ruby-git\build>sh -c "../configure --disable-shared --disable-install-doc && make"
...
compiling ../missing/ffs.c
compiling ../missing/setproctitle.c
compiling ../win32/win32.c
../win32/win32.c: In function 'rb_w32_getc':
../win32/win32.c:4895:9: error: 'FILE' has no member named 'FILE_COUNT'
../win32/win32.c:4896:28: error: 'FILE' has no member named 'FILE_READPTR'
../win32/win32.c: In function 'rb_w32_putc':
../win32/win32.c:4915:9: error: 'FILE' has no member named 'FILE_COUNT'
../win32/win32.c:4916:29: error: 'FILE' has no member named 'FILE_READPTR'
make: *** [win32.o] Error 1

I'm sorry. I overlooked win32. I reverted guilty commits.

Thanks.

Updated by usa (Usaku NAKAMURA) about 7 years ago

kosaki-san, you don't have to revert.
re-commit them.

Also available in: Atom PDF