Bug #5162
closedIMAP error formatting string
Description
In the method msg_att in the file imap.rb, the parse error is written as
parse_error("unknown attribute `%s'", token.value), I believe it should be parse_error("unknown attribute '%s'", token.value).
Single quotes on both sides of %s
Updated by shugo (Shugo Maeda) over 13 years ago
- Status changed from Open to Assigned
- Assignee set to shugo (Shugo Maeda)
Updated by shugo (Shugo Maeda) over 13 years ago
art lussos wrote:
In the method msg_att in the file imap.rb, the parse error is written as
parse_error("unknown attribute `%s'", token.value), I believe it should be parse_error("unknown attribute '%s'", token.value).
Single quotes on both sides of %s
I don't know why the back quote is not good. Ruby uses back quotes in many other cases.
$ ruby -e 'foo'
-e:1:in <main>': undefined local variable or method
foo' for main:Object (NameError)
Updated by art.lussos (art lussos) about 13 years ago
Shugo Maeda wrote:
art lussos wrote:
In the method msg_att in the file imap.rb, the parse error is written as
parse_error("unknown attribute `%s'", token.value), I believe it should be parse_error("unknown attribute '%s'", token.value).
Single quotes on both sides of %s
I don't know why the back quote is not good. Ruby uses back quotes in many other cases.
$ ruby -e 'foo'
-e:1:in<main>': undefined local variable or method
foo' for main:Object (NameError)
For consistency I believe you are correct, I just felt it would make it easier to read.
Updated by shugo (Shugo Maeda) about 13 years ago
- Status changed from Assigned to Rejected
Hello,
art lussos wrote:
I don't know why the back quote is not good. Ruby uses back quotes in many other cases.
$ ruby -e 'foo'
-e:1:in<main>': undefined local variable or method
foo' for main:Object (NameError)For consistency I believe you are correct, I just felt it would make it easier to read.
So I'll close this ticket. Thanks.