Project

General

Profile

Bug #4885

[ext/openssl] Use BIO_reset and ERR_get_error in conjuntion

Added by MartinBosslet (Martin Bosslet) over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
trunk
Backport:
[ruby-core:37134]

Description

This is related to the bug in http://redmine.ruby-lang.org/issues/4879.

There are still some places in Ruby OpenSSL C code where just BIO_reset
is used but not ERR_get_error if a fallback from PEM to DER is tried or
the other way round. This might cause encoding errors to pile up and
mislead users or cause tests to fail that shouldn't.

I'd like to expose the conjunction of

BIO_reset(bio);
ERR_get_error();

as a publicly accesible macro (similar to what's in ossl_pkey.c) and
replace existing code by using it where appropriate.

Please let me know if you have any objections!

Regards,
Martin


Related issues

Related to Ruby master - Bug #4879: test_new(OpenSSL::TestPKeyRSA) fails on Win32ClosedMartinBosslet (Martin Bosslet)06/14/2011Actions

Also available in: Atom PDF