Bug #4798
closedtest_process and test_signal errors and halts on Windows
Description
Hello,
I'm trying to complete a run of tests against trunk (r31779) and find myself with several errors that halt the execution of test-all
There are two weird ones showing up on the tests:
C:/Users/Luis/Projects/oss/ruby/test/ruby/test_process.rb:444: warning: cannot close
fd before spawn
C:/Users/Luis/Projects/oss/ruby/test/ruby/test_signal.rb:205: warning: cannot close fd before spawn
And the second one stalls there until Ctrl+C is been hit, aborting the execution of other tests.
test_signal.rb:205 (test_signal_requiring) specially excludes mswin and mingw tests, but seems is actually not being skipped.
Updated by kosaki (Motohiro KOSAKI) over 13 years ago
- ruby -v changed from ruby 1.9.3dev (2011-05-29 trunk 31779) [i386-mingw32] to -
C:/Users/Luis/Projects/oss/ruby/test/ruby/test_signal.rb:205: warning: cannot close fd before spawn
And the second one stalls there until Ctrl+C is been hit, aborting the execution of other tests.
test_signal.rb:205 (test_signal_requiring) specially excludes mswin and mingw tests, but seems is actually not being skipped.
Because, following line has typo.
skip "limitation of GenerateConsoleCtrlEvent()" if /mswin|mignw/
=~ RUBY_PLATFORM
you need s/mignw/mingw/ fix. I think.
Unfortunately, I don't have mingw test environment. I hope you commit it.
Thanks.
Updated by usa (Usaku NAKAMURA) over 13 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r31824.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
- test/ruby/test_signal.rb (TestSignal#test_signal_requiring): small
but critical typo of r31642. sorry...
[Bug #4798] [ruby-core:36550]
Updated by luislavena (Luis Lavena) over 13 years ago
On Mon, May 30, 2011 at 7:08 AM, KOSAKI Motohiro
kosaki.motohiro@gmail.com wrote:
Because, following line has typo.
  skip "limitation of GenerateConsoleCtrlEvent()" if /mswin|mignw/