Project

General

Profile

Actions

Feature #4528

closed

[PATCH] ext/io/nonblock: avoid unnecessary fcntl F_SETFL calls

Added by normalperson (Eric Wong) over 13 years ago. Updated over 13 years ago.

Status:
Closed
Target version:
[ruby-core:35556]

Description

=begin
Avoid F_SETFL if we're not changing the O_NONBLOCK bit. F_SETFL
is an expensive operation since it needs to affect all processes
with the same file object.

rb_io_set_nonblock() implements similar logic to avoid F_SETFL
in io.c
=end


Files

Updated by kosaki (Motohiro KOSAKI) over 13 years ago

  • Status changed from Open to Assigned
  • Assignee set to kosaki (Motohiro KOSAKI)

=begin
Looks good to me. I'll commit this if nobody put objections.

=end

Updated by kosaki (Motohiro KOSAKI) over 13 years ago

  • Status changed from Assigned to Closed
  • Target version changed from 2.0.0 to 1.9.3

=begin
r31238.

=end

Actions

Also available in: Atom PDF

Like0
Like0Like0