Bug #3983: nmake install fail on Windows with r29591

• Status: Closed
• Assignee: -
• Target version: 2.0.0
• ruby -v: ruby 1.9.3dev (2010-10-26 trunk 29591) [i386-mswin32_90]

[phasis68 (Heesob Park)]

=begin
Due to the Revision r29591, nmake install fails on Windows with MSVC.

C:\work\snapshot>nmake install

...

installing binary commands: /usr/bin
installing base libraries: /usr/lib
installing arch files: /usr/lib/ruby/1.9.1/i386-mswin32_90
./tool/rbinstall.rb:343:in exist?': can't convert nil into String (TypeError) from ./tool/rbinstall.rb:343:in block in '
from ./tool/rbinstall.rb:555:in call' from ./tool/rbinstall.rb:555:in block (2 levels) in '
from ./tool/rbinstall.rb:552:in each' from ./tool/rbinstall.rb:552:in block in '
from ./tool/rbinstall.rb:548:in each' from ./tool/rbinstall.rb:548:in '
NMAKE : fatal error U1077: '.\miniruby.exe' : return code '0x1'
Stop.

Here is a patch

--- rbinstall.rb 2010-10-26 10:13:58.000000000 +0900
+++ rbinstall.rb.new 2010-10-26 10:15:34.000000000 +0900
@@ -340,7 +340,7 @@

install?(:local, :arch, :data) do
pc = CONFIG["ruby_pc"]

• if File.exist?(pc)

• if pc && File.exist?(pc)
  prepare "pkgconfig data", pkgconfigdir = File.join(libdir, "pkgconfig")
  install pc, pkgconfigdir, :mode => $data_mode
  end
  =end

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

=begin
This issue was solved with changeset r29595.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end