Actions
Bug #20748
closedIssue with defined? given method call with block in prism compiler
Description
test.rb
puts defined?(undefined_method(){})
./ruby --parser=parse.y -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
expression
./ruby --parser=prism -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/common -r./x86_64-linux-fake ../ruby/test.rb
# empty line
Updated by kddnewton (Kevin Newton) 3 months ago
- Assignee set to kddnewton (Kevin Newton)
I have opened a PR for this to match the behavior exactly, but I will say I think Prism's behavior is actually correct here. Right now compile.c results in:
puts defined?(undefined_method(){}) # => "expression"
puts defined?(undefined_method(&b)) # => ""
whereas Prism results in:
puts defined?(undefined_method(){}) # => ""
puts defined?(undefined_method(&b)) # => ""
I have updated the code to match compile.c, but I think it's incorrect that we are falling back to "expression" because it has an explicit block versus an implicit one.
Updated by luke-gru (Luke Gruber) 3 months ago
I agree it's weird but it could cause an incompatibility I guess, defined?()
is a weird one for sure.
Updated by kddnewton (Kevin Newton) 3 months ago
- Status changed from Open to Closed
Applied in changeset git|1e52dde82af10f2a2ec648b34dce30bec4154245.
[PRISM] Match defined behavior for explicit block
Fixes [Bug #20748]
Actions
Like0
Like0Like0Like0