Project

General

Profile

Actions

Bug #19091

closed

backport reline-0.3.1 to ruby-3.1

Added by YO4 (Yoshinao Muramatsu) about 2 years ago. Updated about 2 years ago.

Status:
Closed
Target version:
-
[ruby-core:110545]

Description

I am ashamed to say, last year I committed a work-in-progress file instead of the correct one to ruby/reline tree.
There is a bug that breaks scrolling on windows (with terminals other than command prompt?).
That mistake was included in the reline-0.3.0, also in ruby-3.1.0.

The bug fixed in reline-0.3.1 and ruby-master.
The fix on ruby side is https://github.com/ruby/ruby/commit/31c69d66d2200566695a0c88dd68cdd04a77614d

ruby-3.1 tree still seems to hold reline-0.3.0, so irb can be useless without updating gems on windows.
Is it possible to backport reline-0.3.1 to ruby-3.1?

Updated by hsbt (Hiroshi SHIBATA) about 2 years ago

  • Status changed from Open to Closed
  • Backport changed from 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN to 2.7: DONTNEED, 3.0: DONTNEED, 3.1: REQUIRED

I created the backport pull-request

https://github.com/ruby/ruby/pull/6648

Updated by hsbt (Hiroshi SHIBATA) about 2 years ago

  • Assignee set to nagachika (Tomoyuki Chikanaga)

Updated by nagachika (Tomoyuki Chikanaga) about 2 years ago

  • Backport changed from 2.7: DONTNEED, 3.0: DONTNEED, 3.1: REQUIRED to 2.7: DONTNEED, 3.0: DONTNEED, 3.1: DONE

merged at 4d1faefa10518ada452d5a85f4e43a8bfda847cc.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0