Project

General

Profile

Actions

Bug #1826

closed

json で無駄な private 指定がある

Added by okkez (okkez _) over 14 years ago. Updated almost 13 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 1.9.2dev (2009-07-27 trunk 24297) [x86_64-linux]
Backport:

Description

=begin
json で無駄な private 指定があります。
module_function は指定されたメソッドを private メソッドかつ特異メソッドにしてくれるので、
private 指定は不要だと思います。実害は無いのですが報告しておきます。

Index: ext/json/lib/json/common.rb

--- ext/json/lib/json/common.rb (revision 24302)
+++ ext/json/lib/json/common.rb (working copy)
@@ -270,7 +270,6 @@
proc.call result
end
end

  • private :recurse_proc
    module_function :recurse_proc

    alias restore load
    =end

Actions #1

Updated by naruse (Yui NARUSE) over 14 years ago

  • Status changed from Open to Assigned
  • Assignee set to naruse (Yui NARUSE)

=begin

=end

Actions #2

Updated by naruse (Yui NARUSE) over 14 years ago

  • Status changed from Assigned to Closed

=begin
commit edf05962c018e9decf6c49c141d0133c716ac770
Author: matz
Date: Tue Jul 28 18:40:17 2009 +0000

 * ext/json/lib/json/common.rb (JSON#recurse_proc): remove
   unnecessary private specifier.  [ruby-dev:38929]

 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@24310 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

=end

Actions

Also available in: Atom PDF

Like0
Like0Like0