Project

General

Profile

Actions

Misc #13702

closed

TZ checking in rb_w32_fstati64()

Added by kubo (Takehiro Kubo) almost 7 years ago. Updated over 6 years ago.

Status:
Closed
[ruby-core:81873]

Description

The environment variable TZ is checked in rb_w32_fstati64().
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/59061/entry/win32/win32.c#L5417

This was added in r48394 to make File#stat faster. I guess that
it was added not to call GetFileInformationByHandle() when TZ isn't set.
But the effect has turned off since r50870 because it calls
GetFileInformationByHandle() even when TZ isn't set.
As a result, the TZ checking in rb_w32_fstati64() is meaningless now.

IMO, the following lines could be removed without side effects.

  • if-clause in rb_w32_fstati64() (line 5417-5421 in win32/win32.c)
  • stati64_set_inode_handle() (line 5379-5390 in win32/win32.c)

Related issues 2 (0 open2 closed)

Related to Ruby master - Feature #13726: PATCH: Windows builds - fractional second file timesClosedusa (Usaku NAKAMURA)Actions
Related to Ruby master - Feature #13731: inode for Windows on ReFSClosedusa (Usaku NAKAMURA)Actions

Updated by usa (Usaku NAKAMURA) almost 7 years ago

  • Status changed from Open to Assigned
  • Assignee set to usa (Usaku NAKAMURA)
Actions #2

Updated by usa (Usaku NAKAMURA) almost 7 years ago

  • Related to Feature #13726: PATCH: Windows builds - fractional second file times added
Actions #3

Updated by usa (Usaku NAKAMURA) almost 7 years ago

Actions #4

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • Status changed from Assigned to Closed

Applied in changeset trunk|r61013.


support nanosec file timestamp on newer Windows

Support nanosec file timestamp on Windows 8 or later.
Original patches are written by kubo (Kubo Takehiro).
Windows 7 and earlier also supports nanosec file timestamp, but it's too
accurate than system time. so, this feature is disabled on such versions.
[Feature #13726]

this change also includes [Misc #13702]

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0