Misc #13702
closedTZ checking in rb_w32_fstati64()
Description
The environment variable TZ is checked in rb_w32_fstati64().
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/59061/entry/win32/win32.c#L5417
This was added in r48394 to make File#stat faster. I guess that
it was added not to call GetFileInformationByHandle() when TZ isn't set.
But the effect has turned off since r50870 because it calls
GetFileInformationByHandle() even when TZ isn't set.
As a result, the TZ checking in rb_w32_fstati64() is meaningless now.
IMO, the following lines could be removed without side effects.
- if-clause in rb_w32_fstati64() (line 5417-5421 in win32/win32.c)
- stati64_set_inode_handle() (line 5379-5390 in win32/win32.c)
Updated by usa (Usaku NAKAMURA) about 7 years ago
- Status changed from Open to Assigned
- Assignee set to usa (Usaku NAKAMURA)
Updated by usa (Usaku NAKAMURA) about 7 years ago
- Related to Feature #13726: PATCH: Windows builds - fractional second file times added
Updated by usa (Usaku NAKAMURA) about 7 years ago
- Related to Feature #13731: inode for Windows on ReFS added
Updated by usa (Usaku NAKAMURA) over 6 years ago
- Status changed from Assigned to Closed
Applied in changeset trunk|r61013.
support nanosec file timestamp on newer Windows
Support nanosec file timestamp on Windows 8 or later.
Original patches are written by kubo (Kubo Takehiro).
Windows 7 and earlier also supports nanosec file timestamp, but it's too
accurate than system time. so, this feature is disabled on such versions.
[Feature #13726]
this change also includes [Misc #13702]