Project

General

Profile

Actions

Bug #11310

closed

CSV::Table#to_csv should use concat not +

Added by zdennis (Zach Dennis) over 9 years ago. Updated about 7 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux-gnu]
[ruby-core:69745]

Description

The current implementation of CSV::Table#to_a method uses Array#+ to which is really bad on performance. It seems like it should use Array#concat.

Relevant Github PR: https://github.com/ruby/ruby/pull/946

Updated by hsbt (Hiroshi SHIBATA) over 7 years ago

  • Status changed from Open to Assigned
  • Assignee set to hsbt (Hiroshi SHIBATA)

Updated by hsbt (Hiroshi SHIBATA) about 7 years ago

  • Status changed from Assigned to Closed
  • Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED

applied at r59657

Actions

Also available in: Atom PDF

Like0
Like0Like0