Feature #4985: Add %S[] support for making a list of symbols

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -

[tenderlovemaking (Aaron Patterson)]

I would like to add %S, which would create a list of symbols.

For example:

%S[foo bar] # => [:foo, :bar]

I've attached a patch which implements this along with ripper events and tests. Thanks to Josh Susser for thinking of this. :-)

[tenderlovemaking (Aaron Patterson)]

• File qsymbols.patch qsymbols.patch added

Adding a new patch with correct indentation for parse.y

[vjoel (Joel VanderWerf)]

Wondering idly if the following could be parsed...

:[foo bar]

Eh, maybe it's too inconsistent with % notation anyway.

[matz (Yukihiro Matsumoto)]

Interesting idea (include Joel's)! But I am not sure whether they are the right prefix.

matz.

[nobu (Nobuyoshi Nakada)]

Hi,

At Thu, 7 Jul 2011 16:15:36 +0900,
Joel VanderWerf wrote in [ruby-core:37843]:

Wondering idly if the following could be parsed...

:[foo bar]

It would be possible, but conflicts with :[] ("[]".to_sym).

--
Nobu Nakada

[tenderlovemaking (Aaron Patterson)]

On Thu, Jul 07, 2011 at 04:48:51PM +0900, Yukihiro Matsumoto wrote:

Issue #4985 has been updated by Yukihiro Matsumoto.

Interesting idea (include Joel's)! But I am not sure whether they are the right prefix.

Ya. We already have %s, so %S might be confusing (especially when
compared to %w and %W). I don't care about the prefix so much as I care
about having the feature. :-)

--
Aaron Patterson
http://tenderlovemaking.com/

[tenderlovemaking (Aaron Patterson)]

On Thu, Jul 07, 2011 at 04:48:51PM +0900, Yukihiro Matsumoto wrote:

Issue #4985 has been updated by Yukihiro Matsumoto.

Interesting idea (include Joel's)! But I am not sure whether they are the right prefix.

How about %i and %I? (i stands for "intern").

--
Aaron Patterson
http://tenderlovemaking.com/

[tenderlovemaking (Aaron Patterson)]

• File deleted (noname)

[tenderlovemaking (Aaron Patterson)]

• File deleted (noname)

[rosenfeld (Rodrigo Rosenfeld Rosas)]

How about "%:(symbol1 symbol2)"?

[nobu (Nobuyoshi Nakada)]

Hi,

At Fri, 8 Jul 2011 02:36:50 +0900,
Rodrigo Rosenfeld Rosas wrote in [ruby-core:37850]:

How about "%:(symbol1 symbol2)"?

$ ruby -e 'p %:(:'
"("

Already ":" manages hard works. Don't overload anymore.

--
Nobu Nakada

[tenderlovemaking (Aaron Patterson)]

• File percent_i.patch percent_i.patch added

I've updated my patch to implement %i and %I. They have the same semantics as %w and %W (one with interpolation, one without).

What do you think of this matz?

[tenderlovemaking (Aaron Patterson)]

Bump

[shyouhei (Shyouhei Urabe)]

• Status changed from Open to Assigned

[tenderlovemaking (Aaron Patterson)]

• File feature4985.pdf feature4985.pdf added

adding a slide

[rosenfeld (Rodrigo Rosenfeld Rosas)]

I don't understand why your pdfs have a second weird slide :)

[mame (Yusuke Endoh)]

Received. Thank you!

The second page is mysterious... A cat or something walked a straight line of your keyboard? :-)

--
Yusuke Endoh [e-mail]

[ko1 (Koichi Sasada)]

I guessed that %S(...) is S-expr syntax.

example:
%S((foo bar (baz boo)) #=> [:foo, :bar, [:baz, :boo]]

(I have no idea about use-case of this S-expr literal, except Lisp like DSL)

--
// SASADA Koichi at atdot dot net

• File noname noname added

On Mon, Jul 02, 2012 at 02:17:12AM +0900, mame (Yusuke Endoh) wrote:

Issue #4985 has been updated by mame (Yusuke Endoh).

Received. Thank you!

The second page is mysterious... A cat or something walked a straight line of your keyboard? :-)

Quit likely. Sorry about the second page. ;-)

--
Aaron Patterson
http://tenderlovemaking.com/

• File noname noname added

On Mon, Jul 02, 2012 at 06:45:38AM +0900, SASADA Koichi wrote:

I guessed that %S(...) is S-expr syntax.

example:
%S((foo bar (baz boo)) #=> [:foo, :bar, [:baz, :boo]]

(I have no idea about use-case of this S-expr literal, except Lisp like DSL)

My patch (and slide) actually uses %i and %I ("i" stands for "intern")
and mirrors %w and %W. %s is already taken :-)

--
Aaron Patterson
http://tenderlovemaking.com/

[claytrump (Clay Trump)]

+1, I'd use that a lot.

Do we need two versions? Why not always interpolate? Can't see who's going
to need a symbol with a litteral #{ or \whatever in it.

This way we could have only %S and it always interpolates.

[nobu (Nobuyoshi Nakada)]

=begin
The latest ((%percent_i.patch%)) seems almost fine, except for a conflict in ((%parse.y%)).
=end

[nobu (Nobuyoshi Nakada)]

=begin
Seems like ((%ext/ripper/eventids2.c%)) misses (({tSYMBOLS_BEG})).
=end

[mame (Yusuke Endoh)]

• Assignee changed from matz (Yukihiro Matsumoto) to nobu (Nobuyoshi Nakada)

Aaron Patterson,

I'm happy to inform you that matz has accepted your proposal.

Matz was worried about the letter `i' and searching other ones,
but finally accepted.

Nakada-san,

Could you review the patch attached?

--
Yusuke Endoh [e-mail]

[tenderlovemaking (Aaron Patterson)]

• File 4985.patch 4985.patch added

I've attached an updated patch that includes the correct symbols, fixes the ripper tests, and fixes the conflicts.

Nakada-san: if you're happy with this patch, I can apply. :)

[nobu (Nobuyoshi Nakada)]

Seems fine to me.

[tenderlovemaking (Aaron Patterson)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r36524.
Aaron, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• parse.y: added symbols and qsymbols productions for %i and %I
  support. %i{ .. } returns a list of symbols without interpolation,
  %I{ .. } returns a list of symbols with interpolation. Thanks to
  Josh Susser for inspiration of this feature. [Feature #4985]

• ext/ripper/eventids2.c: added ripper events for %i and %I.

• test/ripper/test_parser_events.rb: ripper tests

• test/ripper/test_scanner_events.rb: ditto

• test/ruby/test_array.rb: test for %i and %I behavior