I would like to use the tar implementation inside a Ractor, but two of the constants are not frozen. This patch freezes the constants so we can use it in a Ractor. https://github.com/ruby/rubygems/commit/0ff4790f4ctenderlovemaking (Aaron Patterson)
In any case, I think we should remove the code from `Set.new`. The original ticket was about the behavior of `Range#to_set` vs `Range#to_a`, _not_ about `Set.new`. At least `Set.new`'s behavior should be restored.tenderlovemaking (Aaron Patterson)
* [Bug #21654] Set#new calls extra methods compared to previous versions * Set#new is calling "size" on its input, this is causing extra database queries in our app * The bug was introduced in d4020dd5faf28486123853e7f00c36139fc077...tenderlovemaking (Aaron Patterson)
mame (Yusuke Endoh) wrote in #note-13: > I understand your point, but I personally disagree. > ... 💯 > That said, I recall @matz expressing a similar concern to yours. I would like to hear his opinion on this matter. I'll add thi...tenderlovemaking (Aaron Patterson)
mame (Yusuke Endoh) wrote in #note-9: > Dan0042 (Daniel DeLorme) wrote in #note-7: > ... I personally agree with this. If I write an infinite loop, I expect it to loop infinitely, even if I wrote the infinite loop by mistake. Calling...tenderlovemaking (Aaron Patterson)
This commit fixes the case when there are multiple missing or incorrect keywords provided to a method. Without this fix, ErrorHighlight itself will raise an exception https://github.com/ruby/error_highlight/commit/8bde92b36etenderlovemaking (Aaron Patterson)
mame (Yusuke Endoh) wrote in #note-5: > > How about handling only `Range` and `Enumerator` (not `Enumerable`) for now? > ... I sent a pull request that only handles `Range` for now: https://github.com/ruby/ruby/pull/14990 This fixe...tenderlovemaking (Aaron Patterson)
k0kubun (Takashi Kokubun) wrote in #note-1: > How about handling only `Range` and `Enumerator` (not `Enumerable`) for now? Avoiding an extra DB query on ActiveRecord relations seems like a more important use case than preventing user-de...tenderlovemaking (Aaron Patterson)
I'm trying to test Ruby 3.5.0 with our Rails application and we've found that `Set.new` is now causing extra database queries to happen. The changes in d4020dd5faf call "size" on enumerable objects that are passed to the `new` method,...tenderlovemaking (Aaron Patterson)
matz (Yukihiro Matsumoto) wrote in #note-24: > Is there any real-world use-case for Integer#popcount method? > ... Yes, I am using it for a [bit set gem](https://github.com/tenderlove/bitz) (I had to implement my own popcount [here](ht...tenderlovemaking (Aaron Patterson)