Project

General

Profile

Bug #21847

Updated by Earlopain (Earlopain _) 3 months ago

Prism contains a translation layer for ripper, which until very recently didn't emit `on_sp` tokens. This has now been implemented to improve compatibility. 

 However right after merging some `syntax_suggest` tests started failing: https://gist.github.com/schneems/834c75345b2085bda54dab69d913bcc0. `syntax_suggest` is using the ripper translation layer and is working around the missing `on_sp` tokens. Now that they are correctly created by prism, `syntax_suggest` is not able to handle these. 

 For prism this is just a bugfix but I do not want to break `syntax_suggest` unnecessarily. I asked @schneems and this is what he had to say about it: https://github.com/ruby/syntax_suggest/pull/243#issuecomment-3779113958 

 Backport PRs: 
 * 4.0 https://github.com/ruby/ruby/pull/15922 
 * 3.4 https://github.com/ruby/ruby/pull/15923 
 * 3.3 https://github.com/ruby/ruby/pull/15924

Back