Project

General

Profile

Backport #8502

Backport r41175

Added by charliesome (Charlie Somerville) over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:55373]

Description

r41175 fixes Module#include failing to increment ruby_vm_global_state_version when a module without any methods was included into a class.

This can cause constant lookups to be incorrectly cached.


Related issues

Has duplicate Backport200 - Backport #8504: backport r41175 (clear inline cache when included Module has constants)Closed06/09/2013Actions

Associated revisions

Revision f31a47fd
Added by nagachika (Tomoyuki Chikanaga) over 6 years ago

merge revision(s) 41175: [Backport #8502]

    * class.c (include_modules_at): invalidate method cache if included
      module contains constants

    * test/ruby/test_module.rb: add test

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@41192 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 41192
Added by nagachika (Tomoyuki Chikanaga) over 6 years ago

merge revision(s) 41175: [Backport #8502]

* class.c (include_modules_at): invalidate method cache if included
  module contains constants

* test/ruby/test_module.rb: add test

History

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Status changed from Open to Assigned
#2

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41192.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41175: [Backport #8502]

* class.c (include_modules_at): invalidate method cache if included
  module contains constants

* test/ruby/test_module.rb: add test

Also available in: Atom PDF