Backport #776: File#flush doesn't flush in windows

• Status: Closed
• Assignee: wyhaines (Kirk Haines)

[rogerdpack (Roger Pack)]

=begin
In windows, File#flush flushes ruby's internal buffers, however, the result is different from Linux.
I'd recommend adding an arbitrary fsync if you're in windows to ensure the buffers are actually flushed, to avoid unexpected cross platform bugs [such as one that attachment_fu has].
[ruby-core:19940]
This in 1.9/1.8.x
Thanks!
-=Roger
=end

[matz (Yukihiro Matsumoto)]

• Assignee set to usa (Usaku NAKAMURA)

=begin

=end

[usa (Usaku NAKAMURA)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

=begin
Applied in changeset r20982.
=end

[rogerdpack (Roger Pack)]

=begin
Thanks for doing that. Would it be possible to backport these to 1.8 branch, too?

=end

[rogerdpack (Roger Pack)]

=begin
Wonder if it's related to recent zlib difficulties:
http://www.misuse.org/science/2007/09/07/ruby-zlib-buffer-error-on-windows/`

=end

[shyouhei (Shyouhei Urabe)]

• Status changed from Closed to Open
• % Done changed from 100 to 0

=begin
Moved to backport/1.8
=end

[usa (Usaku NAKAMURA)]

• Status changed from Open to Assigned

=begin

=end

[usa (Usaku NAKAMURA)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

=begin
Applied in changeset r24223.
=end

[rogerdpack (Roger Pack)]

=begin
thanks for doing that.
=r
=end

[shyouhei (Shyouhei Urabe)]

• Status changed from Closed to Assigned
• Assignee changed from usa (Usaku NAKAMURA) to shyouhei (Shyouhei Urabe)

=begin

=end

[shyouhei (Shyouhei Urabe)]

• Status changed from Assigned to Closed

=begin
Applied in changeset r24406.
=end

[shyouhei (Shyouhei Urabe)]

• Status changed from Closed to Assigned
• Assignee changed from shyouhei (Shyouhei Urabe) to wyhaines (Kirk Haines)

=begin

=end

[wyhaines (Kirk Haines)]

• Status changed from Assigned to Closed

=begin
This issue was solved with changeset r28003.
Roger, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end