Project

General

Profile

Actions

Bug #2974

closed

WEBrick error in httpstatus

Added by orgads (Orgad Shaneh) about 14 years ago. Updated almost 13 years ago.

Status:
Closed
ruby -v:
ruby 1.8.7 (2010-01-10 patchlevel 249) [i486-linux]
[ruby-core:28692]

Description

=begin
HTTPStatus has some Status classes, which derive from StandardError < Exception.

In Status::initialize, message (which should return a string) is defined to self.class (which is not a string). When the exception is raised, trying to read its message and manipulate it as a string fails.

This issue causes redmine to behave strange when it raises HttpNotModified exception (http 304). It crashes on HTMLUtils escape, and thus return http 500 internal error, leaving the browser without the requested file (which is .js or .css).

I'm attaching a patch I wrote for that. I don't have any experience with ruby, so I just did what felt right. Feel free to modify it as needed :)
=end


Files

httpstatus.patch (386 Bytes) httpstatus.patch orgads (Orgad Shaneh), 03/17/2010 02:27 AM
Actions #1

Updated by nobu (Nobuyoshi Nakada) about 14 years ago

  • Category set to lib
  • Status changed from Open to Assigned
  • Assignee set to shyouhei (Shyouhei Urabe)

=begin

=end

Actions #2

Updated by orgads (Orgad Shaneh) about 14 years ago

=begin
anything new?
=end

Actions #3

Updated by orgads (Orgad Shaneh) almost 14 years ago

=begin
Hello?
=end

Actions #4

Updated by shyouhei (Shyouhei Urabe) almost 14 years ago

=begin
Sorry for a late reply, I'm working on this issue. Please be patient a bit more.
=end

Actions #5

Updated by shyouhei (Shyouhei Urabe) almost 14 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r28248.
Orgad, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0