https://redmine.ruby-lang.org/
https://redmine.ruby-lang.org/favicon.ico?1711330511
2013-12-03T09:09:17Z
Ruby Issue Tracking System
Ruby master - Bug #9202: Array#uniq freezes duplicate strings
https://redmine.ruby-lang.org/issues/9202?journal_id=43374
2013-12-03T09:09:17Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul><li><strong>ruby -v</strong> changed from <i>ruby 2.0.0dev (2012-11-29 trunk 37968) [x86_64-darwin12.2.0]</i> to <i>ruby 2.1.0dev (2013-12-02 trunk 43958) [x86_64-darwin13.0]</i></li></ul>
Ruby master - Bug #9202: Array#uniq freezes duplicate strings
https://redmine.ruby-lang.org/issues/9202?journal_id=43379
2013-12-03T11:23:26Z
normalperson (Eric Wong)
normalperson@yhbt.net
<ul></ul><p>It's not r43870 (Use rb_fstring() to de-duplicate hash string keys)<br>
Bisecting now...</p>
Ruby master - Bug #9202: Array#uniq freezes duplicate strings
https://redmine.ruby-lang.org/issues/9202?journal_id=43380
2013-12-03T11:23:26Z
normalperson (Eric Wong)
normalperson@yhbt.net
<ul></ul><p>bisected to r43194:</p>
<pre><code> * array.c (rb_ary_uniq): use rb_hash_keys().
* internal.h: define rb_hash_keys() as internal API.
* hash.c (rb_hash_keys): ditto.
</code></pre>
Ruby master - Bug #9202: Array#uniq freezes duplicate strings
https://redmine.ruby-lang.org/issues/9202?journal_id=43381
2013-12-03T12:10:57Z
normalperson (Eric Wong)
normalperson@yhbt.net
<ul><li><strong>File</strong> <a href="/attachments/4082">0001-Array-uniq-uniq-does-not-return-frozen-hash-keys.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4082/0001-Array-uniq-uniq-does-not-return-frozen-hash-keys.patch">0001-Array-uniq-uniq-does-not-return-frozen-hash-keys.patch</a> added</li></ul><p>This should fix it, can you confirm/? Thanks</p>
Ruby master - Bug #9202: Array#uniq freezes duplicate strings
https://redmine.ruby-lang.org/issues/9202?journal_id=43388
2013-12-03T13:53:28Z
Glass_saga (Masaki Matsushita)
glass.saga@gmail.com
<ul><li><strong>Assignee</strong> changed from <i>Anonymous</i> to <i>Glass_saga (Masaki Matsushita)</i></li></ul><p>I confirmed it. Thank you for your patch!</p>
Ruby master - Bug #9202: Array#uniq freezes duplicate strings
https://redmine.ruby-lang.org/issues/9202?journal_id=43389
2013-12-03T13:55:54Z
Anonymous
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r43969.<br>
Eric, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<ul>
<li>
<p>array.c (ary_add_hash): set and return values because string keys<br>
will be frozen. <a href="/issues/9202">[ruby-core:58809]</a> [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Array#uniq freezes duplicate strings (Closed)" href="https://redmine.ruby-lang.org/issues/9202">#9202</a>]</p>
</li>
<li>
<p>array.c (rb_ary_uniq_bang): ditto.</p>
</li>
<li>
<p>array.c (rb_ary_or): ditto.</p>
</li>
<li>
<p>array.c (rb_ary_uniq): ditto.</p>
</li>
<li>
<p>test/ruby/test_array.rb: tests for above.</p>
</li>
</ul>
<p>The patch is from normalperson (Eric Wong).</p>
Ruby master - Bug #9202: Array#uniq freezes duplicate strings
https://redmine.ruby-lang.org/issues/9202?journal_id=43399
2013-12-04T09:23:10Z
normalperson (Eric Wong)
normalperson@yhbt.net
<ul></ul><p>"Glass_saga (Masaki Matsushita)" <a href="mailto:glass.saga@gmail.com" class="email">glass.saga@gmail.com</a> wrote:</p>
<blockquote>
<p>I confirmed it. Thank you for your patch!</p>
</blockquote>
<p>No problem, thanks for the review.</p>
<p>Also, I think we may remove rb_hash_keys from internal.h and make it<br>
static again.</p>