https://redmine.ruby-lang.org/
https://redmine.ruby-lang.org/favicon.ico?1711330511
2008-12-16T01:06:49Z
Ruby Issue Tracking System
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2076
2008-12-16T01:06:49Z
Chauk-Mean (Chauk-Mean Proum)
<ul></ul><p>=begin<br>
Oups !<br>
The title is a bit erroneous. It should have been :<br>
zlib 1.2.3 is not supported by Rubygems 1.3.1 (in Ruby 1.9.1) on Windows.<br>
=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2168
2008-12-20T22:40:14Z
yugui (Yuki Sonoda)
yugui@yugui.jp
<ul><li><strong>Assignee</strong> set to <i>usa (Usaku NAKAMURA)</i></li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>5</i></li></ul><p>=begin</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2174
2008-12-21T00:05:11Z
yugui (Yuki Sonoda)
yugui@yugui.jp
<ul><li><strong>Due date</strong> set to <i>12/24/2008</i></li></ul><p>=begin</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2387
2008-12-28T22:38:36Z
yugui (Yuki Sonoda)
yugui@yugui.jp
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Rejected</i></li></ul><p>=begin<br>
can't reproduce<br>
=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2420
2008-12-29T17:11:09Z
Chauk-Mean (Chauk-Mean Proum)
<ul></ul><p>=begin<br>
Sorry to bother with this issue ... but this really does not work with Visual C++ 2008.<br>
I completely rebuilt zlib and ruby as described on another machine and I had the same problem.</p>
<p>Conversely, a rebuild with Visual C++ 6.0 works ! I have been able to install a gem without any problem.</p>
<p>Have you tried to reproduce with Visual C++ 2008 ?<br>
Can you give the steps you followed if they are different from mine ?</p>
<p>Thanks.</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2441
2008-12-30T00:09:58Z
yugui (Yuki Sonoda)
yugui@yugui.jp
<ul><li><strong>Status</strong> changed from <i>Rejected</i> to <i>Open</i></li></ul><p>=begin</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2443
2008-12-30T00:15:26Z
Anonymous
<ul></ul><p>=begin<br>
I can reproduce this issue, and I think following method might<br>
have fixed that.</p>
<ol>
<li>
<p>open ``c:/opt/ruby19/lib/ruby19/1.9.1/rubygems/package/tar_input.rb''</p>
</li>
<li>
<p>edit ``zipped_stream(entry)'' (line 203--216) as follows:</p>
<p>def zipped_stream(entry)<br>
if defined? Rubinius then<br>
zis = Zlib::GzipReader.new entry<br>
dis = zis.read<br>
is = StringIO.new(dis)<br>
else<br>
# This is Jamis Buck's Zlib workaround for some unknown issue<br>
entry.read(10) # skip the gzip header<br>
zis = Zlib::Inflate.new(-Zlib::MAX_WBITS)</p>
<pre><code>######### EDIT START ###
#is = StringIO.new(zis.inflate(entry.read))
__buf = ""
while __temp = entry.read( 128 * 1024 ) do
__buf << zis.inflate( __temp )
end
is = StringIO.new( __buf )
######### EDIT END #####
</code></pre>
<p>end<br>
ensure<br>
zis.finish if zis<br>
end</p>
</li>
</ol>
<p>On my machine this method seems like working, but I'm not sure it works correctly.<br>
Could you confirm this?</p>
<p>Regards.</p>
<p>Y. MISE</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2445
2008-12-30T00:52:08Z
Chauk-Mean (Chauk-Mean Proum)
<ul></ul><p>=begin<br>
This works perfectly !<br>
Thanks a lot.</p>
<p>Regards.</p>
<p>Chauk-Mean.<br>
=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2446
2008-12-30T01:53:12Z
luislavena (Luis Lavena)
luislavena@gmail.com
<ul></ul><p>=begin<br>
If you're building Ruby with VC9 (VS2008) then you need to also build zlib with VC9.</p>
<p>The problems you're experiencing can (and most of the cases are) related to cross CRT issues.</p>
<p>zlib is linked to MSVCRT while your Ruby links to MSVCR90. Freeing and allocating memory across CRTs generates errors, segfaults and other weird results.</p>
<p>Daniel Berger had problems building zlib with VC8/9 too. Why don't you try MinGW (GCC)?</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2447
2008-12-30T06:06:02Z
Chauk-Mean (Chauk-Mean Proum)
<ul></ul><p>=begin</p>
<blockquote>
<p>If you're building Ruby with VC9 (VS2008) then you need to also build zlib with VC9.<br>
Of course, that's what I've done. Please take a look at my initial bug report.</p>
</blockquote>
<blockquote>
<p>Daniel Berger had problems building zlib with VC8/9 too.<br>
I had no problem with building zlib in itself.<br>
Ruby works also fine with zlib (all tests in test/zlib passed successfully).<br>
The problem I had was related with Rubygems.<br>
This is now fixed thanks to the patch from Yasuhiro.</p>
</blockquote>
<blockquote>
<p>Why don't you try MinGW (GCC)?<br>
I also use MinGW and I have other problems at the moment related with wxWidgets ...<br>
I patched MinGW and wxWidgets for the GDI+ support, some samples work fine, others don't work (e.g. RichTextCtrl).<br>
Hopefully, this doesn't prevent the correct build of the wxRuby gem.</p>
</blockquote>
<p>Conversely, I have no problem with the VS 2008 build of wxWidgets.</p>
<p>Chauk-Mean.</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2449
2008-12-30T15:11:22Z
Anonymous
<ul></ul><p>=begin<br>
well.. I think this might be caused by shortage of<br>
buffer or something.</p>
<p>If I change the line:<br>
while __temp = entry.read( 128 * 1024 ) do<br>
to:<br>
while __temp = entry.read( 512 * 1024 ) do</p>
<p>then, the latter causes segmentation fault on my machine.</p>
<p>Size of rspec-1.1.11.gem is approx. 260KB, so, perhaps<br>
buffer of zis.inflate() is not enough to handle 260KB??<br>
=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2458
2008-12-30T21:48:33Z
yugui (Yuki Sonoda)
yugui@yugui.jp
<ul><li><strong>Target version</strong> changed from <i>1.9.1 Release Candidate</i> to <i>1.9.1 RC2</i></li></ul><p>=begin</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2467
2008-12-31T07:15:59Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul></ul><p>=begin<br>
On Dec 29, 2008, at 07:14 AM, Yasuhiro MISE wrote:</p>
<blockquote>
<ol start="2">
<li>edit ``zipped_stream(entry)'' (line 203--216) as follows:</li>
</ol>
<p>def zipped_stream(entry)<br>
if defined? Rubinius then<br>
zis = Zlib::GzipReader.new entry<br>
dis = zis.read<br>
is = StringIO.new(dis)<br>
else<br>
# This is Jamis Buck's Zlib workaround for some unknown issue<br>
entry.read(10) # skip the gzip header<br>
zis = Zlib::Inflate.new(-Zlib::MAX_WBITS)</p>
<pre><code>######### EDIT START ###
#is = StringIO.new(zis.inflate(entry.read))
__buf = ""
while __temp = entry.read( 128 * 1024 ) do
__buf << zis.inflate( __temp )
end
is = StringIO.new( __buf )
######### EDIT END #####
</code></pre>
<p>end<br>
ensure<br>
zis.finish if zis<br>
end</p>
</blockquote>
<p>For what it's worth, I'd really like to see the root cause of this bug<br>
fixed so this method can be returned to a simpler form:</p>
<p>def zipped_stream(entry)<br>
zis = Zlib::GzipReader.new entry<br>
dis = zis.read<br>
is = StringIO.new(dis)<br>
ensure<br>
zis.finish if zis<br>
end</p>
<p>Or even:</p>
<p>def zipped_stream(entry)<br>
Zlib::GzipReader.new entry<br>
end</p>
<p>I'm not sure where the bug actually exists, but I'd really like to see<br>
the bug fixed. I'm fairly certain the bug doesn't exist in RubyGems<br>
and I'm tired of having to continually apply bandaids to RubyGems.</p>
<p>While we're on the subject, what help can I provide so I can<br>
eventually get back to the bandaid-free version?</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2468
2008-12-31T10:46:23Z
luislavena (Luis Lavena)
luislavena@gmail.com
<ul></ul><p>=begin<br>
On Tue, Dec 30, 2008 at 8:15 PM, Eric Hodel <a href="mailto:drbrain@segment7.net" class="email">drbrain@segment7.net</a> wrote:</p>
<blockquote>
<p>On Dec 29, 2008, at 07:14 AM, Yasuhiro MISE wrote:</p>
<blockquote>
<ol start="2">
<li>edit ``zipped_stream(entry)'' (line 203--216) as follows:</li>
</ol>
<p>def zipped_stream(entry)<br>
if defined? Rubinius then<br>
zis = Zlib::GzipReader.new entry<br>
dis = zis.read<br>
is = StringIO.new(dis)<br>
else</p>
<a name="This-is-Jamis-Bucks-Zlib-workaround-for-some-unknown-issue"></a>
<h1 >This is Jamis Buck's Zlib workaround for some unknown issue<a href="#This-is-Jamis-Bucks-Zlib-workaround-for-some-unknown-issue" class="wiki-anchor">¶</a></h1>
<p>entry.read(10) # skip the gzip header<br>
zis = Zlib::Inflate.new(-Zlib::MAX_WBITS)</p>
<p>######### EDIT START ###<br>
#is = StringIO.new(zis.inflate(entry.read))</p>
<p>__buf = ""<br>
while __temp = entry.read( 128 * 1024 ) do<br>
__buf << zis.inflate( __temp )<br>
end</p>
<p>is = StringIO.new( __buf )<br>
######### EDIT END #####</p>
<p>end<br>
ensure<br>
zis.finish if zis<br>
end</p>
</blockquote>
<p>For what it's worth, I'd really like to see the root cause of this bug fixed<br>
so this method can be returned to a simpler form:</p>
<p>def zipped_stream(entry)<br>
zis = Zlib::GzipReader.new entry<br>
dis = zis.read<br>
is = StringIO.new(dis)<br>
ensure<br>
zis.finish if zis<br>
end</p>
<p>Or even:</p>
<p>def zipped_stream(entry)<br>
Zlib::GzipReader.new entry<br>
end</p>
<p>I'm not sure where the bug actually exists, but I'd really like to see the<br>
bug fixed. I'm fairly certain the bug doesn't exist in RubyGems and I'm<br>
tired of having to continually apply bandaids to RubyGems.</p>
<p>While we're on the subject, what help can I provide so I can eventually get<br>
back to the bandaid-free version?</p>
</blockquote>
<p>Gregory Brown offered backport the zlib tests from 1.9 to 1.8 in<br>
<a href="https://blade.ruby-lang.org/ruby-core/20602">[ruby-core:20602]</a></p>
<p>Maybe those can help pinpoint the root of the problem.</p>
<p>I offer my Windows resources to see if the problem is located on this<br>
side of the bench.</p>
<h2>--<br>
Luis Lavena<br>
AREA 17</h2>
<p>Perfection in design is achieved not when there is nothing more to add,<br>
but rather when there is nothing more to take away.<br>
Antoine de Saint-Exupéry</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2470
2008-12-31T13:04:00Z
Anonymous
<ul></ul><p>=begin<br>
Eric Hodel wrote:</p>
<blockquote>
<p>For what it's worth, I'd really like to see the root cause of this bug<br>
fixed so this method can be returned to a simpler form:</p>
<p>def zipped_stream(entry)<br>
zis = Zlib::GzipReader.new entry<br>
dis = zis.read<br>
is = StringIO.new(dis)<br>
ensure<br>
zis.finish if zis<br>
end</p>
<p>Or even:</p>
<p>def zipped_stream(entry)<br>
Zlib::GzipReader.new entry<br>
end</p>
</blockquote>
<p>Thanks your advice, and yes, each forms works fine!<br>
Hope that Chauk-Mean can also confirm that these forms fix this issue.</p>
<blockquote>
<p>I'm fairly certain the bug doesn't exist in RubyGems</p>
</blockquote>
<p>I agree, and I also agree to Luis's indication:</p>
<blockquote>
<p>Gregory Brown offered backport the zlib tests from 1.9 to 1.8 in<br>
<a href="https://blade.ruby-lang.org/ruby-core/20602">[ruby-core:20602]</a></p>
<p>Maybe those can help pinpoint the root of the problem.</p>
</blockquote>
<p>Y. MISE<br>
=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2476
2008-12-31T18:01:22Z
Chauk-Mean (Chauk-Mean Proum)
<ul></ul><p>=begin<br>
<a class="user active user-mention" href="https://redmine.ruby-lang.org/users/2336">@luis (Luis Lopez)</a></p>
<blockquote>
<p>Gregory Brown offered backport the zlib tests from 1.9 to 1.8 in <a href="https://blade.ruby-lang.org/ruby-core/20602">[ruby-core:20602]</a><br>
Maybe those can help pinpoint the root of the problem.</p>
</blockquote>
<p>I'm running ruby-1.9.1 from the beginning and as I indicated in a previous message, all zlib tests pass successfully.</p>
<p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/2491">@eric (Eric Anderson)</a></p>
<blockquote>
<p>I'm not sure where the bug actually exists, but I'd really like to see<br>
the bug fixed. I'm fairly certain the bug doesn't exist in RubyGems<br>
and I'm tired of having to continually apply bandaids to RubyGems.</p>
</blockquote>
<p>I'm sorry to "have accused" Rubygems for this bug. But the zlib tests are OK.<br>
May be there is a missing test case in zlib ?</p>
<p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/2491">@eric (Eric Anderson)</a> and <a class="user active user-mention" href="https://redmine.ruby-lang.org/users/8521">@yasuhiro (Yasuhiro Yoshida)</a></p>
<blockquote>
<p>For what it's worth, I'd really like to see the root cause of this bug<br>
fixed so this method can be returned to a simpler form:</p>
<p>def zipped_stream(entry)<br>
zis = Zlib::GzipReader.new entry<br>
dis = zis.read<br>
is = StringIO.new(dis)<br>
ensure<br>
zis.finish if zis<br>
end</p>
<p>Or even:</p>
<p>def zipped_stream(entry)<br>
Zlib::GzipReader.new entry<br>
end</p>
</blockquote>
<p>Yes, the two forms work also fine for me.<br>
The second looks really better (simple is better :-)).</p>
<p>Chauk-Mean.</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2682
2009-01-21T01:32:46Z
yugui (Yuki Sonoda)
yugui@yugui.jp
<ul><li><strong>Target version</strong> changed from <i>1.9.1 RC2</i> to <i>1.9.1</i></li></ul><p>=begin</p>
<p>=end</p>
Ruby master - Bug #888: zlib 1.2.3 does not work with Rubygems 1.3.1 (in Ruby 1.9.1) on Windows
https://redmine.ruby-lang.org/issues/888?journal_id=2791
2009-01-28T22:57:06Z
usa (Usaku NAKAMURA)
usa@garbagecollect.jp
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>=begin<br>
Applied in changeset r21859.<br>
=end</p>