https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112013-04-01T23:56:42ZRuby Issue Tracking SystemRuby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=380842013-04-01T23:56:42Zluislavena (Luis Lavena)luislavena@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>usa (Usaku NAKAMURA)</i></li></ul><p>Hello Denis,</p>
<p>As commented on RubyInstaller list, I think will be better to extend the functionality of built-in ANSI coloring instead of disable it.</p>
<p>Please take a look to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Supporing a subset of ANSI escape code on Windows (Closed)" href="https://redmine.ruby-lang.org/issues/6418">#6418</a> were I provide bench results on how external tools monkey patching result in process slowdown:</p>
<p><a href="http://bugs.ruby-lang.org/issues/6418" class="external">http://bugs.ruby-lang.org/issues/6418</a></p>
<p><a href="https://gist.github.com/luislavena/2655794" class="external">https://gist.github.com/luislavena/2655794</a></p>
<p>PS: Please open tickets to trunk, not Ruby 2.0.</p> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=380852013-04-02T00:19:16ZVersum (Denis Zinin)denis.zinin@gmail.com
<ul></ul><p>I think it will be better to introduce comand line key to disable builtin escape secuences processing (and it will be so better other way: special key to enable built-in escape processing). Anyway I think ruby never can give so wide support of escape secuences as it potentially can give external terminals. And so support is not ruby mission.</p>
<p>I think unacceptable that ruby forbid correct escape secuencecs output to external terminal. Standart windows console have winapi functions for very poor colorizing support. How do you want realize extended features of escape secuences by built-it in ruby? I want can define 256 palette with 24 bit colors. I want can use 24 bit pry-theme themes. I want can output any custom escape secuences into terminal. Winapi console function can't do that at all. Current approach with builtin escape processing make extended colorizing and others impossible. It seems very very strange that programming language make some output secuences impossible.</p>
<p>In conclusion. It will be better make spetial key or may be gem to enable or disable ruby escape processing for output.</p> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=380862013-04-02T00:43:41Zluislavena (Luis Lavena)luislavena@gmail.com
<ul><li><strong>Tracker</strong> changed from <i>Backport</i> to <i>Feature</i></li><li><strong>Project</strong> changed from <i>Backport200</i> to <i>Ruby master</i></li></ul> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=381462013-04-03T11:42:27Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul></ul><p>ConEmu doesn't seem working with 1.9.3 to me.<br>
While it shows color bars certainly when `type AnsiColor16.ans', however it does nothing with a command simply writes the same string by WriteConsole or WriteFile, but seems same as a plain command prompt window, e.g., left arrow, a bracket, and so on.</p>
<p>Does anybody see expected results?</p>
<p>Anyhow, I'll fix a bug that ESC not followed by a bracket is dropped.</p> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=381602013-04-03T17:11:28Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r40078.<br>
Denis, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<p>win32.c: pass through unknown sequence</p>
<ul>
<li>win32/win32.c (constat_apply): pass through unknown sequence which<br>
starts with ESC but is not followed by a bracket. <a href="/issues/8201">[ruby-core:53879]</a><br>
[Bug <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Turn off builded colorizing (Closed)" href="https://redmine.ruby-lang.org/issues/8201">#8201</a>]</li>
</ul> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=381622013-04-03T17:37:23Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Open</i></li><li><strong>% Done</strong> changed from <i>100</i> to <i>50</i></li></ul> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=381662013-04-03T19:16:59ZVersum (Denis Zinin)denis.zinin@gmail.com
<ul></ul><p>Last development version ConEmu working for me.</p>
<p>nobu (Nobuyoshi Nakada) wrote:</p>
<blockquote>
<p>ConEmu doesn't seem working with 1.9.3 to me.<br>
While it shows color bars certainly when `type AnsiColor16.ans', however it does nothing with a command simply writes the same string by WriteConsole or WriteFile, but seems same as a plain command prompt window, e.g., left arrow, a bracket, and so on.</p>
<p>Does anybody see expected results?</p>
<p>Anyhow, I'll fix a bug that ESC not followed by a bracket is dropped.</p>
</blockquote> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=381672013-04-03T19:21:36ZVersum (Denis Zinin)denis.zinin@gmail.com
<ul></ul><p>Passing unknown escape sequences is not solution. Some escape sequences behaviour is depended from earlier escape sequences or define behaviour of later escape sequences. This is especialy right for colorizing sentences. I think it will be many conflict and wrong behaviour when some colorizing sequences processed by ruby and other colorizing sequences processed by terminal.</p>
<p>nobu (Nobuyoshi Nakada) wrote:</p>
<blockquote>
<p>This issue was solved with changeset r40078.<br>
Denis, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<p>win32.c: pass through unknown sequence</p>
<ul>
<li>win32/win32.c (constat_apply): pass through unknown sequence which<br>
starts with ESC but is not followed by a bracket. <a href="/issues/8201">[ruby-core:53879]</a><br>
[Bug <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Turn off builded colorizing (Closed)" href="https://redmine.ruby-lang.org/issues/8201">#8201</a>]</li>
</ul>
</blockquote> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=381972013-04-04T10:13:23Zusa (Usaku NAKAMURA)usa@garbagecollect.jp
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> changed from <i>usa (Usaku NAKAMURA)</i> to <i>nobu (Nobuyoshi Nakada)</i></li></ul> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=418102013-09-15T00:07:49ZVersum (Denis Zinin)denis.zinin@gmail.com
<ul></ul><p>Problem still exist in p247. Please, remove processing of escape sequences from ruby interpreter (I think this is true solution). Or remove processing unknown sequences.</p> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=422472013-10-03T18:20:55Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li></ul><p>This issue was solved with changeset r43131.<br>
Denis, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<p>win32.c: disable console colorizing</p>
<ul>
<li>win32/win32.c (console_emulator_p, constat_handle): disable built-in<br>
console colorizing when console-emulator-like DLL is injected.<br>
[Feature <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Turn off builded colorizing (Closed)" href="https://redmine.ruby-lang.org/issues/8201">#8201</a>]</li>
</ul> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=436682013-12-14T16:19:47ZVersum (Denis Zinin)denis.zinin@gmail.com
<ul></ul><p>Good Day!</p>
<p>Which version of ruby have resolved issue?</p>
<p>2.0.0-p353 still have problem.</p> Ruby master - Feature #8201: Turn off builded colorizinghttps://redmine.ruby-lang.org/issues/8201?journal_id=436972013-12-16T13:55:14Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul></ul><p>Trunk.</p>
<p>These commits (and r43307, r43331) haven't been backported yet.</p>