https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112013-03-24T22:47:04ZRuby Issue Tracking SystemRuby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=378772013-03-24T22:47:04Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul></ul><p>Same for ruby_2_0_0 branch</p>
<p><a href="https://github.com/funny-falcon/ruby/compare/ruby_2_0_0...features_index/ruby_2_0_0.diff" class="external">https://github.com/funny-falcon/ruby/compare/ruby_2_0_0...features_index/ruby_2_0_0.diff</a><br>
<a href="https://github.com/funny-falcon/ruby/compare/ruby_2_0_0...features_index/ruby_2_0_0" class="external">https://github.com/funny-falcon/ruby/compare/ruby_2_0_0...features_index/ruby_2_0_0</a></p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=382472013-04-05T11:43:06Zzzak (zzak _)
<ul><li><strong>File</strong> <i>264.patch</i> added</li><li><strong>Category</strong> set to <i>core</i></li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=421372013-10-01T16:58:50Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>nobu (Nobuyoshi Nakada)</i></li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=447682014-01-30T06:16:51Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul><li><strong>Target version</strong> changed from <i>2.1.0</i> to <i>2.2.0</i></li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=607782016-10-07T13:20:10Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul><li><strong>File</strong> <i>0001-load.c-reduce-memory-usage-of-loaded_features_index.patch</i> added</li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=607792016-10-07T13:24:46Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul></ul><p>I've changed implementation a bit:<br>
Because <a href="https://bugs.ruby-lang.org/issues/12142" class="external">https://bugs.ruby-lang.org/issues/12142</a> likely to be accepted,<br>
I've used st_table with numtable instead of separate datastructure.</p>
<p>So patch now is shorter.<br>
<a href="https://bugs.ruby-lang.org/attachments/download/6182/0001-load.c-reduce-memory-usage-of-loaded_features_index.patch" class="external">https://bugs.ruby-lang.org/attachments/download/6182/0001-load.c-reduce-memory-usage-of-loaded_features_index.patch</a></p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619792016-12-12T06:09:34Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:funny.falcon@gmail.com" class="email">funny.falcon@gmail.com</a> wrote:</p>
<blockquote>
<p>So patch now is shorter.<br>
<a href="https://bugs.ruby-lang.org/attachments/download/6182/0001-load.c-reduce-memory-usage-of-loaded_features_index.patch" class="external">https://bugs.ruby-lang.org/attachments/download/6182/0001-load.c-reduce-memory-usage-of-loaded_features_index.patch</a></p>
</blockquote>
<p>Thanks; this got broken by trivial whitespace change in r57032</p>
<p>I'm not sure about the portability of initializing structs<br>
with non-const values for some compilers. Maybe usa or<br>
somebody with more portability experience can comment.</p>
<p>Also, in C Ruby; initial indent is 4 spaces, second indent is<br>
hard tab. Not my rule and I hate it; but not much we can do...</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619802016-12-12T06:41:06Zusa (Usaku NAKAMURA)usa@garbagecollect.jp
<ul></ul><p>Hi,</p>
<p>In message "<a href="/issues/8158">[ruby-core:78595]</a> Re: [Ruby trunk Feature#8158] lightweight structure for loaded features index"<br>
on Mon, 12 Dec 2016 06:06:13 +0000, <a href="mailto:normalperson@yhbt.net" class="email">normalperson@yhbt.net</a> wrote:</p>
<blockquote>
<p>I'm not sure about the portability of initializing structs<br>
with non-const values for some compilers. Maybe usa or<br>
somebody with more portability experience can comment.</p>
</blockquote>
<p>It's OK, at least for VC++.</p>
<a name="Regards"></a>
<h2 >Regards,<a href="#Regards" class="wiki-anchor">¶</a></h2>
<p>U.Nakamaura <a href="mailto:usa@garbagecollect.jp" class="email">usa@garbagecollect.jp</a></p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619822016-12-12T07:20:38Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul></ul><p>Usaku NAKAMURA wrote:</p>
<blockquote>
<p>In message "<a href="/issues/8158">[ruby-core:78595]</a> Re: [Ruby trunk Feature#8158] lightweight structure for loaded features index"<br>
on Mon, 12 Dec 2016 06:06:13 +0000, <a href="mailto:normalperson@yhbt.net" class="email">normalperson@yhbt.net</a> wrote:</p>
<blockquote>
<p>I'm not sure about the portability of initializing structs<br>
with non-const values for some compilers. Maybe usa or<br>
somebody with more portability experience can comment.</p>
</blockquote>
<p>It's OK, at least for VC++.</p>
</blockquote>
<p>Other compilers fail, IIRC, Solaris, AIX, HP-UX, or something.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619832016-12-12T08:05:04Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul></ul><p>I'll fix patch today.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619842016-12-12T10:39:12Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul><li><strong>File</strong> deleted (<del><i>264.patch</i></del>)</li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619852016-12-12T10:39:16Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul><li><strong>File</strong> deleted (<del><i>0001-load.c-reduce-memory-usage-of-loaded_features_index.patch</i></del>)</li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619862016-12-12T10:39:44Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/6293">0001-load.c-reduce-memory-usage-of-loaded_features_index.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6293/0001-load.c-reduce-memory-usage-of-loaded_features_index.patch">0001-load.c-reduce-memory-usage-of-loaded_features_index.patch</a> added</li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619872016-12-12T10:44:06Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul></ul><p>I've uploaded fixed patch:<br>
<a href="https://bugs.ruby-lang.org/attachments/download/6293/0001-load.c-reduce-memory-usage-of-loaded_features_index.patch" class="external">https://bugs.ruby-lang.org/attachments/download/6293/0001-load.c-reduce-memory-usage-of-loaded_features_index.patch</a></p>
<p>Github branch and diff:<br>
<a href="https://github.com/funny-falcon/ruby/tree/loaded_features_strings" class="external">https://github.com/funny-falcon/ruby/tree/loaded_features_strings</a><br>
<a href="https://github.com/ruby/ruby/compare/trunk...funny-falcon:loaded_features_strings.patch" class="external">https://github.com/ruby/ruby/compare/trunk...funny-falcon:loaded_features_strings.patch</a></p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619892016-12-12T11:22:17Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul><li><strong>File</strong> <i>load.c-loaded_features_numindex.patch</i> added</li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619902016-12-12T11:23:58Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul><li><strong>File</strong> deleted (<del><i>load.c-loaded_features_numindex.patch</i></del>)</li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619912016-12-12T11:24:36Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/6295">load.c-loaded_features_numindex.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6295/load.c-loaded_features_numindex.patch">load.c-loaded_features_numindex.patch</a> added</li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=619922016-12-12T11:30:08Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul></ul><p>I've tried to simplify patch: remove <code>struct feature_str</code> and use just pointer with len.</p>
<p><a href="https://bugs.ruby-lang.org/attachments/download/6295/load.c-loaded_features_numindex.patch" class="external">https://bugs.ruby-lang.org/attachments/download/6295/load.c-loaded_features_numindex.patch</a></p>
<p><a href="https://github.com/ruby/ruby/compare/trunk...funny-falcon:loaded_features_index.patch" class="external">https://github.com/ruby/ruby/compare/trunk...funny-falcon:loaded_features_index.patch</a><br>
<a href="https://github.com/funny-falcon/ruby/tree/loaded_features_index" class="external">https://github.com/funny-falcon/ruby/tree/loaded_features_index</a></p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=621822016-12-21T14:25:50Zshyouhei (Shyouhei Urabe)shyouhei@ruby-lang.org
<ul></ul><p>We looked at this issue at today's developer meeting and had positive opinions. Maybe introduced in 2.5.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=625472017-01-19T05:48:35Zmatz (Yukihiro Matsumoto)matz@ruby.or.jp
<ul></ul><p>The patch seems OK now. <a class="user active user-mention" href="https://redmine.ruby-lang.org/users/155">@funny_falcon (Yura Sokolov)</a> do you want to check in by yourself?</p>
<p>Matz.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=625822017-01-19T11:11:37Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul></ul><p>Matz,</p>
<p>I don't know English enough to clearly understand your suggestion.</p>
<p>Is it suggestion of commit rights?<br>
If it is, it will be a great honor for me.<br>
But I'm not even-tempered person, and I fear I will put a mess into repository if I will have commit rights.</p>
<p>If your suggestion means some-thing else, then may you formulate it in some other words so I can understand?</p>
<p>With regards,<br>
Yura.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=703182018-02-13T21:39:13Zsam.saffron (Sam Saffron)sam.saffron@gmail.com
<ul></ul><p>Hi Yura,</p>
<p>I think the commit rights here reduce the amount of work for the rest of the Ruby team.</p>
<p>This change is approved and reviewed, so you can commit it directly once you have the rights, no need to make other people do the committing.</p>
<p>Very keen to have this change included in Ruby.</p>
<p>Sam</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=703322018-02-14T04:56:12Zduerst (Martin Dürst)duerst@it.aoyama.ac.jp
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/14460">Feature #14460</a>: Speed up `require` and reduce memory usage</i> added</li></ul> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=703372018-02-14T10:53:35Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul></ul><p>Year after I think I am more stable person, so I'm going to accept commit rights with gratitude, honor and great responsibility.</p>
<p>But until I passed procedure, I'd be thankful if <a class="user active user-mention" href="https://redmine.ruby-lang.org/users/73">@tenderlovemaking (Aaron Patterson)</a> will commit this one.</p>
<p>With regards,<br>
Yura.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=703472018-02-14T18:39:21Ztenderlovemaking (Aaron Patterson)tenderlove@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul><p>Committed in r62404. Thanks Yura!!</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=703842018-02-15T20:12:58Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><blockquote>
<p><a href="https://bugs.ruby-lang.org/issues/8158" class="external">https://bugs.ruby-lang.org/issues/8158</a></p>
</blockquote>
<p>I am curious, what is the significance of the 0xfea7009e<br>
initializer passed to st_hash?</p>
<p>Would it be appropriate to use for the `st_hash' call in<br>
hash.c::hash_i as well?</p>
<p>Thanks.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=704652018-02-20T06:34:42Zmatz (Yukihiro Matsumoto)matz@ruby.or.jp
<ul></ul><p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/155">@funny_falcon (Yura Sokolov)</a>? Will you be a committer?</p>
<p>Matz.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=704942018-02-20T10:40:44Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul></ul><p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/13">@matz (Yukihiro Matsumoto)</a> , yes I will.<br>
Excuse me for the delay. I'll try to proceed with steps from CommitterHowto this week.</p>
<p>With regards,<br>
Yura.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=704952018-02-20T10:49:33Zfunny_falcon (Yura Sokolov)funny.falcon@gmail.com
<ul></ul><p>normalperson (Eric Wong) wrote:</p>
<blockquote>
<blockquote>
<p><a href="https://bugs.ruby-lang.org/issues/8158" class="external">https://bugs.ruby-lang.org/issues/8158</a></p>
</blockquote>
<p>I am curious, what is the significance of the 0xfea7009e<br>
initializer passed to st_hash?</p>
</blockquote>
<p>0xfea7009e - is a "feature" hex-spelled :-) Nothing special.<br>
It could be ommitted, given features are strings without zero bytes.<br>
I put it here just for fun.</p>
<blockquote>
<p>Would it be appropriate to use for the `st_hash' call in<br>
hash.c::hash_i as well?</p>
</blockquote>
<p>I believe, there's no real needs.</p>
<blockquote>
<p>Thanks.</p>
</blockquote>
<p>With regards,<br>
Yura.</p> Ruby master - Feature #8158: lightweight structure for loaded features indexhttps://redmine.ruby-lang.org/issues/8158?journal_id=706212018-02-23T12:58:42Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul></ul><p>Hi all.</p>
<p>I did create an account of funny_falcon on svn.ruby-lang.org.</p>