Project

General

Profile

Actions

Backport #7912

closed

Backport fix for test suite not honoring configuration options

Added by vo.x (Vit Ondruch) about 11 years ago. Updated about 11 years ago.


Description

Please backport fixes for issue #7902 fixed by r39372 and r39383

Updated by mame (Yusuke Endoh) about 11 years ago

  • Status changed from Open to Assigned
  • Assignee set to nobu (Nobuyoshi Nakada)

I'm not very keen on this backport because it looks non-showstopper, but I leave it up to nobu.

Nobu, please backport it if you think it is appropriate. Thank you in advance.

--
Yusuke Endoh

Updated by vo.x (Vit Ondruch) about 11 years ago

The test suite should be green prior release IMO and although it might pass in Ruby's CI, the build fails for my configuration. I can carry patches to fix this issue or disable this particular test, but is is just matter of time prior this will hit somebody else.

Anyway, I already disabled the test for Fedora [1], so it is just matter of (not)having 4 lines in .spec file.

[1] http://pkgs.fedoraproject.org/cgit/ruby.git/tree/ruby.spec#n571

Actions #3

Updated by nagachika (Tomoyuki Chikanaga) about 11 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39661.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39372,39383: [Backport #7912]

* test/test_rbconfig.rb (TestRbConfig): skip user defined values by
  configuration options.  [Bug #7902]

* test/test_rbconfig.rb (TestRbConfig): fix r39372.
  It must see RbConfig::CONFIG instead of CONFIG.
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0