https://redmine.ruby-lang.org/
https://redmine.ruby-lang.org/favicon.ico?1711330511
2012-11-25T10:42:05Z
Ruby Issue Tracking System
Ruby master - Bug #7373: FileUtils#chmod verbose gives error when mode is string
https://redmine.ruby-lang.org/issues/7373?journal_id=33835
2012-11-25T10:42:05Z
mame (Yusuke Endoh)
mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>mame (Yusuke Endoh)</i></li><li><strong>Target version</strong> set to <i>2.0.0</i></li></ul><p>Thank you.<br>
I'll apply the following patch unless there is objection.</p>
<p>diff --git a/lib/fileutils.rb b/lib/fileutils.rb<br>
index af2d19a..57ab0cf 100644<br>
--- a/lib/fileutils.rb<br>
+++ b/lib/fileutils.rb<br>
@@ -996,6 +996,10 @@ private<br>
mode.is_a?(String) ? symbolic_modes_to_i(mode, path) : mode<br>
end</p>
<ul>
<li>def mode_to_s(mode) #:nodoc:</li>
<li>mode.is_a?(String) ? mode : "%o" % mode</li>
<li>end</li>
<li>
</ul>
<p>public</p>
<h1></h1>
<p>@@ -1034,7 +1038,7 @@ public<br>
def chmod(mode, list, options = {})<br>
fu_check_options options, OPT_TABLE['chmod']<br>
list = fu_list(list)</p>
<ul>
<li>fu_output_message sprintf('chmod %o %s', mode, list.join(' ')) if options[:verbose]</li>
</ul>
<ul>
<li>fu_output_message sprintf('chmod %s %s', mode_to_s(mode), list.join(' ')) if options[:verbose]<br>
return if options[:noop]<br>
list.each do |path|<br>
Entry_.new(path).chmod(fu_mode(mode, path))<br>
@@ -1055,9 +1059,9 @@ public<br>
def chmod_R(mode, list, options = {})<br>
fu_check_options options, OPT_TABLE['chmod_R']<br>
list = fu_list(list)</li>
</ul>
<ul>
<li>fu_output_message sprintf('chmod -R%s %o %s',</li>
</ul>
<ul>
<li>fu_output_message sprintf('chmod -R%s %s %s',<br>
(options[:force] ? 'f' : ''),</li>
</ul>
<ul>
<li>
<pre><code> mode, list.join(' ')) if options[:verbose]
</code></pre>
</li>
</ul>
<ul>
<li>
<pre><code> mode_to_s(mode), list.join(' ')) if options[:verbose]
</code></pre>
return if options[:noop]<br>
list.each do |root|<br>
Entry_.new(root).traverse do |ent|</li>
</ul>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a></p>
Ruby master - Bug #7373: FileUtils#chmod verbose gives error when mode is string
https://redmine.ruby-lang.org/issues/7373?journal_id=35776
2013-02-02T12:57:19Z
mame (Yusuke Endoh)
mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul><p>Applied at r39011.</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a></p>