https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112012-11-03T21:02:19ZRuby Issue Tracking SystemRuby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=322932012-11-03T21:02:19Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li></ul><p>xibbar, are you willing to include this in 2.0.0?<br>
If so, please commit it ASAP, before preview2 (planned at 1 Dec.) at the latest.</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a></p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323132012-11-04T07:10:24Zzzak (zzak _)
<ul></ul><p>I think CGI#header should stay the same, and this method to product html5 compatible headers should be CGI#html_header</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323182012-11-04T09:50:40Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>I recommend xibber to postpone this to next minor, if there is room to discuss anything about the spec of this feature (such as a method name).</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a></p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323192012-11-04T09:51:42Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>Sorry, xibber -> xibbar.</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323342012-11-04T17:17:13Zstomar (Marcus Stollsteimer)
<ul></ul><p>I really think for the proposed patch 2.0 would be the best place.</p>
<p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/1677">@zzak (zzak _)</a>:</p>
<p>I can not judge how big the impact of renaming CGI#header would be.</p>
<p>BUT: Your proposal would mean that the tag would have to be treated differently to all the other HTML tags (#h1, #form, #br, ...), which for the users of the tag maker would be a fairly unexpected behaviour. </p>
<p>Personally, I would prefer consistent behaviour for all tags.</p>
<p>In case the decision goes with introducing a special method for this single tag, I would suggest #header_element (maybe #header_tag) instead of #html_header, which to me rather signifies the doctype, html meta data, etc.</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323352012-11-04T19:24:38Zxibbar (Takeyuki FUJIOKA)xibbar@gmail.com
<ul></ul><p>I think this function should be included in 2.0.0</p>
<p>So, I will commit.</p>
<p>Sorry late.</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323382012-11-04T20:48:07Zxibbar (Takeyuki FUJIOKA)xibbar@gmail.com
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r37466.<br>
Marcus, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<p>Sun Nov 4 20:41:28 2012 Takeyuki FUJIOKA <a href="mailto:xibbar@ruby-lang.org" class="email">xibbar@ruby-lang.org</a></p>
<ul>
<li>lib/cgi.rb, lib/cgi/*/rb: rename CGI#header to<br>
CGI#http_header,<br>
add and update HTML5 tag generater. [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: CGI: Add support for HTML5 <header> tag (Closed)" href="https://redmine.ruby-lang.org/issues/7110">#7110</a>]<br>
Patch provided by Marcus Stollsteimer, thank you !</li>
</ul> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323412012-11-04T23:15:42Zstomar (Marcus Stollsteimer)
<ul></ul><p>Perhaps a note should be added to NEWS, maybe something like</p>
<ul>
<li>cgi
<ul>
<li>incompatible changes:
<ul>
<li>CGI#header has been renamed to CGI#http_header.<br>
CGI#header is now used by the HTML5 tag maker to<br>
create a element. </li>
</ul>
</li>
</ul>
</li>
</ul> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323442012-11-05T04:13:47Zzzak (zzak _)
<ul></ul><p>In my opinion compatibility is more important than consistency, but<br>
ultimately it is up to xibbar.</p>
<p>Other ruby-core share this sentiment, see ruby-core:48469</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323452012-11-05T04:23:17Zzzak (zzak _)
<ul></ul><p>In my opinion compatibility is more important than consistency, but<br>
ultimately it is up to xibbar.</p>
<p>Other ruby-core share this sentiment, see ruby-core:48469</p>
<p>On Sun, Nov 4, 2012 at 9:15 AM, stomar (Marcus Stollsteimer)<br>
<a href="mailto:redmine@ruby-lang.org" class="email">redmine@ruby-lang.org</a> wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: CGI: Add support for HTML5 <header> tag (Closed)" href="https://redmine.ruby-lang.org/issues/7110">#7110</a> has been updated by stomar (Marcus Stollsteimer).</p>
<p>Perhaps a note should be added to NEWS, maybe something like</p>
<ul>
<li>cgi
<ul>
<li>incompatible changes:
<ul>
<li>CGI#header has been renamed to CGI#http_header.<br>
CGI#header is now used by the HTML5 tag maker to<br>
create a element. </li>
</ul>
</li>
</ul>
</li>
</ul>
<hr>
<p>Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: CGI: Add support for HTML5 <header> tag (Closed)" href="https://redmine.ruby-lang.org/issues/7110">#7110</a>: CGI: Add support for HTML5 tag<br>
<a href="https://bugs.ruby-lang.org/issues/7110#change-32341" class="external">https://bugs.ruby-lang.org/issues/7110#change-32341</a> </p>
<p>Author: stomar (Marcus Stollsteimer)<br>
Status: Closed<br>
Priority: Normal<br>
Assignee: xibbar (Takeyuki Fujioka)<br>
Category: lib<br>
Target version: 2.0.0<br>
ruby -v: ruby 2.0.0dev (2012-09-28 trunk 37049) [i686-linux]</p>
<p>=begin<br>
These patches add the tag to CGI's HTML generation methods, finalizing the support of HTML5, see <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add HTML5 support to CGI (Closed)" href="https://redmine.ruby-lang.org/issues/6637">#6637</a>. </p>
<p>Note that the old CGI#header method is renamed to CGI#http_header. CGI#header now generates a HTML5 header element.<br>
=end</p>
<p>--<br>
<a href="http://bugs.ruby-lang.org/" class="external">http://bugs.ruby-lang.org/</a></p>
</blockquote> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323462012-11-05T05:12:38Zstomar (Marcus Stollsteimer)
<ul></ul><blockquote>
<p>In my opinion compatibility is more important than consistency, but<br>
ultimately it is up to xibbar.</p>
<p>Other ruby-core share this sentiment, see ruby-core:48469</p>
</blockquote>
<p>I don't think a general rule can be derived from this single statement. Also, the circumstances are different. Here, it is more a question of avoiding inconsistent and unexpected behaviour than of adding some "would be nice to have" method.</p>
<p>(BTW, I prepared a slide for the developer meeting (7/21), see <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add HTML5 support to CGI (Closed)" href="https://redmine.ruby-lang.org/issues/6637">#6637</a>, and apparently there haven't been objections, though I made sure to point out the incompatibility issue.)</p>
<p>But don't understand me wrong, I'm all for compatibility.</p>
<p>Maybe a point that would have to be considered is whether this change can be regarded as a mostly internal change of a method that is usually not called directly by the average user of the library, or not.</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323482012-11-05T09:29:17Zxibbar (Takeyuki FUJIOKA)xibbar@gmail.com
<ul></ul><p>stomar (Marcus Stollsteimer) wrote:</p>
<blockquote>
<p>Perhaps a note should be added to NEWS, maybe something like</p>
<ul>
<li>cgi
<ul>
<li>incompatible changes:
<ul>
<li>CGI#header has been renamed to CGI#http_header.<br>
CGI#header is now used by the HTML5 tag maker to<br>
create a element. </li>
</ul>
</li>
</ul>
</li>
</ul>
</blockquote>
<p>Thank you. I will add.</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323492012-11-05T09:33:22Zxibbar (Takeyuki FUJIOKA)xibbar@gmail.com
<ul></ul><p>I decide this change.<br>
Because minor version up is is more important than consistency.<br>
But 2.0 is major version up.<br>
HTML5 will be gradually standard format.</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=323522012-11-05T10:10:39Zzzak (zzak _)
<ul></ul><p>xibbar, it is your decision to make, and I support it.</p>
<p>Thank you.</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=324952012-11-06T21:12:57Zxibbar (Takeyuki FUJIOKA)xibbar@gmail.com
<ul></ul><p>Curretly, some japanese programmer talk about compatibility. <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: CGI#header が 1.9.3 と異なる挙動となっている (Closed)" href="https://redmine.ruby-lang.org/issues/7286">#7286</a><br>
Many traditional web applications use cgi.rb .<br>
This change give a impact to these applications.<br>
Some committer said that cgi.rb 's importance is traditional code can run.<br>
I agee them.</p>
<p>If you have better idea, please write here or <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: CGI#header が 1.9.3 と異なる挙動となっている (Closed)" href="https://redmine.ruby-lang.org/issues/7286">#7286</a>.</p>
<p>We are discussing in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: CGI#header が 1.9.3 と異なる挙動となっている (Closed)" href="https://redmine.ruby-lang.org/issues/7286">#7286</a> .</p> Ruby master - Bug #7110: CGI: Add support for HTML5 <header> taghttps://redmine.ruby-lang.org/issues/7110?journal_id=324962012-11-06T21:31:43Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>Let me complement. xibbar suggested three options:</p>
<ol>
<li>Just delete the old header method (current)</li>
<li>Change CGI#header only before HTML4 mode</li>
<li>Change CGI#header only in HTML5 mode</li>
</ol>
<p>(I don't know any merit of (2), I guess it is typo)</p>
<p>We are mainly considering (3).</p>
<p>puts CGI.new .header #=> "Content-Type: text/html" + deprecated warning<br>
puts CGI.new("html4").header #=> "Content-Type: text/html" + deprecated warning<br>
puts CGI.new("html5").header #=> " "</p>
<p>Knu suggested more delicate way:</p>
<ul>
<li>CGI#header should emit a tag when a block is given, and</li>
<li>CGI#header should emit a tag when it is called in a block of other tag-generating methods.</li>
</ul>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a></p>