https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112012-09-23T05:09:18ZRuby Issue Tracking SystemRuby master - Bug #7050: encoding of String#unpack for 'H', 'h', 'B' and 'b'https://redmine.ruby-lang.org/issues/7050?journal_id=296782012-09-23T05:09:18ZEregon (Benoit Daloze)
<ul></ul><p>I would of course also add Aaron's test for SecureRandom hexdigests if this is fine to be merged.</p> Ruby master - Bug #7050: encoding of String#unpack for 'H', 'h', 'B' and 'b'https://redmine.ruby-lang.org/issues/7050?journal_id=297252012-09-25T10:58:26Ztenderlovemaking (Aaron Patterson)tenderlove@ruby-lang.org
<ul></ul><p>I would really like this to be added! (Thank you for writing the patch)</p> Ruby master - Bug #7050: encoding of String#unpack for 'H', 'h', 'B' and 'b'https://redmine.ruby-lang.org/issues/7050?journal_id=309862012-10-18T07:33:16ZEregon (Benoit Daloze)
<ul></ul><p>Ping!</p>
<p>I would like to merge this.<br>
If there are no objections, may I merge this in a week?</p> Ruby master - Bug #7050: encoding of String#unpack for 'H', 'h', 'B' and 'b'https://redmine.ruby-lang.org/issues/7050?journal_id=310432012-10-19T14:47:42Znaruse (Yui NARUSE)naruse@airemix.jp
<ul></ul><p>Eregon (Benoit Daloze) wrote:</p>
<blockquote>
<p>Ping!</p>
<p>I would like to merge this.<br>
If there are no objections, may I merge this in a week?</p>
</blockquote>
<p>OK, here you go</p> Ruby master - Bug #7050: encoding of String#unpack for 'H', 'h', 'B' and 'b'https://redmine.ruby-lang.org/issues/7050?journal_id=310992012-10-19T22:13:38ZEregon (Benoit Daloze)
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r37269.<br>
Benoit, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<p>set encoding to ASCII for appropriate String#unpack modifiers</p>
<ul>
<li>pack.c (pack_unpack): set encoding of the<br>
'H','h','B' and 'B' modifiers to US-ASCII.</li>
<li>test/ruby/test_pack.rb: tests for the above.<br>
<a href="/issues/7050">[ruby-core:47653]</a>[Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: encoding of String#unpack for 'H', 'h', 'B' and 'b' (Closed)" href="https://redmine.ruby-lang.org/issues/7050">#7050</a>]</li>
<li>test/test_securerandom.rb: tests for SecureRandom.hex<br>
from tenderlove. <a href="/issues/6799">[ruby-core:46792]</a>[Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Digest::*.hexdigest returns an ASCII-8BIT String (Closed)" href="https://redmine.ruby-lang.org/issues/6799">#6799</a>]</li>
</ul> Ruby master - Bug #7050: encoding of String#unpack for 'H', 'h', 'B' and 'b'https://redmine.ruby-lang.org/issues/7050?journal_id=311022012-10-19T22:53:20ZEregon (Benoit Daloze)
<ul></ul><p>On 19 October 2012 07:47, naruse (Yui NARUSE) <a href="mailto:naruse@airemix.jp" class="email">naruse@airemix.jp</a> wrote:</p>
<blockquote>
<p>Eregon (Benoit Daloze) wrote:</p>
<blockquote>
<p>Ping!</p>
<p>I would like to merge this.<br>
If there are no objections, may I merge this in a week?</p>
</blockquote>
<p>OK, here you go</p>
</blockquote>
<p>Thank you!</p>