https://redmine.ruby-lang.org/
https://redmine.ruby-lang.org/favicon.ico?1711330511
2012-05-25T08:22:05Z
Ruby Issue Tracking System
Ruby master - Feature #6494: Send Accept-Encoding for all HTTP requests
https://redmine.ruby-lang.org/issues/6494?journal_id=26807
2012-05-25T08:22:05Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul><li><strong>File</strong> <a href="/attachments/2717">net.http.accept_gzip_deflate_by_default.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2717/net.http.accept_gzip_deflate_by_default.patch">net.http.accept_gzip_deflate_by_default.patch</a> added</li></ul><p>Oops, forgot patch.</p>
Ruby master - Feature #6494: Send Accept-Encoding for all HTTP requests
https://redmine.ruby-lang.org/issues/6494?journal_id=26878
2012-05-28T20:34:25Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul></ul><p>This change breaks code which calls initialize with initheader=nil.</p>
<ul>
<li>def initialize(m, reqbody, resbody, path, initheader = nil)</li>
</ul>
<ul>
<li>def initialize(m, reqbody, resbody, path, initheader = {})</li>
</ul>
<p>Following</p>
<ul>
<li>if @response_has_body and Net::HTTP::HAVE_ZLIB then</li>
<li>
<pre><code> unless initheader.keys.any? { |k| k.downcase == "accept-encoding" }
</code></pre>
</li>
<li>
<pre><code> initheader = initheader.merge({
</code></pre>
</li>
<li>
<pre><code> "accept-encoding" => "gzip;q=1.0,deflate;q=0.6,identity;q=0.3"
</code></pre>
</li>
<li>
<pre><code> })
</code></pre>
</li>
<li>
<pre><code> end
</code></pre>
</li>
<li>end</li>
</ul>
<p>should be</p>
<ul>
<li>
<pre><code> if !initheader || !initheader.keys.any? { |k| k.downcase == "accept-encoding" }
</code></pre>
</li>
<li>
<pre><code> initheader = initheader ? initheader.dup : {}
</code></pre>
</li>
<li>
<pre><code> initheader["accept-encoding"] = "gzip;q=1.0,deflate;q=0.6,identity;q=0.3"
</code></pre>
</li>
<li>
<pre><code> end
</code></pre>
</li>
</ul>
Ruby master - Feature #6494: Send Accept-Encoding for all HTTP requests
https://redmine.ruby-lang.org/issues/6494?journal_id=26896
2012-05-30T08:55:36Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul><li><strong>File</strong> <a href="/attachments/2731">net.http.accept_gzip_deflate_by_default.2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2731/net.http.accept_gzip_deflate_by_default.2.patch">net.http.accept_gzip_deflate_by_default.2.patch</a> added</li></ul><p>Why remove the HAVE_ZLIB and @response_has_body checks?</p>
<p>This updated patch incorporates your change to maintain backwards-compatibility but leaves in the HAVE_ZLIB and @response_has_body checks.</p>
Ruby master - Feature #6494: Send Accept-Encoding for all HTTP requests
https://redmine.ruby-lang.org/issues/6494?journal_id=26905
2012-05-30T21:49:06Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul></ul><p>drbrain (Eric Hodel) wrote:</p>
<blockquote>
<p>Why remove the HAVE_ZLIB and @response_has_body checks?</p>
</blockquote>
<p>Ah, I wrongly removed it, it is needed.</p>
<blockquote>
<p>This updated patch incorporates your change to maintain backwards-compatibility but leaves in the HAVE_ZLIB and @response_has_body checks.</p>
</blockquote>
<p>OK, you can commit it, thanks.</p>
Ruby master - Feature #6494: Send Accept-Encoding for all HTTP requests
https://redmine.ruby-lang.org/issues/6494?journal_id=26918
2012-05-31T23:11:09Z
mame (Yusuke Endoh)
mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>naruse (Yui NARUSE)</i></li></ul>
Ruby master - Feature #6494: Send Accept-Encoding for all HTTP requests
https://redmine.ruby-lang.org/issues/6494?journal_id=26952
2012-06-01T21:37:47Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul><li><strong>Assignee</strong> changed from <i>naruse (Yui NARUSE)</i> to <i>drbrain (Eric Hodel)</i></li></ul>
Ruby master - Feature #6494: Send Accept-Encoding for all HTTP requests
https://redmine.ruby-lang.org/issues/6494?journal_id=26968
2012-06-02T08:40:52Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul></ul><p>I will commit this once <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Inflate all HTTP Content-Encoding: deflate, gzip, x-gzip responses by default (Closed)" href="https://redmine.ruby-lang.org/issues/6492">#6492</a> is approved and committed.</p>
Ruby master - Feature #6494: Send Accept-Encoding for all HTTP requests
https://redmine.ruby-lang.org/issues/6494?journal_id=27108
2012-06-09T07:20:56Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul><li><strong>File</strong> <a href="/attachments/2773">net.http.accept_gzip_deflate_by_default.3.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2773/net.http.accept_gzip_deflate_by_default.3.patch">net.http.accept_gzip_deflate_by_default.3.patch</a> added</li></ul><p>Due to feedback from <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Inflate all HTTP Content-Encoding: deflate, gzip, x-gzip responses by default (Closed)" href="https://redmine.ruby-lang.org/issues/6492">#6492</a> I have updated this patch to omit Accept-Encoding when Range is supplied in initheader.</p>
<p>I've also added documentation to this patch to describe the new compression behavior.</p>
Ruby master - Feature #6494: Send Accept-Encoding for all HTTP requests
https://redmine.ruby-lang.org/issues/6494?journal_id=28215
2012-07-20T07:43:39Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r36473.<br>
Eric, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<ul>
<li>lib/net/http/response.rb: Automatically inflate gzip and<br>
deflate-encoded response bodies. [Feature #6942]</li>
<li>lib/net/http/generic_request.rb: Automatically accept gzip and<br>
deflate content-encoding for requests. [Feature <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Send Accept-Encoding for all HTTP requests (Closed)" href="https://redmine.ruby-lang.org/issues/6494">#6494</a>]</li>
<li>lib/net/http/request.rb: Updated documentation for <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Send Accept-Encoding for all HTTP requests (Closed)" href="https://redmine.ruby-lang.org/issues/6494">#6494</a>.</li>
<li>lib/net/http.rb: Updated documentation for <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Inflate all HTTP Content-Encoding: deflate, gzip, x-gzip responses by default (Closed)" href="https://redmine.ruby-lang.org/issues/6492">#6492</a> and <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Send Accept-Encoding for all HTTP requests (Closed)" href="https://redmine.ruby-lang.org/issues/6494">#6494</a>, removed<br>
Content-Encoding handling now present in Net::HTTPResponse.</li>
<li>test/net/http/test_httpresponse.rb: Tests for <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Inflate all HTTP Content-Encoding: deflate, gzip, x-gzip responses by default (Closed)" href="https://redmine.ruby-lang.org/issues/6492">#6492</a></li>
<li>test/net/http/test_http_request.rb: Tests for <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Send Accept-Encoding for all HTTP requests (Closed)" href="https://redmine.ruby-lang.org/issues/6494">#6494</a></li>
<li>test/open-uri/test_open-uri.rb (test_content_encoding): Updated test<br>
for automatic content-encoding handling.</li>
</ul>