https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112012-02-10T22:59:11ZRuby Issue Tracking SystemRuby master - Feature #5999: Optimize for faster loading time and win32/file.c refactoringhttps://redmine.ruby-lang.org/issues/5999?journal_id=236942012-02-10T22:59:11Zluislavena (Luis Lavena)luislavena@gmail.com
<ul><li><strong>Category</strong> set to <i>core</i></li><li><strong>Assignee</strong> set to <i>usa (Usaku NAKAMURA)</i></li><li><strong>Target version</strong> set to <i>2.0.0</i></li></ul> Ruby master - Feature #5999: Optimize for faster loading time and win32/file.c refactoringhttps://redmine.ruby-lang.org/issues/5999?journal_id=236952012-02-10T23:02:25Zluislavena (Luis Lavena)luislavena@gmail.com
<ul></ul><p>Usa,</p>
<p>Do you approve this be merged?</p>
<p>Thank you.</p> Ruby master - Feature #5999: Optimize for faster loading time and win32/file.c refactoringhttps://redmine.ruby-lang.org/issues/5999?journal_id=242022012-02-28T01:41:50Zjonforums (Jon Forums)
<ul></ul><p>As there's been no negative feedback in the past 17 days, is this patch acceptable as-is and can it now be committed to trunk?</p> Ruby master - Feature #5999: Optimize for faster loading time and win32/file.c refactoringhttps://redmine.ruby-lang.org/issues/5999?journal_id=242042012-02-28T01:57:49Zusa (Usaku NAKAMURA)usa@garbagecollect.jp
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> changed from <i>usa (Usaku NAKAMURA)</i> to <i>h.shirosaki (Hiroshi Shirosaki)</i></li></ul><p>I don't object.<br>
Shirosaki-san, please commit it.</p> Ruby master - Feature #5999: Optimize for faster loading time and win32/file.c refactoringhttps://redmine.ruby-lang.org/issues/5999?journal_id=242272012-02-29T00:51:27ZAnonymous
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r34849.<br>
Hiroshi, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<ul>
<li>
<p>Makefile.in (PLATFORM_DIR): add a variable for <code>win32</code> directory.</p>
</li>
<li>
<p>Makefile.in (clean-platform): add new target.<br>
It cleans <code>win32</code> directory.</p>
</li>
<li>
<p>common.mk (clean): add a dependency for <code>win32</code> directory.</p>
</li>
<li>
<p>common.mk (distclean): ditto.</p>
</li>
<li>
<p>common.mk (distclean-platform): add new target.<br>
It cleans <code>win32</code> directory.</p>
</li>
<li>
<p>common.mk ($(PLATFORM_D)): add new target to make <code>win32</code> directory.</p>
</li>
<li>
<p>common.mk (win32/win32.$(OBJEXT)): move win32.o into <code>win32</code><br>
directory.</p>
</li>
<li>
<p>common.mk (win32/file.$(OBJEXT)): add new target for win32/file.c.</p>
</li>
<li>
<p>configure.in: move win32.o into <code>win32</code> directory and add<br>
win32/file.o to MISSING.</p>
</li>
<li>
<p>file.c (file_load_ok, rb_file_load_ok): replace static<br>
file_load_ok() with public rb_file_load_ok().<br>
It's to link Windows implementation in win32/file.c.</p>
</li>
<li>
<p>file.c (rb_find_file_ext_safe): ditto.</p>
</li>
<li>
<p>file.c (rb_find_file_safe): ditto.</p>
</li>
<li>
<p>win32/file.c (rb_file_load_ok): new file. Add Windows specific<br>
optimized implementation of rb_file_load_ok(). We created a<br>
separated file to avoid too many #ifdef macro which is unreadable.</p>
</li>
<li>
<p>win32/Makefile.sub (PLATFORM_DIR): add a variable for <code>win32</code><br>
directory.</p>
</li>
<li>
<p>win32/Makefile.sub (MISSING): move win32.obj into <code>win32</code><br>
directory and add win32/file.obj to MISSING.</p>
</li>
<li>
<p>win32/Makefile.sub (MAKEDIRS): replace MINIRUBY with BASERUBY.<br>
It's because miniruby doesn't exist when making <code>win32</code> directory.</p>
</li>
<li>
<p>win32/Makefile.sub (clean-platform): add new target to clean <code>win32</code><br>
directory.</p>
</li>
<li>
<p>win32/Makefile.sub ({$(srcdir)}.c{}.obj): make it not match<br>
win32/file.c to build properly.</p>
</li>
<li>
<p>win32/Makefile.sub (win32/win32.$(OBJEXT)): move win32.obj into<br>
<code>win32</code> directory.</p>
<p>Patch created with Luis Lavena.<br>
<a href="/issues/5999">[ruby-core:42480]</a> [Feature <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Optimize for faster loading time and win32/file.c refactoring (Closed)" href="https://redmine.ruby-lang.org/issues/5999">#5999</a>]</p>
</li>
</ul> Ruby master - Feature #5999: Optimize for faster loading time and win32/file.c refactoringhttps://redmine.ruby-lang.org/issues/5999?journal_id=242282012-02-29T00:59:19Zh.shirosaki (Hiroshi Shirosaki)h.shirosaki@gmail.com
<ul></ul><blockquote>
<p>I don't object.<br>
Shirosaki-san, please commit it.</p>
</blockquote>
<p>Thank you. I committed it at r34849.</p>
<p>--<br>
Hiroshi Shirosaki</p>