https://redmine.ruby-lang.org/
https://redmine.ruby-lang.org/favicon.ico?1711330511
2011-11-27T16:23:31Z
Ruby Issue Tracking System
Ruby master - Bug #5675: [mingw] static build fails due to socket extension build failure
https://redmine.ruby-lang.org/issues/5675?journal_id=22439
2011-11-27T16:23:31Z
kosaki (Motohiro KOSAKI)
kosaki.motohiro@gmail.com
<ul><li><strong>ruby -v</strong> changed from <i>ruby 1.9.3p0 (2011-11-08 revision 33661) [i386-mingw32]</i> to <i>-</i></li></ul><blockquote>
<p>compiling ../../../ext/socket/socket.c<br>
../../../ext/socket/socket.c: In function 'rsock_sock_s_socketpair':<br>
../../../ext/socket/socket.c:114:5: warning: implicit declaration of function 'socketpair'</p>
</blockquote>
<p>This warning shouldn't be happen. But I'm wondering it because many<br>
people did success mingw32 build. Hmm..</p>
<p>Luis, do you have any opinion? (note: this is head of ruby_1_9_3 branch).</p>
Ruby master - Bug #5675: [mingw] static build fails due to socket extension build failure
https://redmine.ruby-lang.org/issues/5675?journal_id=22441
2011-11-27T18:44:26Z
phasis68 (Heesob Park)
phasis@gmail.com
<ul></ul><p>Configuring with --disable-shared option caused failure on mingw32 build.</p>
<p>As a workaround, inserting following 4 lines at line #12 of socket.c solves the problem.</p>
<p>#ifdef _WIN32<br>
#undef socketpair<br>
#define socketpair(a, t, p, s) rb_w32_socketpair(a, t, p, s)<br>
#endif</p>
Ruby master - Bug #5675: [mingw] static build fails due to socket extension build failure
https://redmine.ruby-lang.org/issues/5675?journal_id=22446
2011-11-27T23:53:08Z
luislavena (Luis Lavena)
luislavena@gmail.com
<ul></ul><p>On Sun, Nov 27, 2011 at 4:11 AM, KOSAKI Motohiro<br>
<a href="mailto:kosaki.motohiro@gmail.com" class="email">kosaki.motohiro@gmail.com</a> wrote:</p>
<blockquote>
<p>This warning shouldn't be happen. But I'm wondering it because many<br>
people did success mingw32 build. Hmm..</p>
</blockquote>
<p>Build with --enable-shared does work, but doesn't work when build with<br>
--disable-shared.</p>
<p>I think Heesob's patch does the trick, will test in a little bit.</p>
<h2>--<br>
Luis Lavena<br>
AREA 17</h2>
<p>Perfection in design is achieved not when there is nothing more to add,<br>
but rather when there is nothing more to take away.<br>
Antoine de Saint-Exupéry</p>
Ruby master - Bug #5675: [mingw] static build fails due to socket extension build failure
https://redmine.ruby-lang.org/issues/5675?journal_id=22447
2011-11-28T00:53:12Z
kosaki (Motohiro KOSAKI)
kosaki.motohiro@gmail.com
<ul></ul><p>2011/11/27 Luis Lavena <a href="mailto:luislavena@gmail.com" class="email">luislavena@gmail.com</a>:</p>
<blockquote>
<p>On Sun, Nov 27, 2011 at 4:11 AM, KOSAKI Motohiro<br>
<a href="mailto:kosaki.motohiro@gmail.com" class="email">kosaki.motohiro@gmail.com</a> wrote:</p>
<blockquote>
<p>This warning shouldn't be happen. But I'm wondering it because many<br>
people did success mingw32 build. Hmm..</p>
</blockquote>
<p>Build with --enable-shared does work, but doesn't work when build with<br>
--disable-shared.</p>
<p>I think Heesob's patch does the trick, will test in a little bit.</p>
</blockquote>
<p>Why doesn't socket.c include "ruby/win32.h"? I apologize if I ask<br>
dumb question.</p>
Ruby master - Bug #5675: [mingw] static build fails due to socket extension build failure
https://redmine.ruby-lang.org/issues/5675?journal_id=22448
2011-11-28T00:53:12Z
luislavena (Luis Lavena)
luislavena@gmail.com
<ul></ul><p>On Sun, Nov 27, 2011 at 12:41 PM, KOSAKI Motohiro<br>
<a href="mailto:kosaki.motohiro@gmail.com" class="email">kosaki.motohiro@gmail.com</a> wrote:</p>
<blockquote>
<p>Why doesn't socket.c include "ruby/win32.h"? Â I apologize if I ask<br>
dumb question.</p>
</blockquote>
<p>Not a dumb question, a very valid one...</p>
<p>ruby.h includes ruby/ruby.h<br>
ruby/ruby.h includes ruby/defines.h<br>
ruby/defines.h does include ruby/win32.h</p>
<p>socket.c is including rubysocket.h which includes ruby/ruby.h, so it<br>
should be resolving properly, right?</p>
<h2>--<br>
Luis Lavena<br>
AREA 17</h2>
<p>Perfection in design is achieved not when there is nothing more to add,<br>
but rather when there is nothing more to take away.<br>
Antoine de Saint-Exupéry</p>
Ruby master - Bug #5675: [mingw] static build fails due to socket extension build failure
https://redmine.ruby-lang.org/issues/5675?journal_id=22449
2011-11-28T01:53:17Z
kosaki (Motohiro KOSAKI)
kosaki.motohiro@gmail.com
<ul></ul><blockquote>
<blockquote>
<p>Why doesn't socket.c include "ruby/win32.h"? Â I apologize if I ask<br>
dumb question.</p>
</blockquote>
<p>Not a dumb question, a very valid one...</p>
<p>ruby.h includes ruby/ruby.h<br>
ruby/ruby.h includes ruby/defines.h<br>
ruby/defines.h does include ruby/win32.h</p>
<p>socket.c is including rubysocket.h which includes ruby/ruby.h, so it<br>
should be resolving properly, right?</p>
</blockquote>
<p>I thought so. But I can't think Jon told lie....</p>
Ruby master - Bug #5675: [mingw] static build fails due to socket extension build failure
https://redmine.ruby-lang.org/issues/5675?journal_id=22454
2011-11-28T10:36:11Z
nobu (Nobuyoshi Nakada)
nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r33876.<br>
Jon, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<ul>
<li>include/ruby/subst.h: moved Windows specific substitions from<br>
win32.h.</li>
<li>ext/socket/rubysocket.h: include ruby/subst.h. [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: [mingw] static build fails due to socket extension build failure (Closed)" href="https://redmine.ruby-lang.org/issues/5675">#5675</a>]</li>
</ul>