https://redmine.ruby-lang.org/
https://redmine.ruby-lang.org/favicon.ico?1711330511
2010-10-24T12:17:05Z
Ruby Issue Tracking System
Ruby master - Bug #3972: r28668 breaks test/unit when combined with the testing rake task
https://redmine.ruby-lang.org/issues/3972?journal_id=13879
2010-10-24T12:17:05Z
Anonymous
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>=begin<br>
This issue was solved with changeset r29577.<br>
Aaron, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<p>=end</p>
Ruby master - Bug #3972: r28668 breaks test/unit when combined with the testing rake task
https://redmine.ruby-lang.org/issues/3972?journal_id=15879
2011-02-18T04:25:38Z
tenderlovemaking (Aaron Patterson)
tenderlove@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Open</i></li><li><strong>ruby -v</strong> changed from <i>ruby 1.9.3dev (2010-10-18 trunk 29530) [x86_64-darwin10.4.0]</i> to <i>ruby 1.9.3dev (2011-02-18 trunk 30894) [x86_64-darwin10.6.0]</i></li></ul><p>=begin<br>
r30849 causes this bug again. Please revert r30849 or stop including <code>include Test::Unit::RequireFiles</code> in <code>class Runner</code>.<br>
=end</p>
Ruby master - Bug #3972: r28668 breaks test/unit when combined with the testing rake task
https://redmine.ruby-lang.org/issues/3972?journal_id=15889
2011-02-19T06:47:05Z
Anonymous
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>=begin<br>
This issue was solved with changeset r30913.<br>
Aaron, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<ul>
<li>lib/test/unit.rb: partial revert of r30849. <a href="/issues/3972">[ruby-core:32864]</a></li>
<li>test/testunit/test_rake_integration.rb: adding an integration test<br>
with the rake loader to prevent regressions.<br>
=end</li>
</ul>
Ruby master - Bug #3972: r28668 breaks test/unit when combined with the testing rake task
https://redmine.ruby-lang.org/issues/3972?journal_id=15926
2011-02-22T23:39:20Z
nagachika (Tomoyuki Chikanaga)
nagachika00@gmail.com
<ul></ul><p>=begin<br>
Hi,</p>
<p>After r30913, make test-all output warning and testunit message in test_rake_integration.rb like follows.</p>
<p>.../path/to/src/lib/test/unit.rb:43: warning: instance variable @options not initialized<br>
Run options:</p>
<a name="Running-tests"></a>
<h1 >Running tests:<a href="#Running-tests" class="wiki-anchor">¶</a></h1>
<p>Finished tests in 0.000475s, 0.0000 tests/s, 0.0000 assertions/s.</p>
<p>0 tests, 0 assertions, 0 failures, 0 errors, 0 skips<br>
.....</p>
<p>Aaron san, What do you think about the following patch? Is it OK to @options = nil in Options#initialize?</p>
<p>diff --git a/lib/test/unit.rb b/lib/test/unit.rb<br>
index 1272153..49c4e51 100644<br>
--- a/lib/test/unit.rb<br>
+++ b/lib/test/unit.rb<br>
@@ -32,6 +32,7 @@ module Test<br>
module Options<br>
def initialize(*, &block)<br>
@init_hook = block</p>
<ul>
<li>
<pre><code> @options = nil
super(&nil)
end
</code></pre>
</li>
</ul>
<p>diff --git a/test/testunit/test_rake_integration.rb b/test/testunit/test_rake_integration.rb<br>
index bb0951d..86a0cf8 100644<br>
--- a/test/testunit/test_rake_integration.rb<br>
+++ b/test/testunit/test_rake_integration.rb<br>
@@ -24,7 +24,12 @@ class FooTest; end<br>
eotest<br>
end</p>
<ul>
<li>
<pre><code> assert_ruby_status(%w{ -w } + [RAKE_LOADER, filename])
</code></pre>
</li>
</ul>
<ul>
<li>
<pre><code> args = %w{ -w } + [RAKE_LOADER, filename]
</code></pre>
</li>
<li>
<pre><code> bug3972 = "<a href="/issues/3972">[ruby-core:32864]</a>"
</code></pre>
</li>
<li>
<pre><code> status = assert_in_out_err(args, "",
</code></pre>
</li>
<li>
<pre><code> /0 tests, 0 assertions, 0 failures, 0 errors, 0 skips/,
</code></pre>
</li>
<li>
<pre><code> [], bug3972)
</code></pre>
</li>
<li>
<pre><code> assert_equal(true, status.success?, bug3972)
</code></pre>
end<br>
end<br>
end</li>
</ul>
<p>=end</p>
Ruby master - Bug #3972: r28668 breaks test/unit when combined with the testing rake task
https://redmine.ruby-lang.org/issues/3972?journal_id=15946
2011-02-24T05:23:06Z
tenderlovemaking (Aaron Patterson)
tenderlove@ruby-lang.org
<ul><li><strong>ruby -v</strong> changed from <i>ruby 1.9.3dev (2011-02-18 trunk 30894) [x86_64-darwin10.6.0]</i> to <i>-</i></li></ul><p>=begin<br>
On Tue, Feb 22, 2011 at 11:39:20PM +0900, Tomoyuki Chikanaga wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: r28668 breaks test/unit when combined with the testing rake task (Closed)" href="https://redmine.ruby-lang.org/issues/3972">#3972</a> has been updated by Tomoyuki Chikanaga.</p>
<p>Hi,</p>
<p>After r30913, make test-all output warning and testunit message in test_rake_integration.rb like follows.</p>
<p>.../path/to/src/lib/test/unit.rb:43: warning: instance variable @options not initialized<br>
Run options:</p>
<a name="Running-tests"></a>
<h1 >Running tests:<a href="#Running-tests" class="wiki-anchor">¶</a></h1>
<p>Finished tests in 0.000475s, 0.0000 tests/s, 0.0000 assertions/s.</p>
<p>0 tests, 0 assertions, 0 failures, 0 errors, 0 skips<br>
.....</p>
<p>Aaron san, What do you think about the following patch? Is it OK to @options = nil in Options#initialize?</p>
<p>diff --git a/lib/test/unit.rb b/lib/test/unit.rb<br>
index 1272153..49c4e51 100644<br>
--- a/lib/test/unit.rb<br>
+++ b/lib/test/unit.rb<br>
@@ -32,6 +32,7 @@ module Test<br>
module Options<br>
def initialize(*, &block)<br>
@init_hook = block</p>
<ul>
<li>
<pre><code> @options = nil
super(&nil)
end
</code></pre>
</li>
</ul>
<p>diff --git a/test/testunit/test_rake_integration.rb b/test/testunit/test_rake_integration.rb<br>
index bb0951d..86a0cf8 100644<br>
--- a/test/testunit/test_rake_integration.rb<br>
+++ b/test/testunit/test_rake_integration.rb<br>
@@ -24,7 +24,12 @@ class FooTest; end<br>
eotest<br>
end</p>
<ul>
<li>
<pre><code> assert_ruby_status(%w{ -w } + [RAKE_LOADER, filename])
</code></pre>
</li>
</ul>
<ul>
<li>
<pre><code> args = %w{ -w } + [RAKE_LOADER, filename]
</code></pre>
</li>
<li>
<pre><code> bug3972 = "<a href="/issues/3972">[ruby-core:32864]</a>"
</code></pre>
</li>
<li>
<pre><code> status = assert_in_out_err(args, "",
</code></pre>
</li>
<li>
<pre><code> /0 tests, 0 assertions, 0 failures, 0 errors, 0 skips/,
</code></pre>
</li>
<li>
<pre><code> [], bug3972)
</code></pre>
</li>
<li>
<pre><code> assert_equal(true, status.success?, bug3972)
</code></pre>
end<br>
end<br>
end</li>
</ul>
</blockquote>
<p>This patch seems good to me. This warning annoys me too so I'll apply<br>
the patch (if all tests pass). :-)</p>
<p>--<br>
Aaron Patterson<br>
<a href="http://tenderlovemaking.com/" class="external">http://tenderlovemaking.com/</a><br>
=end</p>
Ruby master - Bug #3972: r28668 breaks test/unit when combined with the testing rake task
https://redmine.ruby-lang.org/issues/3972?journal_id=15972
2011-02-28T23:42:21Z
nagachika (Tomoyuki Chikanaga)
nagachika00@gmail.com
<ul></ul><p>=begin<br>
Thank you for your reviewing. :)<br>
I'll check in it by myself after check test.<br>
=end</p>
Ruby master - Bug #3972: r28668 breaks test/unit when combined with the testing rake task
https://redmine.ruby-lang.org/issues/3972?journal_id=16371
2011-04-12T20:17:06Z
tenderlovemaking (Aaron Patterson)
tenderlove@ruby-lang.org
<ul></ul><p>=begin<br>
On Tue, Feb 22, 2011 at 11:39:20PM +0900, Tomoyuki Chikanaga wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: r28668 breaks test/unit when combined with the testing rake task (Closed)" href="https://redmine.ruby-lang.org/issues/3972">#3972</a> has been updated by Tomoyuki Chikanaga.</p>
<p>Hi,</p>
<p>After r30913, make test-all output warning and testunit message in test_rake_integration.rb like follows.</p>
<p>.../path/to/src/lib/test/unit.rb:43: warning: instance variable @options not initialized<br>
Run options:</p>
<a name="Running-tests"></a>
<h1 >Running tests:<a href="#Running-tests" class="wiki-anchor">¶</a></h1>
<p>Finished tests in 0.000475s, 0.0000 tests/s, 0.0000 assertions/s.</p>
<p>0 tests, 0 assertions, 0 failures, 0 errors, 0 skips<br>
.....</p>
<p>Aaron san, What do you think about the following patch? Is it OK to @options = nil in Options#initialize?</p>
<p>diff --git a/lib/test/unit.rb b/lib/test/unit.rb<br>
index 1272153..49c4e51 100644<br>
--- a/lib/test/unit.rb<br>
+++ b/lib/test/unit.rb<br>
@@ -32,6 +32,7 @@ module Test<br>
module Options<br>
def initialize(*, &block)<br>
@init_hook = block</p>
<ul>
<li>
<pre><code> @options = nil
super(&nil)
end
</code></pre>
</li>
</ul>
<p>diff --git a/test/testunit/test_rake_integration.rb b/test/testunit/test_rake_integration.rb<br>
index bb0951d..86a0cf8 100644<br>
--- a/test/testunit/test_rake_integration.rb<br>
+++ b/test/testunit/test_rake_integration.rb<br>
@@ -24,7 +24,12 @@ class FooTest; end<br>
eotest<br>
end</p>
<ul>
<li>
<pre><code> assert_ruby_status(%w{ -w } + [RAKE_LOADER, filename])
</code></pre>
</li>
</ul>
<ul>
<li>
<pre><code> args = %w{ -w } + [RAKE_LOADER, filename]
</code></pre>
</li>
<li>
<pre><code> bug3972 = "<a href="/issues/3972">[ruby-core:32864]</a>"
</code></pre>
</li>
<li>
<pre><code> status = assert_in_out_err(args, "",
</code></pre>
</li>
<li>
<pre><code> /0 tests, 0 assertions, 0 failures, 0 errors, 0 skips/,
</code></pre>
</li>
<li>
<pre><code> [], bug3972)
</code></pre>
</li>
<li>
<pre><code> assert_equal(true, status.success?, bug3972)
</code></pre>
end<br>
end<br>
end</li>
</ul>
</blockquote>
<p>This patch seems good to me. This warning annoys me too so I'll apply<br>
the patch (if all tests pass). :-)</p>
<p>--<br>
Aaron Patterson<br>
<a href="http://tenderlovemaking.com/" class="external">http://tenderlovemaking.com/</a><br>
=end</p>
Ruby master - Bug #3972: r28668 breaks test/unit when combined with the testing rake task
https://redmine.ruby-lang.org/issues/3972?journal_id=16420
2011-04-12T20:18:31Z
tenderlovemaking (Aaron Patterson)
tenderlove@ruby-lang.org
<ul></ul><p>=begin<br>
On Tue, Feb 22, 2011 at 11:39:20PM +0900, Tomoyuki Chikanaga wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: r28668 breaks test/unit when combined with the testing rake task (Closed)" href="https://redmine.ruby-lang.org/issues/3972">#3972</a> has been updated by Tomoyuki Chikanaga.</p>
<p>Hi,</p>
<p>After r30913, make test-all output warning and testunit message in test_rake_integration.rb like follows.</p>
<p>.../path/to/src/lib/test/unit.rb:43: warning: instance variable @options not initialized<br>
Run options:</p>
<a name="Running-tests"></a>
<h1 >Running tests:<a href="#Running-tests" class="wiki-anchor">¶</a></h1>
<p>Finished tests in 0.000475s, 0.0000 tests/s, 0.0000 assertions/s.</p>
<p>0 tests, 0 assertions, 0 failures, 0 errors, 0 skips<br>
.....</p>
<p>Aaron san, What do you think about the following patch? Is it OK to @options = nil in Options#initialize?</p>
<p>diff --git a/lib/test/unit.rb b/lib/test/unit.rb<br>
index 1272153..49c4e51 100644<br>
--- a/lib/test/unit.rb<br>
+++ b/lib/test/unit.rb<br>
@@ -32,6 +32,7 @@ module Test<br>
module Options<br>
def initialize(*, &block)<br>
@init_hook = block</p>
<ul>
<li>
<pre><code> @options = nil
super(&nil)
end
</code></pre>
</li>
</ul>
<p>diff --git a/test/testunit/test_rake_integration.rb b/test/testunit/test_rake_integration.rb<br>
index bb0951d..86a0cf8 100644<br>
--- a/test/testunit/test_rake_integration.rb<br>
+++ b/test/testunit/test_rake_integration.rb<br>
@@ -24,7 +24,12 @@ class FooTest; end<br>
eotest<br>
end</p>
<ul>
<li>
<pre><code> assert_ruby_status(%w{ -w } + [RAKE_LOADER, filename])
</code></pre>
</li>
</ul>
<ul>
<li>
<pre><code> args = %w{ -w } + [RAKE_LOADER, filename]
</code></pre>
</li>
<li>
<pre><code> bug3972 = "<a href="/issues/3972">[ruby-core:32864]</a>"
</code></pre>
</li>
<li>
<pre><code> status = assert_in_out_err(args, "",
</code></pre>
</li>
<li>
<pre><code> /0 tests, 0 assertions, 0 failures, 0 errors, 0 skips/,
</code></pre>
</li>
<li>
<pre><code> [], bug3972)
</code></pre>
</li>
<li>
<pre><code> assert_equal(true, status.success?, bug3972)
</code></pre>
end<br>
end<br>
end</li>
</ul>
</blockquote>
<p>This patch seems good to me. This warning annoys me too so I'll apply<br>
the patch (if all tests pass). :-)</p>
<p>--<br>
Aaron Patterson<br>
<a href="http://tenderlovemaking.com/" class="external">http://tenderlovemaking.com/</a><br>
=end</p>