https://redmine.ruby-lang.org/
https://redmine.ruby-lang.org/favicon.ico?1711330511
2011-04-08T01:29:16Z
Ruby Issue Tracking System
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=16306
2011-04-08T01:29:16Z
shyouhei (Shyouhei Urabe)
shyouhei@ruby-lang.org
<ul></ul><p>=begin<br>
ext/readlineのメンテナの高尾さん:</p>
<p>本件の進捗状況についてうかがいたいです。<br>
=end</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=16319
2011-04-08T10:30:40Z
kouji (Kouji Takao)
kouji.takao@gmail.com
<ul></ul><p>=begin<br>
Shyouhei Urabe wrote:</p>
<blockquote>
<p>ext/readlineのメンテナの高尾さん:</p>
<p>本件の進捗状況についてうかがいたいです。</p>
</blockquote>
<p>すみません、確認できておりませんでした。<br>
今日中に動作確認して問題がないようであればコミットします。<br>
=end</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=16321
2011-04-08T14:02:53Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul><li><strong>Project</strong> changed from <i>Ruby</i> to <i>Ruby master</i></li><li><strong>Category</strong> changed from <i>ext</i> to <i>ext</i></li></ul><p>=begin</p>
<p>=end</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=16322
2011-04-08T14:07:05Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul></ul><p>=begin<br>
Bug <a class="issue tracker-2 status-6 priority-4 priority-default closed" title="Feature: Readline Command Completion (Rejected)" href="https://redmine.ruby-lang.org/issues/1823">#1823</a> と <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: ext/readline can't handle cursor keys and cp932 chars (Closed)" href="https://redmine.ruby-lang.org/issues/3827">#3827</a> もよろしう<br>
=end</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=17320
2011-05-30T04:32:04Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul></ul><p>r31265 で上記のパッチは適用されていますが、<br>
このパッチの when nil って誤りで、when false が正しいと思うんですが</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=17327
2011-05-30T12:06:12Z
shyouhei (Shyouhei Urabe)
shyouhei@ruby-lang.org
<ul></ul><p>あれ、いや、自信なくなってきたなあ。</p>
<p>もともとif ... else ... endだったんですが、それではうまくいかなくて、true/falseのほかにnilが来るパターンがあって、それに対応するためにtrue/fase/nilでcaseで分岐するようにしたように記憶してるんですが、ちがったっけな</p>
<p>enable_configの戻り値ってどうなってるんですっけ</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=17339
2011-05-30T19:24:40Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul></ul><p>Shyouhei Urabe wrote:</p>
<blockquote>
<p>もともとif ... else ... endだったんですが、それではうまくいかなくて、true/falseのほかにnilが来るパターンがあって、<br>
それに対応するためにtrue/fase/nilでcaseで分岐するようにしたように記憶してるんですが、ちがったっけな</p>
</blockquote>
<p>そんな雰囲気は漂っていたのでその辺は察しました。</p>
<blockquote>
<p>enable_configの戻り値ってどうなってるんですっけ</p>
</blockquote>
<p>--enable-libedit => true<br>
--disable-libedit => false<br>
無指定 => nil<br>
のようです。</p>
<p>一方 extconf.rb の中身は現在<br>
true => have_library("edit", "readline")<br>
nil => have_library("readline", "readline"))<br>
else (つまり false) => have_library("readline", "readline") || have_library("edit", "readline")<br>
となっているので、nil と false が逆なんじゃないかと。</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=17987
2011-06-15T20:29:13Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul></ul><p>結局これってどうしましょう</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=18097
2011-06-20T18:36:16Z
shyouhei (Shyouhei Urabe)
shyouhei@ruby-lang.org
<ul></ul><p>これ結局自分が間違ってたと思うんですが、どうすればいいんでしょう。勝手に直していい?</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=18101
2011-06-20T19:10:01Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul></ul><p>わたしは構いませんが高尾さん的にはどうなんでしょう。</p>
<p>ていうか、#1823 <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: ext/readline can't handle cursor keys and cp932 chars (Closed)" href="https://redmine.ruby-lang.org/issues/3827">#3827</a> <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Backport: Readline.completion_append_character (Closed)" href="https://redmine.ruby-lang.org/issues/4635">#4635</a> が放置されてて何とかしてくれって感じなんですが</p>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=18118
2011-06-21T11:34:08Z
kouji (Kouji Takao)
kouji.takao@gmail.com
<ul><li><strong>Due date</strong> set to <i>06/25/2011</i></li></ul><p>=begin<br>
対応が遅くなりました。<br>
以下の修正を入れたいと思います。<br>
動作確認をしてからコミットします。</p>
<a name="Index-extreadlineextconfrb"></a>
<h1 >Index: ext/readline/extconf.rb<a href="#Index-extreadlineextconfrb" class="wiki-anchor">¶</a></h1>
<p>--- ext/readline/extconf.rb (revision 32178)<br>
+++ ext/readline/extconf.rb (working copy)<br>
@@ -36,18 +36,21 @@</p>
<p>case enable_libedit<br>
when true</p>
<ul>
<li>
<a name="--enable-libedit"></a>
<h1 >--enable-libedit<a href="#--enable-libedit" class="wiki-anchor">¶</a></h1>
unless (have_readline_header("editline/readline.h") ||<br>
have_readline_header("readline/readline.h")) &&<br>
have_library("edit", "readline")<br>
exit<br>
end<br>
-when nil<br>
+when false</li>
<li>
<a name="--disable-libedit"></a>
<h1 >--disable-libedit<a href="#--disable-libedit" class="wiki-anchor">¶</a></h1>
unless ((have_readline_header("readline/readline.h") &&<br>
have_readline_header("readline/history.h")) &&<br>
have_library("readline", "readline"))<br>
exit<br>
end<br>
else</li>
<li>
<a name="does-not-specify"></a>
<h1 >does not specify<a href="#does-not-specify" class="wiki-anchor">¶</a></h1>
unless ((have_readline_header("readline/readline.h") &&<br>
have_readline_header("readline/history.h")) &&<br>
(have_library("readline", "readline") ||<br>
=end</li>
</ul>
Ruby master - Feature #3375: --disable-libedit to disable libedit
https://redmine.ruby-lang.org/issues/3375?journal_id=18120
2011-06-21T13:20:37Z
kouji (Kouji Takao)
kouji.takao@gmail.com
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r32179.<br>
Shyouhei, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<ul>
<li>ext/readline/extconf.rb: fixed bug, specify --disable-libedit<br>
then disable libedit, does not specify then check readline and<br>
libedit if failed checking readline. (fixes <a class="issue tracker-2 status-5 priority-4 priority-default closed behind-schedule" title="Feature: --disable-libedit to disable libedit (Closed)" href="https://redmine.ruby-lang.org/issues/3375">#3375</a>)</li>
</ul>