https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112020-12-25T09:33:13ZRuby Issue Tracking SystemRuby master - Feature #17468: Deprecate RUBY_DEVELhttps://redmine.ruby-lang.org/issues/17468?journal_id=895232020-12-25T09:33:13Znaruse (Yui NARUSE)naruse@airemix.jp
<ul><li><strong>Tracker</strong> changed from <i>Bug</i> to <i>Feature</i></li><li><strong>Backport</strong> deleted (<del><i>2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN</i></del>)</li></ul> Ruby master - Feature #17468: Deprecate RUBY_DEVELhttps://redmine.ruby-lang.org/issues/17468?journal_id=941832021-10-19T21:29:01Zjeremyevans0 (Jeremy Evans)merch-redmine@jeremyevans.net
<ul></ul><p>I looked into this. If we removed <code>RUBY_DEVEL</code>, we would make it so <code>ruby_debug_log</code> was never defined, since it is only defined if <code>RUBY_DEVEL</code> is defined. Basically, removing <code>RUBY_DEVEL</code> is equivalent to removing the removing the entire debug logging feature.</p>
<p>I think a safer and less invasive change is to make <code>RUBY_DEVEL</code> not depend on <code>PATCH_LEVEL</code>. By doing so, Ruby developers that want to use debug logging can still manually use <code>RUBY_DEVEL=yes</code> when configuring, but it will never be enabled automatically. I submitted a pull request for this: <a href="https://github.com/ruby/ruby/pull/4993" class="external">https://github.com/ruby/ruby/pull/4993</a>. One change it makes is to set <code>USE_RUBY_DEBUG_LOG</code> to 1 instead of 0 if <code>RUBY_DEVEL</code> is defined and <code>USE_RUBY_DEBUG_LOG</code> isn't. Since <code>RUBY_DEVEL</code> is no longer enabled automatically, the main reason to enable it would be to support debug logging, in which case I think <code>1</code> is a better default.</p> Ruby master - Feature #17468: Deprecate RUBY_DEVELhttps://redmine.ruby-lang.org/issues/17468?journal_id=956302021-12-25T07:45:30Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>When packaging a new tarball, we faced this issue again. Building a tarball produces so many warnings:</p>
<pre><code>./vm_debug.h:34:5: warning: "RUBY_DEVEL" is not defined, evaluates to 0 [-Wundef]
34 | #if RUBY_DEVEL
| ^~~~~~~~~~
./vm_debug.h:100:5: warning: "USE_RUBY_DEBUG_LOG" is not defined, evaluates to 0 [-Wundef]
100 | #if USE_RUBY_DEBUG_LOG
| ^~~~~~~~~~~~~~~~~~
In file included from ./vm.c:40:
./vm_sync.h:7:5: warning: "USE_RUBY_DEBUG_LOG" is not defined, evaluates to 0 [-Wundef]
7 | #if USE_RUBY_DEBUG_LOG
| ^~~~~~~~~~~~~~~~~~
</code></pre> Ruby master - Feature #17468: Deprecate RUBY_DEVELhttps://redmine.ruby-lang.org/issues/17468?journal_id=980332022-06-16T01:08:11Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul><li><strong>Target version</strong> changed from <i>3.1</i> to <i>3.2</i></li></ul> Ruby master - Feature #17468: Deprecate RUBY_DEVELhttps://redmine.ruby-lang.org/issues/17468?journal_id=986212022-08-10T05:14:37Zjeremyevans (Jeremy Evans)code@jeremyevans.net
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset <a class="changeset" title="Do not enable RUBY_DEVEL by RUBY_PATCHLEVEL This makes RUBY_DEVEL not enabled automatically. It..." href="https://redmine.ruby-lang.org/projects/ruby-master/repository/git/revisions/357352af5ee37bf31ba4468ee242ea5a10158461">git|357352af5ee37bf31ba4468ee242ea5a10158461</a>.</p>
<hr>
<p>Do not enable RUBY_DEVEL by RUBY_PATCHLEVEL</p>
<p>This makes RUBY_DEVEL not enabled automatically. It still can be<br>
enabled manually.</p>
<p>Test manually using RUBY_DEVEL in CI.</p>
<p>Implements [Feature <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Deprecate RUBY_DEVEL (Closed)" href="https://redmine.ruby-lang.org/issues/17468">#17468</a>]</p>