https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112019-04-30T12:43:27ZRuby Issue Tracking SystemRuby master - Bug #15812: Run specs from install folder?https://redmine.ruby-lang.org/issues/15812?journal_id=778442019-04-30T12:43:27ZEregon (Benoit Daloze)
<ul></ul><p>I wholeheartedly agree with that.<br>
Supporting running specs from the non-installed <code>ruby</code> is significant work and hacks.<br>
And testing what people use in production rather than a temporary build is of course much more meaningful.</p>
<p>But I don't think many people agree to require running <code>install</code> to run specs/tests, unfortunately, see <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Simplifying MRI's build system: always make install (Open)" href="https://redmine.ruby-lang.org/issues/13620">#13620</a>.<br>
Maybe we should do so that <code>make</code> creates an install-like layout in the first place with the build paths to e.g. libruby,<br>
so that we can run tests there without e.g., needing miniruby and tool/run-ruby.rb?</p>
<p>We could require running tests from the install directory only for Windows if people agree.</p>
<blockquote>
<p>spec tests normally run directly in their repo (ruby/spec)</p>
</blockquote>
<p>They don't need to, it's perfectly fine to run specs from the copy under spec/ruby in the ruby repository.</p> Ruby master - Bug #15812: Run specs from install folder?https://redmine.ruby-lang.org/issues/15812?journal_id=778472019-04-30T12:45:14ZEregon (Benoit Daloze)
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/15810">Bug #15810</a>: Windows spec failure - Process.ppid returns the process id of the parent of this process - ??</i> added</li></ul> Ruby master - Bug #15812: Run specs from install folder?https://redmine.ruby-lang.org/issues/15812?journal_id=778492019-04-30T12:45:34ZEregon (Benoit Daloze)
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-1 priority-4 priority-default" href="/issues/13620">Feature #13620</a>: Simplifying MRI's build system: always make install</i> added</li></ul> Ruby master - Bug #15812: Run specs from install folder?https://redmine.ruby-lang.org/issues/15812?journal_id=801922019-07-29T11:14:51ZEregon (Benoit Daloze)
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Eregon (Benoit Daloze)</i></li></ul><p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/11129">@MSP-Greg (Greg L)</a> I think it's OK to run specs after make-install if that is somehow better in CI.</p>
<p>I'd like to only support running specs on installed Ruby, but that's a separate issue: <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Simplifying MRI's build system: always make install (Open)" href="https://redmine.ruby-lang.org/issues/13620">#13620</a>.</p>
<p>I saw that you closed <a href="https://github.com/ruby/ruby/pull/2160" class="external">https://github.com/ruby/ruby/pull/2160</a>.<br>
Tell me if you want to add such a change, I can merge it.</p>
<p>I'll close this issue since the PR was closed, but please comment if you want it again.</p>