https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112009-06-03T14:32:32ZRuby Issue Tracking SystemRuby master - Bug #1559: ERB single line comment does not workhttps://redmine.ruby-lang.org/issues/1559?journal_id=41672009-06-03T14:32:32Zbitsweat (Jeremy Daer)jeremydaer@gmail.com
<ul></ul><p>=begin<br>
<%# this comment (no space between % and #) works in 1.9.1 %></p>
<p>I think <% # (with a space) was a side effect not a feature.<br>
=end</p> Ruby master - Bug #1559: ERB single line comment does not workhttps://redmine.ruby-lang.org/issues/1559?journal_id=46352009-07-13T23:20:08Zyugui (Yuki Sonoda)yugui@yugui.jp
<ul><li><strong>Assignee</strong> set to <i>seki (Masatoshi Seki)</i></li></ul><p>=begin</p>
<p>=end</p> Ruby master - Bug #1559: ERB single line comment does not workhttps://redmine.ruby-lang.org/issues/1559?journal_id=50862009-08-03T20:24:34Zjfahrenkrug (Johannes Fahrenkrug)jfahrenkrug@gmail.com
<ul></ul><p>=begin<br>
Hi,</p>
<p>I just ran into this issue on ruby 1.8.7 (2008-08-11 patchlevel 72) [i486-linux] as well. The test_erb.rb test fails.<br>
On ruby 1.8.6 (2008-08-11 patchlevel 287) [universal-darwin9.0], however, it passes.</p>
<ul>
<li>Johannes<br>
=end</li>
</ul> Ruby master - Bug #1559: ERB single line comment does not workhttps://redmine.ruby-lang.org/issues/1559?journal_id=52652009-08-15T10:52:27Zkhelll (khaled alhabache)khellls@gmail.com
<ul></ul><p>=begin<br>
This bug is somehow annoying specially when u move from ruby 1.8.6 to either 1.8.7 or 1.9 and working with rails, many comments in views files.....<br>
=end</p> Ruby master - Bug #1559: ERB single line comment does not workhttps://redmine.ruby-lang.org/issues/1559?journal_id=99132010-04-06T09:31:15Zrsalkeld (Robin Salkeld)robin.salkeld@sap.com
<ul></ul><p>=begin<br>
This seems to be caused by removing \n from the regular expressions used in ERB::Compiler::SimpleScanner2:</p>
<p>stag_reg = /(.<em>?)(<%%|<%=|<%#|<%|\z)/m<br>
etag_reg = /(.</em>?)(%%>|%>|\z)/m</p>
<p>It looks like the original change was intended as an optimization, but unintentionally changed the behaviour. Restoring the \n's fixes it.</p>
<p><%# may work for comments as well, but a lot of us have relied on the old behaviour, and I see no reason not to fix an accidental regression.<br>
=end</p> Ruby master - Bug #1559: ERB single line comment does not workhttps://redmine.ruby-lang.org/issues/1559?journal_id=101942010-04-14T23:38:08Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Rejected</i></li></ul><p>=begin<br>
Hi,</p>
<p>The maintainer of erb (Masatoshi Seki) formally rejected this<br>
ticket in <a href="https://blade.ruby-lang.org/ruby-dev/40990">[ruby-dev:40990]</a>.</p>
<p>Use <%# ... %>.</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p>