https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112018-10-20T23:52:53ZRuby Issue Tracking SystemRuby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=745472018-10-20T23:52:53Zk0kubun (Takashi Kokubun)takashikkbn@gmail.com
<ul><li><strong>Assignee</strong> set to <i>suke (Masaki Suketa)</i></li></ul> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=745532018-10-21T17:26:11ZMSP-Greg (Greg L)
<ul></ul><p>Looking over test logs from today, I noticed <code>TestWIN32OLE_EVENT_ADO</code> in <code>test/win32ole/test_win32ole_event.rb</code>, which is skipped on Appveyor.</p>
<p>If above patch is okay, I could create another class <code>TestWIN32OLE_EVENT_MSXML</code>?</p> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=746162018-10-27T07:04:20Zsuke (Masaki Suketa)masaki.suketa@nifty.ne.jp
<ul></ul><p>Thank you for your patch. I'm reeding your patch now. And I'm afraid<br>
your patch would be fail on environment except Windows (on Linux, etc).<br>
I'll modify your patch and marge it. Thank you again.</p> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=746222018-10-27T13:21:20ZMSP-Greg (Greg L)
<ul></ul><p>suke (Masaki Suketa) wrote:</p>
<p>Thanks for looking at it. Apologies for not testing on Travis.</p>
<blockquote>
<p>I'm afraid your patch would fail on environment except Windows (on Linux, etc).</p>
</blockquote>
<p>Sorry, I thought I had 'windows guards' on everything, I may have missed a few. Thanks for looking at it, as the Appveyor CI is having issues with the IE object. Appveyor build/test times vary a great deal, so I felt this was needed to lower the 'resource needs' of these tests. I've never had an issue with them (using IE) running locally...</p> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=746232018-10-27T13:58:35ZEregon (Benoit Daloze)
<ul></ul><p>Sounds good to me to use the MSXML object.<br>
The patch looks good from a quick look.</p> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=746272018-10-28T01:20:30Zk0kubun (Takashi Kokubun)takashikkbn@gmail.com
<ul></ul><p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/735">@suke (Masaki Suketa)</a> r65401 is breaking CI on Linux like <a href="https://gist.github.com/ko1/2c561f9185492f339cf7a763ea219e79" class="external">https://gist.github.com/ko1/2c561f9185492f339cf7a763ea219e79</a>, so the assumption "this file is required on Windows only" seems not correct. I reverted that in r65402. Could you check it?</p> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=746282018-10-28T01:24:13ZMSP-Greg (Greg L)
<ul></ul><p>Please look at the patch. It modifies several files. Removing the rescue block without patching the other files will break non windows builds. It passes on Travis. Twice.</p>
<p>Before this issue, and before the PR, I've used the patch in ruby-loco and it has worked just fine.</p> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=746302018-10-28T01:34:07ZMSP-Greg (Greg L)
<ul></ul><p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/10073">@k0kubun (Takashi Kokubun)</a> & <a class="user active user-mention" href="https://redmine.ruby-lang.org/users/735">@suke (Masaki Suketa)</a></p>
<p>When I did the patch, I saw no reason to have non Windows builds requiring the classes.rb file if they weren't using it. Hence, for many of the files in the patch, the only change is to move the <code> require_relative '../fixtures/classes'</code> staement inside of the <code>platform_is :windows do</code> block. As mentioned above, without that...</p> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=746332018-10-28T04:31:52ZMSP-Greg (Greg L)
<ul></ul><p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/735">@suke (Masaki Suketa)</a></p>
<p>I'd like to help. I just ran CI again on the branch I created the PR from, it passed in both Travis & Appveyor.</p>
<p>I can't rebase due to conflicts, but I can get around that quickly. If it's done a file at a time, it will take a while on CI...</p>
<p>Otherwise, I'm AFK.</p> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=746352018-10-28T07:19:10Zsuke (Masaki Suketa)masaki.suketa@nifty.ne.jp
<ul></ul><p>Thank you for your help. I prefer to use MSXML.Document for WIN32OLE_EVENT specs.<br>
Because I think other (light and more standard) COM objects (like Scripting.Dictionary) have features for other specs.<br>
I applied the win32ole_event part of your patch to ruby-trunk.<br>
Thank you again.</p>
<p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/10073">@k0kubun (Takashi Kokubun)</a></p>
<blockquote>
<p>the assumption "this file is required on Windows only" seems not correct. I reverted that in r65402. Could you check it?</p>
</blockquote>
<p>Sorry, I missed it and misunderstood. I retried requiring the file only when platform is Windows in r65416.</p> Ruby master - Feature #15239: [patch] test-spec win32olehttps://redmine.ruby-lang.org/issues/15239?journal_id=835322019-12-29T13:04:03Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul><li><strong>Tracker</strong> changed from <i>Misc</i> to <i>Feature</i></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li></ul>