https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112018-07-11T09:52:36ZRuby Issue Tracking SystemRuby master - Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_waithttps://redmine.ruby-lang.org/issues/14906?journal_id=729132018-07-11T09:52:36Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:Greg.mpls@gmail.com" class="email">Greg.mpls@gmail.com</a> wrote:</p>
<blockquote>
<p><a href="https://bugs.ruby-lang.org/issues/14906" class="external">https://bugs.ruby-lang.org/issues/14906</a></p>
</blockquote>
<p>I made r63950 to skip tests to diagnose the issue.<br>
I don't think threads are running at that point, but maybe<br>
the thread leakchecker can find them...</p>
<p>You will need to enable TESTS=--show-skip for test-all to<br>
show the skips.</p>
<blockquote>
<p>I haven't really looked at it, or especially<br>
<code>assert_cpu_usage_low</code>, but a change to loosen the test up<br>
would be helpful.</p>
</blockquote>
<p>We've already loosened it up quite a bit. Sadly, extending<br>
the sleep time in the test might be the most reliable way;<br>
but it makes the test slower</p> Ruby master - Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_waithttps://redmine.ruby-lang.org/issues/14906?journal_id=729162018-07-11T13:29:23ZMSP-Greg (Greg L)
<ul></ul><p><a class="user active user-mention" href="https://redmine.ruby-lang.org/users/724">@normalperson (Eric Wong)</a></p>
<p>Eric,</p>
<p>r63947 was causing a test-all failure, as on Windows, one can't do <code>File.unlink(t.path)</code> if t is open (or before <code>t.close</code>). I did a PR, and a moment later, <a class="user active user-mention" href="https://redmine.ruby-lang.org/users/14">@znz (Kazuhiro NISHIYAMA)</a> pushed a commit. mswin passed test-all.</p>
<p>That was the only issue in mswin, I'll started a ruby-loco built shortly.</p>
<p>I've always used <code>--show-skip</code>, and from time to time check the skips. It has been stable...</p>
<p>Thanks again, Greg</p> Ruby master - Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_waithttps://redmine.ruby-lang.org/issues/14906?journal_id=729212018-07-11T20:03:50Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:Greg.mpls@gmail.com" class="email">Greg.mpls@gmail.com</a> wrote:</p>
<blockquote>
<p>r63947 was causing a test-all failure, as on Windows, one<br>
can't do <code>File.unlink(t.path)</code> if t is open (or before<br>
<code>t.close</code>). I did a PR, and a moment later, <a class="user active user-mention" href="https://redmine.ruby-lang.org/users/14">@znz (Kazuhiro NISHIYAMA)</a> pushed a<br>
commit. mswin passed test-all.</p>
</blockquote>
<p>Oops, sorry about that :x</p>
<blockquote>
<p>I've always used <code>--show-skip</code>, and from time to time check<br>
the skips. It has been stable...</p>
</blockquote>
<p>OK, apparently there's cases of runaway threads leakchecker.rb<br>
fails to find. I made r63952 but there seems to be more...</p> Ruby master - Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_waithttps://redmine.ruby-lang.org/issues/14906?journal_id=729272018-07-12T03:52:32ZMSP-Greg (Greg L)
<ul></ul><p>normalperson (Eric Wong) wrote:</p>
<blockquote>
<p>Oops, sorry about that :x</p>
</blockquote>
<p>No problem. I don't expect you or anyone else to know Windows. I'm well aware that the vast majority of production Ruby apps don't run on Windows.</p>
<p>It wasn't that long ago when there was no real testing of Windows builds. Now, mswin & mingw normally pass all tests. Thanks to you and everyone else...</p>
<p>Anyway, would a summary of all tests that failed/errored during parallel testing but passed during 'retry' be helpful? I've got all the build logs saved locally, so I can go back quite a few builds...</p>
<p>Thanks, Greg</p> Ruby master - Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_waithttps://redmine.ruby-lang.org/issues/14906?journal_id=1042502023-08-23T22:30:17Zjeremyevans0 (Jeremy Evans)merch-redmine@jeremyevans.net
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul>