https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112018-06-28T18:40:43ZRuby Issue Tracking SystemRuby master - Feature #14878: Add command line argument to deactivate JIThttps://redmine.ruby-lang.org/issues/14878?journal_id=726952018-06-28T18:40:43Zshevegen (Robert A. Heiler)shevegen@gmail.com
<ul></ul><p>Agreed!</p>
<p>I guess it may have already been on Takashi's todo list but he is like doing<br>
lots of changes as-is.</p>
<p>As for options, I think "--disable-jit" and/or "--no-jit" would be best;<br>
--disable=jit is also ok but a bit less commonly used compared to options<br>
without a '='.</p>
<p>The flag "--jit-disable" is a bit weird because I think it is not very common<br>
to have the verb come last (e.g. --FEATURE--enable or --FEATURE--disable) but<br>
I think these are details, not the big picture.</p>
<p>And on the suggestion itself to be able to have control over the jit, I<br>
fully agree. I would even enable both compilation support for jit (yes/no)<br>
and also on the commandline (yes/no). I myself would want to run with jit<br>
on all the time, but as described, there may be many reasons why some<br>
people may not want to or can not use mjit, so in these cases, I think<br>
it makes sense to have it optional (or "controllable" by the ruby hacker<br>
at hand), so</p>
<p>+1</p> Ruby master - Feature #14878: Add command line argument to deactivate JIThttps://redmine.ruby-lang.org/issues/14878?journal_id=729972018-07-18T07:41:03Zakr (Akira Tanaka)akr@fsij.org
<ul></ul><p>There is already --enable=... and --disable=...</p>
<pre><code>% ruby --help
...
--enable={gems|rubyopt|...}[,...], --disable={gems|rubyopt|...}[,...]
enable or disable features. see below for available features
...
</code></pre>
<p>I think there is no reason to use different style for this issue.</p> Ruby master - Feature #14878: Add command line argument to deactivate JIThttps://redmine.ruby-lang.org/issues/14878?journal_id=730022018-07-18T12:46:01Zk0kubun (Takashi Kokubun)takashikkbn@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset trunk|r63995.</p>
<hr>
<p>ruby.c: accept --disable-jit option</p>
<p>by promoting jit to feature flag.</p>
<p>mjit.h: update comment about mjit_opts.on</p>
<p>test_rubyoptions.rb: add test for switching JIT enablement</p>
<p>"--jit" flag usage may be deprecated later, but not discussed yet.</p>
<p>[Feature <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add command line argument to deactivate JIT (Closed)" href="https://redmine.ruby-lang.org/issues/14878">#14878</a>]</p> Ruby master - Feature #14878: Add command line argument to deactivate JIThttps://redmine.ruby-lang.org/issues/14878?journal_id=730032018-07-18T12:46:35Zk0kubun (Takashi Kokubun)takashikkbn@gmail.com
<ul></ul><p>Now --enable-jit, --enable=jit, --disable-jit, --disable=jit are available.</p>