https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112017-06-23T15:57:24ZRuby Issue Tracking SystemRuby master - Bug #13675: Should Zlib::GzipReader#ungetc accept nil?https://redmine.ruby-lang.org/issues/13675?journal_id=654552017-06-23T15:57:24Zshevegen (Robert A. Heiler)shevegen@gmail.com
<ul></ul><p>I like symmetry. :)</p> Ruby master - Bug #13675: Should Zlib::GzipReader#ungetc accept nil?https://redmine.ruby-lang.org/issues/13675?journal_id=680342017-11-29T09:24:14Zmatz (Yukihiro Matsumoto)matz@ruby.or.jp
<ul></ul><p>Making <code>Zlib::GzipReader#ungetc</code> accept nil does not help anybody. You should keep as it is.<br>
I am not sure if we should fix <code>IO#ungetc</code> or not (yet). Let me consider.</p>
<p>Matz.</p> Ruby master - Bug #13675: Should Zlib::GzipReader#ungetc accept nil?https://redmine.ruby-lang.org/issues/13675?journal_id=681282017-12-01T19:01:42ZEregon (Benoit Daloze)
<ul></ul><p>matz (Yukihiro Matsumoto) wrote:</p>
<blockquote>
<p>Making <code>Zlib::GzipReader#ungetc</code> accept nil does not help anybody. You should keep as it is.</p>
</blockquote>
<p>Agreed.</p>
<blockquote>
<p>I am not sure if we should fix <code>IO#ungetc</code> or not (yet). Let me consider.</p>
</blockquote>
<p>I think we should, it seems a bug to me.</p> Ruby master - Bug #13675: Should Zlib::GzipReader#ungetc accept nil?https://redmine.ruby-lang.org/issues/13675?journal_id=809902019-08-25T18:28:36Zjeremyevans0 (Jeremy Evans)merch-redmine@jeremyevans.net
<ul><li><strong>File</strong> <a href="/attachments/8018">io-ungetc-nil-13675.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/8018/io-ungetc-nil-13675.patch">io-ungetc-nil-13675.patch</a> added</li></ul><p>If we want to fix <code>IO#ungetc</code>, attached is a patch that will fix it.</p> Ruby master - Bug #13675: Should Zlib::GzipReader#ungetc accept nil?https://redmine.ruby-lang.org/issues/13675?journal_id=843932020-02-27T05:13:10Zmatz (Yukihiro Matsumoto)matz@ruby.or.jp
<ul></ul><p><code>IO#ungetc</code> should be fixed. The patch looks good to me.</p>
<p>Matz.</p> Ruby master - Bug #13675: Should Zlib::GzipReader#ungetc accept nil?https://redmine.ruby-lang.org/issues/13675?journal_id=844142020-02-27T18:18:16Zjeremyevans (Jeremy Evans)code@jeremyevans.net
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset <a class="changeset" title="Remove support for passing nil to IO#ungetc Fixes [Bug #13675]" href="https://redmine.ruby-lang.org/projects/ruby-master/repository/git/revisions/54499d78109037d7c37bc09a8c3ffa0050da5aca">git|54499d78109037d7c37bc09a8c3ffa0050da5aca</a>.</p>
<hr>
<p>Remove support for passing nil to IO#ungetc</p>
<p>Fixes [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Should Zlib::GzipReader#ungetc accept nil? (Closed)" href="https://redmine.ruby-lang.org/issues/13675">#13675</a>]</p>