https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112017-04-24T16:40:43ZRuby Issue Tracking SystemRuby master - Bug #13500: MinGW TestArity#test_proc_err_mess stops testinghttps://redmine.ruby-lang.org/issues/13500?journal_id=644512017-04-24T16:40:43ZMSP-Greg (Greg L)
<ul></ul><p>This morning, a MinGW build of</p>
<pre><code>ruby 2.5.0dev (2017-04-24 trunk 58467) [x64-mingw32]
</code></pre>
<p>completed <code>test-all</code> with</p>
<pre><code>16621 tests, 2227533 assertions, 8 failures, 1 errors, 114 skips
</code></pre>
<p>I've mentioned that I am not fluent in c. Closest I've come is C#, and that was quite a while ago, and I realize that C# is managed and GC'd. Conversely, I have been coding for a very long time.</p>
<p>If there is anything I can do to help solve this issue (which is intermittent), please let me know.</p>
<p>Today, I grabbed the tests that have intermittently stopped <code>test-all</code>, and ran them 200 times. They completed, which is a good sign, but I've never tried it before. I'll continue to do that with all builds.</p>
<p>The tests were the following:</p>
<pre><code>ruby --disable-gems runner_t.rb -v -druby_stop
Run options: -v --show-skip
# Running tests:
[1/6] TestArity#test_proc_err_mess = 0.00 s
[2/6] TestKeywordArguments#test_block_required_keyword = 0.00 s
[3/6] TestKeywordArguments#test_f4 = 0.00 s
[4/6] TestKeywordArguments#test_f5 = 0.00 s
[5/6] TestLambdaParameters#test_exact_parameter = 0.00 s
[6/6] TestRubyYieldGen#test_yield_lambda = 1.73 s
Finished tests in 1.762800s, 3.4037 tests/s, 3041.7518 assertions/s.
6 tests, 5362 assertions, 0 failures, 0 errors, 0 skips
ruby -v: ruby 2.5.0dev (2017-04-24 trunk 58467) [x64-mingw32]
</code></pre>
<p>Just in case, I've summarized my build code below.</p>
<p>I have several patches that I've needed over the past few months to allow <code>test-all</code> to complete. For this build, I had patches for:</p>
<pre><code>test/ruby/test_enum.rb
test/socket/test_socket.rb
</code></pre>
<p>Previously, for test-all to complete, I've needed patches for:</p>
<pre><code>test/fileutils/test_fileutils.rb
test/ruby/test_arity.rb
test/ruby/test_keyword.rb
test/ruby/test_lambda.rb
test/ruby/test_yield.rb
</code></pre>
<p>My configure 'specials' are:</p>
<pre><code> --with-baseruby=${RUBY} \
--disable-install-doc \
--with-git=${GIT} \
--with-out-ext=pty,syslog
</code></pre>
<p>Patches to 'base' ruby are listed in <a href="https://bugs.ruby-lang.org/issues/13496" class="external">13496</a>.</p>
<p>My make lines are:</p>
<pre><code>make BASERUBY=${RUBY} touch-unicode-files
make after-update BASERUBY=${RUBY} UNICODE_FILES=.
make -j3 all
</code></pre>
<p>If I've got anything incorrect in the above, please let me know. Finally, thanks for everyone's help.</p> Ruby master - Bug #13500: MinGW TestArity#test_proc_err_mess stops testinghttps://redmine.ruby-lang.org/issues/13500?journal_id=644902017-04-26T15:27:12ZMSP-Greg (Greg L)
<ul></ul><p>Today (2017-04-26), I built <code>ruby 2.5.0dev (2017-04-26 trunk 58487) [x64-mingw32]</code></p>
<p>To complete test-all, it required additional patches for:</p>
<pre><code>test/fileutils/test_fileutils.rb
test/ruby/test_arity.rb
test/ruby/test_keyword.rb
test/ruby/test_yield.rb
</code></pre>
<p>After those patches, it had the following result:</p>
<pre><code>16622 tests, 2222464 assertions, 8 failures, 1 errors, 114 skips
</code></pre>
<p>Yesterday, I built <code>ruby 2.5.0dev (2017-04-25 trunk 58476) [x64-mingw32]</code></p>
<p>With the following result (no 'additional' patches were required):</p>
<pre><code>16622 tests, 2227747 assertions, 8 failures, 1 errors, 114 skips
</code></pre>
<p>Today and yesterday's builds both used patches for the following:</p>
<pre><code>test/ruby/test_enum.rb
test/socket/test_socket.rb
</code></pre>
<p>I believe most of the assertion differential is due to the patch for <code>test/ruby/test_yield.rb</code>, which is:</p>
<pre><code class="diff syntaxhl" data-language="diff"><span class="gd">--- a/test/ruby/test_yield.rb Sat Apr 22 07:41:22 2017
</span><span class="gi">+++ b/test/ruby/test_yield.rb Sat Apr 22 15:45:20 2017
</span><span class="p">@@ -372,7 +372,7 @@</span>
end
def test_yield_lambda
<span class="gd">- assert_all_sentences(Syntax, :test_lambda, 4) {|t|
</span><span class="gi">+ assert_all_sentences(Syntax, :test_lambda, 2) {|t|
</span> check_nofork(t, true)
}
end
</code></pre>
<p>Many of the tests that require patches seem to involve error handling. If one's code is not heavily reliant on <code>rescue</code> clauses, this may not cause user issues.</p>
<p>Regardless, test-all should not silently stop.</p> Ruby master - Bug #13500: MinGW TestArity#test_proc_err_mess stops testinghttps://redmine.ruby-lang.org/issues/13500?journal_id=1042342023-08-23T19:06:18Zjeremyevans0 (Jeremy Evans)merch-redmine@jeremyevans.net
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul>