https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112016-04-14T18:58:02ZRuby Issue Tracking SystemRuby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=580812016-04-14T18:58:02Znaruse (Yui NARUSE)naruse@airemix.jp
<ul><li><strong>Tracker</strong> changed from <i>Bug</i> to <i>Misc</i></li></ul> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=580832016-04-14T21:51:49Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:naruse@airemix.jp" class="email">naruse@airemix.jp</a> wrote:</p>
<blockquote>
<p>How about Git-style commit message instead of ChangeLog?</p>
</blockquote>
<p>Yes please :)</p>
<p>The current changelog format is a very annoying barrier to<br>
making commits; especially for applying patches from others.</p>
<blockquote>
<p>Matz agreed with this proposal, provided that a ChangeLog-like plain-text file is generated from the commit log.</p>
</blockquote>
<p>I don't even think that's necessary; NEWS file with pointers to<br>
SVN/git history is enough.</p> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=581342016-04-18T09:00:17Zduerst (Martin Dürst)duerst@it.aoyama.ac.jp
<ul></ul><p>I welcome this proposal. It makes committing easier. Can you please tell us when this proposal will actually start? I see people still committing ChangeLog changes.</p> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=581532016-04-19T04:33:48Zsonots (Naotoshi Seo)sonots@gmail.com
<ul></ul><p>I am positive this proposal, too. ChangeLog often conflicts and I encountered with conflicts today, too.</p> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=581602016-04-20T01:39:05Zshyouhei (Shyouhei Urabe)shyouhei@ruby-lang.org
<ul></ul><p>Seems no one is against abandoning ChangeLog.</p>
<p>What about "a ChangeLog-like plain-text file" part?</p> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=582932016-04-24T15:47:55Znaruse (Yui NARUSE)naruse@airemix.jp
<ul></ul><p>Shyouhei Urabe wrote:</p>
<blockquote>
<p>Seems no one is against abandoning ChangeLog.</p>
<p>What about "a ChangeLog-like plain-text file" part?</p>
</blockquote>
<p>One idea is just <code>svn log -rHEAD:53286</code>, and we can customize the format further.<br>
(I use git show <code>git merge-base trunk origin/ruby_2_3</code> to show the commit)</p>
<p>TODO:</p>
<ul>
<li>How to get the beginning revision of the branch with subversion.</li>
<li>What format the new ChangLog should be.</li>
</ul> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=582962016-04-24T18:41:35Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:naruse@airemix.jp" class="email">naruse@airemix.jp</a> wrote:</p>
<blockquote>
<p>Shyouhei Urabe wrote:</p>
<blockquote>
<p>Seems no one is against abandoning ChangeLog.</p>
<p>What about "a ChangeLog-like plain-text file" part?</p>
</blockquote>
</blockquote>
<p>I don't think it's useful given how prevalent git and SVN are<br>
among developers. NEWS is much more useful to end users.</p>
<blockquote>
<p>One idea is just <code>svn log -rHEAD:53286</code>, and we can customize the format further.<br>
(I use git show <code>git merge-base trunk origin/ruby_2_3</code> to show the commit)</p>
<p>TODO:</p>
<ul>
<li>How to get the beginning revision of the branch with subversion.</li>
</ul>
</blockquote>
<p>We can document that in NEWS.</p> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=583382016-04-26T19:51:37Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p><a href="mailto:naruse@airemix.jp" class="email">naruse@airemix.jp</a> wrote:</p>
<blockquote>
<ol>
<li>Write a commit message in Git-style.</li>
</ol>
<ul>
<li>Line 1: summary of commit (around 80 characters or less, <50 is better)</li>
<li>Line 2: empty line</li>
<li>Line 3-: More detailed explanation of commit</li>
</ul>
</blockquote>
<p>Fwiw, I already do that in my commits. I would also like<br>
stable branch maintainers to maintain the summary when merging,<br>
and refer to trunk commit in message body.<br>
(Use "-x" in "git cherry-pick -x")</p>
<p>For example, oneline view of ten v2_3.0..v2_3_1 changes in Ruby<br>
is not very informative by itself:</p>
<p>$ git log --abbrev-commit --pretty=oneline -10 v2_3_0..v2_3_1<br>
5827d8e add tag v2_3_1<br>
394fa89 version.h: bump up teeny. 2.3.0 -> 2.3.1.<br>
52c883b merge revision(s) 53320,54756: [Backport <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: [DOC] Language improvements for doc/extension.rdoc (Closed)" href="https://redmine.ruby-lang.org/issues/12246">#12246</a>]<br>
2d360c5 merge revision(s) 54755: [Backport <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: [DOC] Fix two code samples (Closed)" href="https://redmine.ruby-lang.org/issues/12313">#12313</a>]<br>
7f36210 merge revision(s) 54758:<br>
6ccc9e9 merge revision(s) 54716,54719,54750: [Backport <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Backport r54716, r54719 and r54750 (don't use system round(3) on AIX) (Closed)" href="https://redmine.ruby-lang.org/issues/12314">#12314</a>]<br>
7b70f0e merge revision(s) 54720: [Backport <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Cygwin LANG=ja_JP.SJIS 環境でコマンドライン引数に日本語が渡せない (Closed)" href="https://redmine.ruby-lang.org/issues/12184">#12184</a>]<br>
ab3376b merge revision(s) 54681: [Backport <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: at_exit status status is changed by raising/rescueing a exception in at_exit (Closed)" href="https://redmine.ruby-lang.org/issues/12302">#12302</a>]<br>
b8aa410 merge revision(s) 54141,54542,54548: [Backport <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Tail-calling method can't catch exception raised by tail-called method (Closed)" href="https://redmine.ruby-lang.org/issues/12082">#12082</a>]<br>
9224427 merge revision(s) 54423,54489: [Backport <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: nkf.c static void fold_conv part of exression always true (Closed)" href="https://redmine.ruby-lang.org/issues/12201">#12201</a>] [Backport <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: nkf.c static void mime_putc the variable being used for loop used for outer loop too (Closed)" href="https://redmine.ruby-lang.org/issues/12202">#12202</a>]</p>
<p>Compare the above output with Linux v4.5.1..v4.5.2:</p>
<p>$ git log --abbrev-commit --pretty=oneline -10 v4.5.1..v4.5.2<br>
92b8a3b Linux 4.5.2<br>
9378a3b staging: android: ion: Set the length of the DMA sg entries in buffer<br>
383b59f HID: usbhid: fix inconsistent reset/resume/reset-resume behavior<br>
2fa2fc1 HID: wacom: fix Bamboo ONE oops<br>
9bfe5a5 ALSA: usb-audio: Skip volume controls triggers hangup on Dell USB Dock<br>
1b040b3 ALSA: usb-audio: Add a quirk for Plantronics BT300<br>
4e088a6 ALSA: usb-audio: Add a sample rate quirk for Phoenix Audio TMX320<br>
0e3d5c4 ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s<br>
285947f ALSA: hda - Fix regression of monitor_present flag in eld proc file<br>
9e91bf3 mmc: sdhci-pci: Add support and PCI IDs for more Broxton host controllers</p>
<p>Note: I suggest cloning linux.git with bundle for resumability and<br>
to reduce server load:</p>
<p><a href="https://www.kernel.org/cloning-linux-from-a-bundle.html" class="external">https://www.kernel.org/cloning-linux-from-a-bundle.html</a></p>
<p>(Git hackers thinking of ways to make cloning large repos more<br>
efficient and resumable :)</p> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=585512016-05-10T07:44:14Zshevegen (Robert A. Heiler)shevegen@gmail.com
<ul></ul><p>I personally have no preference either way.</p>
<p>I should however had also note that I like the current changelog format:</p>
<p><a href="https://github.com/ruby/ruby/blob/trunk/ChangeLog" class="external">https://github.com/ruby/ruby/blob/trunk/ChangeLog</a></p>
<p>It sort of is easy for me to read what is new, what is changed, what<br>
is being worked on etc...</p>
<p>For me who is more or less a casual ruby user, writing mostly just ruby<br>
code, it allows me to keep track of that in a very easy manner.</p>
<blockquote>
<blockquote>
<p>Matz agreed with this proposal, provided that a ChangeLog-like plain-text file is generated from the commit log.</p>
</blockquote>
</blockquote>
<blockquote>
<p>I don't even think that's necessary; NEWS file with pointers to<br>
SVN/git history is enough.</p>
</blockquote>
<p>I like the changelogs more than the NEWS file - I don't even look<br>
at the news file much at all, easier to keep track of current<br>
changes as they happen. :-)</p> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=587172016-05-18T00:14:09Zshyouhei (Shyouhei Urabe)shyouhei@ruby-lang.org
<ul></ul><p>I asked matz why he need a ChangeLog yesterday. He answered that the problem is <code>svn log</code>. It requires network connection, and is painfully slow.</p>
<p>At least until we give up subversion, there should be a file-based ChangeLog-ish mechanism. Matz said it's OK for him to auto-generate such thing from commit comments.</p>
<p>Once we equipped a subversion hook script to auto-generate a ChangeLog, we can start migrate this way.</p> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=591592016-06-13T06:14:15Zshyouhei (Shyouhei Urabe)shyouhei@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>naruse (Yui NARUSE)</i></li></ul> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=613572016-11-06T12:57:50Znaruse (Yui NARUSE)naruse@airemix.jp
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul><p>Applied in changeset r56638.</p>
<hr>
<ul>
<li>
<p>tool/vcs.rb (export_changelog): generate ChangeLog file from<br>
vcs's log. [Feature <a class="issue tracker-5 status-5 priority-4 priority-default closed" title="Misc: Obsolete ChangeLog and commit message in Git-style (Closed)" href="https://redmine.ruby-lang.org/issues/12283">#12283</a>]</p>
</li>
<li>
<p>tool/make-snapshot (package): overwrite ChangeLog by generated<br>
ChangeLog.</p>
</li>
</ul> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=613632016-11-07T00:13:29Zshyouhei (Shyouhei Urabe)shyouhei@ruby-lang.org
<ul></ul><p>!!!</p>
<p>So is it now open? Can we commit without ChangeLog entry?</p> Ruby master - Misc #12283: Obsolete ChangeLog and commit message in Git-stylehttps://redmine.ruby-lang.org/issues/12283?journal_id=613912016-11-07T09:35:57Zvo.x (Vit Ondruch)v.ondruch@tiscali.cz
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/12908">Bug #12908</a>: make-snapshot is broken</i> added</li></ul>