https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17097754782015-09-14T19:18:24ZRuby Issue Tracking SystemRuby master - Bug #11526: Streaming HTTP requests are not idempotent and should not be retriedhttps://redmine.ruby-lang.org/issues/11526?journal_id=541862015-09-14T19:18:24Ztdg5 (Danny Guinther)dannyguinther@gmail.com
<ul></ul><p>GitHub PR: <a href="https://github.com/ruby/ruby/pull/1019" class="external">https://github.com/ruby/ruby/pull/1019</a></p> Ruby master - Bug #11526: Streaming HTTP requests are not idempotent and should not be retriedhttps://redmine.ruby-lang.org/issues/11526?journal_id=541982015-09-15T17:42:01Ztdg5 (Danny Guinther)dannyguinther@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/5496">trowe-net-http-idempotent-retry-fix.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5496/trowe-net-http-idempotent-retry-fix.diff">trowe-net-http-idempotent-retry-fix.diff</a> added</li></ul><p>Trevor Rowe (<a href="https://github.com/trevorrowe" class="external">https://github.com/trevorrowe</a>) also proposed the following PR on GitHub to address this issue on June 30th, 2015: <a href="https://github.com/ruby/ruby/pull/951" class="external">https://github.com/ruby/ruby/pull/951</a></p>
<p>His code looks solid to me and seems a better solution than what I've hacked together. As such, I have closed my PR with a reference to Trevor's PR.</p>
<p>If Trevor's PR was ignored because a respective ticket was not filed, please consider this issue to be the missing issue and let's get his code merged!</p>
<p>I've created a branch of Trevor's change rebased against current trunk here: <a href="https://github.com/tdg5/ruby/tree/trowe-net-http-idempotent-retry-fix" class="external">https://github.com/tdg5/ruby/tree/trowe-net-http-idempotent-retry-fix</a></p>
<p>I've also attached a diff of Trevor's change (rebased against current trunk) to this update.</p> Ruby master - Bug #11526: Streaming HTTP requests are not idempotent and should not be retriedhttps://redmine.ruby-lang.org/issues/11526?journal_id=542012015-09-15T20:00:38Ztdg5 (Danny Guinther)dannyguinther@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/5498">trowe-net-http-idempotent-retry-fix-with-test-fixes.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5498/trowe-net-http-idempotent-retry-fix-with-test-fixes.diff">trowe-net-http-idempotent-retry-fix-with-test-fixes.diff</a> added</li></ul><p>Attaching a new diff based on Trevor's branch with a few additional test fixes.</p>
<p>All HTTP-related tests pass, but seems like something in RDoc may be broken in trunk:</p>
<pre><code> 1) Failure:
TestRDocMarkupPreProcess#test_include_file_in_other_directory [/home/danny/src/ruby-trunk/test/rdoc/test_rdoc_markup_pre_process.rb:84]:
--- expected
+++ actual
@@ -1,2 +1 @@
-"test file
-"
+""
</code></pre> Ruby master - Bug #11526: Streaming HTTP requests are not idempotent and should not be retriedhttps://redmine.ruby-lang.org/issues/11526?journal_id=790112019-07-01T21:16:17Zjeremyevans0 (Jeremy Evans)merch-redmine@jeremyevans.net
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>naruse (Yui NARUSE)</i></li></ul> Ruby master - Bug #11526: Streaming HTTP requests are not idempotent and should not be retriedhttps://redmine.ruby-lang.org/issues/11526?journal_id=1042132023-08-22T22:29:31Zjeremyevans0 (Jeremy Evans)merch-redmine@jeremyevans.net
<ul></ul><p>A fix for this has been submitted as an upstream pull request: <a href="https://github.com/ruby/net-http/pull/87" class="external">https://github.com/ruby/net-http/pull/87</a></p> Ruby master - Bug #11526: Streaming HTTP requests are not idempotent and should not be retriedhttps://redmine.ruby-lang.org/issues/11526?journal_id=1060322024-01-05T17:06:01Zjeremyevans0 (Jeremy Evans)merch-redmine@jeremyevans.net
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul>