https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112015-06-12T08:04:20ZRuby Issue Tracking SystemRuby master - Feature #11252: Integrated "did_you_mean" gem to ruby-corehttps://redmine.ruby-lang.org/issues/11252?journal_id=528642015-06-12T08:04:20Zhsbt (Hiroshi SHIBATA)hsbt@ruby-lang.org
<ul><li><strong>Assignee</strong> set to <i>hsbt (Hiroshi SHIBATA)</i></li></ul> Ruby master - Feature #11252: Integrated "did_you_mean" gem to ruby-corehttps://redmine.ruby-lang.org/issues/11252?journal_id=528662015-06-12T08:12:43Zmatz (Yukihiro Matsumoto)matz@ruby.or.jp
<ul></ul><p>Approved. Go ahead and resolve issues related to merge.</p>
<p>Matz.</p> Ruby master - Feature #11252: Integrated "did_you_mean" gem to ruby-corehttps://redmine.ruby-lang.org/issues/11252?journal_id=529492015-06-16T12:03:17Zyuki24 (Yuki Nishijima)yk.nishijima@gmail.com
<ul></ul><p>It's a great honor and privilege for me to see the did_you_mean gem become part of the language and I am really grateful to this movement.</p>
<p>I've created a branch that only works on 2.3, but has less dependencies: <a href="https://github.com/yuki24/did_you_mean/compare/master...ruby-2.3" class="external">https://github.com/yuki24/did_you_mean/compare/master...ruby-2.3</a></p>
<blockquote>
<p>integrate interception gem</p>
</blockquote>
<p>interception gem isn't actually mandatory since the branch uses TracePoint API directly to capture a binding object.</p>
<blockquote>
<p>naming(better name for did_you_mean)</p>
</blockquote>
<p>The only name I have in mind is <strong>correctable</strong>, but I'm open to sggestions. The main reason why I want to use a different name and force people to use a new one is that the current version of <code>did_you_mean</code> knows about too many external things including JRuby, Rubinius and Rails and I don't want Ruby to bundle it.</p>
<blockquote>
<p>bundled policy(standard library? bundled gem?)</p>
</blockquote>
<p>I would like the gem to be a bundled gem to minimize the maintenance cost of it, but a couple of features(e.g. <code>NoMethodError#receiver</code>: <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: NoMethodError#receiever (Closed)" href="https://redmine.ruby-lang.org/issues/10881">#10881</a>, detailed error message) have to be implemented before it is bundled.</p>
<p>Thank you again for considering adding the did_you_mean gem to the language and I would love to do whatever I can to make it happen!</p> Ruby master - Feature #11252: Integrated "did_you_mean" gem to ruby-corehttps://redmine.ruby-lang.org/issues/11252?journal_id=529782015-06-17T08:49:32Zduerst (Martin Dürst)duerst@it.aoyama.ac.jp
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/11032">Feature #11032</a>: Add a warning for misspelling "def intialize"</i> added</li></ul> Ruby master - Feature #11252: Integrated "did_you_mean" gem to ruby-corehttps://redmine.ruby-lang.org/issues/11252?journal_id=539512015-08-22T07:04:20Zyuki24 (Yuki Nishijima)yk.nishijima@gmail.com
<ul></ul><p>We've discussed this at the Ruby developers meeting on Thursday and made several decisions(but still subject to change).</p>
<ul>
<li>
<p>We are not going to rename the gem (we'll just use <code>did_you_mean</code>)</p>
</li>
<li>
<p>It'll be a bundled gem (Yuki will be responsible for releasing a version that works on Ruby 2.3 without C extensions)</p>
</li>
<li>
<p>There should be a way of disabling this feature entirely (<code>--disable-gem did_you_mean</code> or <code>--disable-gemname</code>)</p>
</li>
<li>
<p>There should be a method on <code>NameError</code> that returns a qualified name:</p>
<pre><code class="ruby syntaxhl" data-language="ruby"><span class="k">class</span> <span class="nc">User</span><span class="p">;</span> <span class="k">end</span>
<span class="n">error</span> <span class="o">=</span> <span class="k">begin</span>
<span class="no">User</span><span class="o">::</span><span class="no">DoesntExist</span>
<span class="k">rescue</span> <span class="no">NameError</span> <span class="o">=></span> <span class="n">e</span>
<span class="n">e</span>
<span class="k">end</span>
<span class="n">error</span><span class="p">.</span><span class="nf">name</span> <span class="c1"># => :Exist</span>
<span class="n">error</span><span class="p">.</span><span class="nf">qualified_name</span> <span class="c1"># => :"User::DoesntExist"</span>
</code></pre>
</li>
</ul>
<p>The last 2 features can be separate features. That said, since the last one is a blocker, it would be great if this could be done before actually bundling the <code>did_you_mean</code> gem.</p> Ruby master - Feature #11252: Integrated "did_you_mean" gem to ruby-corehttps://redmine.ruby-lang.org/issues/11252?journal_id=540802015-09-08T12:55:06ZAnonymous
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset r51795.</p>
<hr>
<p>gems/bundled_gems: Automatically install the did_you_mean gem as a bunlded gem.<br>
[Feature <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Integrated "did_you_mean" gem to ruby-core (Closed)" href="https://redmine.ruby-lang.org/issues/11252">#11252</a>]</p> Ruby master - Feature #11252: Integrated "did_you_mean" gem to ruby-corehttps://redmine.ruby-lang.org/issues/11252?journal_id=540932015-09-09T07:24:29ZHanmac (Hans Mackowiak)hanmac@gmx.de
<ul></ul><p>shouldnt that be fixed to "1.0.0.beta2" because "1.0.0.beta1" got yanked?</p>