https://redmine.ruby-lang.org/
https://redmine.ruby-lang.org/favicon.ico?1711330511
2009-02-02T12:00:27Z
Ruby Issue Tracking System
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=2854
2009-02-02T12:00:27Z
ko1 (Koichi Sasada)
<ul><li><strong>Assignee</strong> set to <i>zenspider (Ryan Davis)</i></li><li><strong>ruby -v</strong> set to <i> 1.9.1p5000 (2009-01-31 trunk 21924) [i386-darwin9.6.0]</i></li></ul><p>=begin</p>
<p>=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=3058
2009-02-04T08:23:07Z
zenspider (Ryan Davis)
<ul></ul><p>=begin</p>
<p>On Feb 1, 2009, at 05:26 , Takao Kouji wrote:</p>
<blockquote>
<p>Hi, Ryan.</p>
<p>I use ruby 1.9.1p5000 (2009-01-31 trunk 21924) [i386-darwin9.6.0].<br>
I got the error message, after I run 'gem install --test '.</p>
<p>ERROR: While executing gem ... (NoMethodError)<br>
undefined method `passed?' for #<a href="MiniTest::Unit:0x77d1fc" class="external">MiniTest::Unit:0x77d1fc</a></p>
<p>The source of the problem is called MiniTest::Unit#passed? at<br>
lib/rubygems/commands/install_command.rb:136.</p>
<p>The attached patch will fix the problem.</p>
<a name="Index-unitrb"></a>
<h1 >Index: unit.rb<a href="#Index-unitrb" class="wiki-anchor">¶</a></h1>
<p>--- unit.rb (revision 21924)<br>
+++ unit.rb (working copy)<br>
@@ -429,6 +429,10 @@<br>
[@test_count, @assertion_count]<br>
end</p>
<ul>
<li>def passed?</li>
<li>
<pre><code> return (failures + errors) == 0
</code></pre>
</li>
<li>end</li>
</ul>
</blockquote>
<p>this is a rubygems issue that we'll fix on that side instead.</p>
<p>=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=7121
2009-12-03T00:57:53Z
naruse (Yui NARUSE)
naruse@airemix.jp
<ul><li><strong>Category</strong> set to <i>lib</i></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> changed from <i>zenspider (Ryan Davis)</i> to <i>drbrain (Eric Hodel)</i></li><li><strong>Priority</strong> changed from <i>3</i> to <i>6</i></li><li><strong>Target version</strong> set to <i>1.9.2</i></li></ul><p>=begin</p>
<p>=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=9356
2010-03-26T07:32:34Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul><li><strong>Assignee</strong> changed from <i>drbrain (Eric Hodel)</i> to <i>zenspider (Ryan Davis)</i></li></ul><p>=begin<br>
This is a minitest issue.<br>
=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=10170
2010-04-14T02:11:12Z
mame (Yusuke Endoh)
mame@ruby-lang.org
<ul></ul><p>=begin<br>
Hi, Eric Hodel</p>
<p>Couldn't you fix this on rubygems side?<br>
I hope this will be fixed ASAP.</p>
<p>Well, he is pigheaded...</p>
<p>diff --git a/lib/rubygems/validator.rb b/lib/rubygems/validator.rb<br>
index 38ee62f..26303df 100644<br>
--- a/lib/rubygems/validator.rb<br>
+++ b/lib/rubygems/validator.rb<br>
@@ -234,6 +234,13 @@ class Gem::Validator<br>
result = MiniTest::Unit.new<br>
result.run</p>
<ul>
<li>
<a name="workaround-for-minitest"></a>
<h1 >workaround for minitest<a href="#workaround-for-minitest" class="wiki-anchor">¶</a></h1>
</li>
<li>class << result</li>
<li>
<pre><code> def passed?
</code></pre>
</li>
<li>
<pre><code> return (failures + errors) == 0
</code></pre>
</li>
<li>
<pre><code> end
</code></pre>
</li>
<li>end</li>
<li>result<br>
ensure<br>
Dir.chdir(start_dir)</li>
</ul>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=10174
2010-04-14T09:20:13Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul></ul><p>=begin<br>
On Apr 13, 2010, at 10:11, Yusuke Endoh wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Got the error message, after run 'gem install --test'. (Closed)" href="https://redmine.ruby-lang.org/issues/1085">#1085</a> has been updated by Yusuke Endoh.</p>
<p>Hi, Eric Hodel</p>
<p>Couldn't you fix this on rubygems side?<br>
I hope this will be fixed ASAP.</p>
</blockquote>
<p>I think so. I will be dedicating time later this week to RubyGems and 1.9.2.</p>
<blockquote>
<p>Well, he is pigheaded...</p>
</blockquote>
<p>Maybe I can publicly shame him into fixing this correctly instead of via RubyGems:</p>
<p>17:15 me: hahaha<br>
17:15 me: read ruby-core:29499<br>
17:16 Ryan: hah<br>
17:17 Ryan: Ryan Davis disconnected</p>
<p>=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=10326
2010-04-19T15:54:05Z
zenspider (Ryan Davis)
<ul></ul><p>=begin</p>
<p>On Apr 13, 2010, at 17:19 , Eric Hodel wrote:</p>
<blockquote>
<p>On Apr 13, 2010, at 10:11, Yusuke Endoh wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Got the error message, after run 'gem install --test'. (Closed)" href="https://redmine.ruby-lang.org/issues/1085">#1085</a> has been updated by Yusuke Endoh.</p>
<p>Hi, Eric Hodel</p>
<p>Couldn't you fix this on rubygems side?<br>
I hope this will be fixed ASAP.</p>
</blockquote>
<p>I think so. I will be dedicating time later this week to RubyGems and 1.9.2.</p>
<blockquote>
<p>Well, he is pigheaded...</p>
</blockquote>
<p>Maybe I can publicly shame him into fixing this correctly instead of via RubyGems:</p>
<p>17:15 me: hahaha<br>
17:15 me: read ruby-core:29499<br>
17:16 Ryan: hah<br>
17:17 Ryan: Ryan Davis disconnected</p>
</blockquote>
<p>All pigheadedness aside, why is it is a bug that rubygems doesn't work with minitest when it isn't a bug that it doesn't work with bacon, rspec, and every other test framework under the sun? Since ruby doesn't have a real standard project layout and a unified testing setup (like the way perl does), it isn't reasonable to expect that rubygems' "--test" flag be able to work with project and their tests/specs/stories/whatever-we-come-up-with-nexts.</p>
<p>=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=10345
2010-04-20T02:55:12Z
mame (Yusuke Endoh)
mame@ruby-lang.org
<ul></ul><p>=begin<br>
Hi,</p>
<p>2010/4/19 Ryan Davis <a href="mailto:ryand-ruby@zenspider.com" class="email">ryand-ruby@zenspider.com</a>:</p>
<blockquote>
<p>All pigheadedness aside, why is it is a bug that rubygems doesn't work with minitest when it isn't a bug that it doesn't work with bacon, rspec, and every other test framework under the sun? Since ruby doesn't have a real standard project layout and a unified testing setup (like the way perl does), it isn't reasonable to expect that rubygems' "--test" flag be able to work with project and their tests/specs/stories/whatever-we-come-up-with-nexts.</p>
</blockquote>
<p>I guess that rubygems' "--test" flag was created in consideration of<br>
test/unit. And actually, the old test/unit had provided "passed?"<br>
before it was replaced with minitest.</p>
<p>I can understand you if test/unit compat layer of minitest provides<br>
"passed?". If it does so, I think this is a fault of rubygems that<br>
uses minitest but not test/unit.</p>
<p>--<br>
Yusuke ENDOH <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a></p>
<p>=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=10354
2010-04-20T16:02:23Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul></ul><p>=begin<br>
On Apr 19, 2010, at 10:54, Yusuke ENDOH wrote:</p>
<blockquote>
<p>2010/4/19 Ryan Davis <a href="mailto:ryand-ruby@zenspider.com" class="email">ryand-ruby@zenspider.com</a>:</p>
<blockquote>
<p>All pigheadedness aside, why is it is a bug that rubygems doesn't work with minitest when it isn't a bug that it doesn't work with bacon, rspec, and every other test framework under the sun? Since ruby doesn't have a real standard project layout and a unified testing setup (like the way perl does), it isn't reasonable to expect that rubygems' "--test" flag be able to work with project and their tests/specs/stories/whatever-we-come-up-with-nexts.</p>
</blockquote>
<p>I guess that rubygems' "--test" flag was created in consideration of<br>
test/unit. And actually, the old test/unit had provided "passed?"<br>
before it was replaced with minitest.</p>
<p>I can understand you if test/unit compat layer of minitest provides<br>
"passed?". If it does so, I think this is a fault of rubygems that<br>
uses minitest but not test/unit.</p>
</blockquote>
<p>I think it would be better to remove --test from RubyGems since it can't work everywhere.</p>
<p>If the community finds it important they can implement it using a gem plugin. It is too hard for me to make RubyGems support every possible test library and it is too hard to get every possible test library to support a common API.</p>
<p>=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=10490
2010-04-23T19:30:15Z
mame (Yusuke Endoh)
mame@ruby-lang.org
<ul><li><strong>Assignee</strong> changed from <i>zenspider (Ryan Davis)</i> to <i>drbrain (Eric Hodel)</i></li></ul><p>=begin<br>
Hi,</p>
<blockquote>
<p>I think it would be better to remove --test from RubyGems since it can't work everywhere.</p>
</blockquote>
<p>You are the maintainer.<br>
Maintainer should respect compatibility and opinions of others,<br>
but can finally make decision, I think.</p>
<p>I think it is best for test/unit to provide passed? again, but<br>
if it is impossible, removing --test is better than current.</p>
<p>Eric, please make decision.</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=10907
2010-05-10T23:40:17Z
mame (Yusuke Endoh)
mame@ruby-lang.org
<ul></ul><p>=begin<br>
Hi, Eric</p>
<p>Any update here?</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=10919
2010-05-11T03:08:19Z
luislavena (Luis Lavena)
luislavena@gmail.com
<ul></ul><p>=begin<br>
On Mon, May 10, 2010 at 11:40 AM, Yusuke Endoh <a href="mailto:redmine@ruby-lang.org" class="email">redmine@ruby-lang.org</a> wrote:</p>
<blockquote>
<p>Issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Got the error message, after run 'gem install --test'. (Closed)" href="https://redmine.ruby-lang.org/issues/1085">#1085</a> has been updated by Yusuke Endoh.</p>
<p>Hi, Eric</p>
<p>Any update here?</p>
</blockquote>
<h2>AFAIk --test option has and will be deprecated in newer version of<br>
RubyGems since every package uses different testing framework and<br>
tools, turning the --test option useless.</h2>
<h2>Luis Lavena<br>
AREA 17</h2>
<p>Perfection in design is achieved not when there is nothing more to add,<br>
but rather when there is nothing more to take away.<br>
Antoine de Saint-Exupéry</p>
<p>=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=11494
2010-06-06T22:55:06Z
mame (Yusuke Endoh)
mame@ruby-lang.org
<ul></ul><p>=begin<br>
Hi, Eric</p>
<p>Any update here?</p>
<p>This is the second reminder for this ticket (though I send you<br>
many reminders).<br>
There is a Japanese proverb: Hotoke no kao mo sando made.</p>
<p>I'll close this ticket by committing this patch unless you show<br>
your solution within three days:</p>
<p>diff --git a/lib/rubygems/install_update_options.rb b/lib/rubygems/install_update_options.rb<br>
index c3fa2d5..4e7f9e7 100644<br>
--- a/lib/rubygems/install_update_options.rb<br>
+++ b/lib/rubygems/install_update_options.rb<br>
@@ -59,8 +59,7 @@ module Gem::InstallUpdateOptions<br>
end</p>
<pre><code> add_option(:"Install/Update", '-t', '--[no-]test',
</code></pre>
<ul>
<li>
<pre><code> 'Run unit tests prior to installation') do |value, options|
</code></pre>
</li>
<li>
<pre><code> options[:test] = value
</code></pre>
</li>
</ul>
<ul>
<li>
<pre><code> 'Ignored; just for compatiblity') do |value, options|
</code></pre>
<p>end</p>
<p>add_option(:"Install/Update", '-w', '--[no-]wrappers',<br>
@@ -110,7 +109,7 @@ module Gem::InstallUpdateOptions</p>
<a name="Default-options-for-the-gem-install-command"></a>
<h1 >Default options for the gem install command.<a href="#Default-options-for-the-gem-install-command" class="wiki-anchor">¶</a></h1>
<p>def install_update_defaults_str</p>
</li>
</ul>
<ul>
<li>'--rdoc --no-force --no-test --wrappers'</li>
</ul>
<ul>
<li>'--rdoc --no-force --wrappers'<br>
end</li>
</ul>
<p>end<br>
diff --git a/test/rubygems/test_gem_command_manager.rb b/test/rubygems/test_gem_command_manager.rb<br>
index c81cc59..815798a 100644<br>
--- a/test/rubygems/test_gem_command_manager.rb<br>
+++ b/test/rubygems/test_gem_command_manager.rb<br>
@@ -67,7 +67,6 @@ class TestGemCommandManager < RubyGemTestCase<br>
check_options = nil<br>
@command_manager.process_args(<br>
"install --force --test --local --rdoc --install-dir . --version 3.0 --no-wrapper --bindir . ")</p>
<ul>
<li>
<pre><code> assert_equal true, check_options[:test]
assert_equal true, check_options[:generate_rdoc]
assert_equal true, check_options[:force]
assert_equal :local, check_options[:domain]
</code></pre>
</li>
</ul>
<p>@@ -197,7 +196,6 @@ class TestGemCommandManager < RubyGemTestCase<br>
#check settings<br>
check_options = nil<br>
@command_manager.process_args("update --force --test --rdoc --install-dir .")</p>
<ul>
<li>assert_equal true, check_options[:test]<br>
assert_equal true, check_options[:generate_rdoc]<br>
assert_equal true, check_options[:force]<br>
assert_equal Dir.pwd, check_options[:install_dir]</li>
</ul>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a><br>
=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=11575
2010-06-09T12:48:37Z
drbrain (Eric Hodel)
drbrain@segment7.net
<ul></ul><p>=begin<br>
I like your patch. Please commit it.<br>
=end</p>
Ruby master - Bug #1085: Got the error message, after run 'gem install --test'.
https://redmine.ruby-lang.org/issues/1085?journal_id=11624
2010-06-11T22:47:05Z
mame (Yusuke Endoh)
mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>=begin<br>
This issue was solved with changeset r28279.<br>
Kouji, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<p>=end</p>