Feature #3631: [PATCH] lib/rake.rb: allow passing nil to sh() and ruby()

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -

[sunaku (Suraj Kurapati)]

=begin
This patch allows you to pass nil values to Rake's sh() and ruby()
methods. This is useful when you want to conditionally pass arguments
to the child program you are executing.

For example, suppose you want to pass '-v' to a child program if the
user ran Rake in tracing mode (rake --trace), but not otherwise:

sh 'asciidoc', ('-v' if Rake.application.options.trace), 'input.txt'

Without this patch, you have to carefully construct an arguments array
so that it does not contain nil values:

args = []
args << '-v' if Rake.application.options.trace
args << 'input.txt'
sh 'asciidoc', *args

Sadly, this becomes very tiresome when performed more than a few times.

Thanks for your consideration.
=end

[nobu (Nobuyoshi Nakada)]

=begin
Hi,

At Fri, 30 Jul 2010 14:02:21 +0900,
Suraj Kurapati wrote in [ruby-core:31551]:

For example, suppose you want to pass '-v' to a child program if the
user ran Rake in tracing mode (rake --trace), but not otherwise:

sh 'asciidoc', ('-v' if Rake.application.options.trace), 'input.txt'

In 1.9, you can write as:

sh 'asciidoc', *('-v' if Rake.application.options.trace), 'input.txt'

--
Nobu Nakada

=end

[sunaku (Suraj Kurapati)]

=begin
Thanks for the tip Nobu! :-)
=end

[shyouhei (Shyouhei Urabe)]

• Status changed from Open to Assigned
• Assignee set to nobu (Nobuyoshi Nakada)

=begin

=end

[sunaku (Suraj Kurapati)]

I submitted this patch directly to the Rake project:

https://github.com/jimweirich/rake/pull/79

If it is accepted there, then perhaps someday it will
find its way back into ruby-core. One can only dream. :)

[sunaku (Suraj Kurapati)]

Patch was rejected upstream, so please close this issue.

[drbrain (Eric Hodel)]

• Status changed from Assigned to Closed